On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> Mark 3 tests as flagless to don't run them if not needed. Also, small clean > up. So vm.flagless is to be used for any test that spawns a process and does not pass the vm flags on to that process? I understand the rationale, but still have my concern that these tests not running if any flags are specified. Perhaps vm.flagless could be combined with some other JTREG flag that has to be explicitly set to indicate not to run vm.flagless tests if a vm flag is set. CI could pass this flag (because it knows there is at least one test task that will run the test), but regular users of `make test` would not set the flag, allowing the vm.flagless tests to run. Maybe something like JTREG_RUN_VM_FLAGLESS. Have it default to true. Let CI set it to false. The end result of JTREG_RUN_VM_FLAGLESS=false would be to set vm.flagless true even if flags are specified. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15407#issuecomment-1692473462
