On Wed, 16 Aug 2023 08:09:42 GMT, Matthias Baesken wrote:
> AttachListener::pd_set_flag is the same across platforms (always returning
> JNI_ERR ). So it can be centralized or removed.
This pull request has now been integrated.
Changeset: 5058854b
Author:Matthias Baesken
URL:
https
On Wed, 16 Aug 2023 08:09:42 GMT, Matthias Baesken wrote:
> AttachListener::pd_set_flag is the same across platforms (always returning
> JNI_ERR ). So it can be centralized or removed.
Hi Chris, Martin, Serguei, thanks for the reviews !
-
PR Comment: https://git.openjdk.org/jdk/pu
On Thu, 17 Aug 2023 15:51:47 GMT, Aleksey Shipilev wrote:
>> Current test expects `G1HeapRegionSize` flag to be printed out from jmap.
>> But that one is not printed when Shenandoah is enabled. I opted for the
>> minimally intrusive fix: move the additional Shenandoah printout to the
>> Shenan
On Thu, 17 Aug 2023 17:01:10 GMT, Alexander Zvegintsev
wrote:
>> A trivial fix to ProblemList
>> runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all with ZGC.
>
> Marked as reviewed by azvegint (Reviewer).
@azvegint - Thanks for the lightning fast review!
-
PR Comme
A trivial fix to ProblemList
runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all with ZGC.
-
Commit messages:
- 8314533: ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on
linux-all with ZGC
Changes: https://git.openjdk.org/jdk/pull/15333/files
Webr
On Thu, 17 Aug 2023 16:58:41 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all with ZGC.
This pull request has now been integrated.
Changeset: 2505cebc
Author:Daniel D. Daugherty
URL:
https://git.open
On Thu, 17 Aug 2023 16:58:41 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all with ZGC.
Marked as reviewed by azvegint (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15333#pullrequestrevi
On Thu, 17 Aug 2023 15:51:47 GMT, Aleksey Shipilev wrote:
>> Current test expects `G1HeapRegionSize` flag to be printed out from jmap.
>> But that one is not printed when Shenandoah is enabled. I opted for the
>> minimally intrusive fix: move the additional Shenandoah printout to the
>> Shenan
On Thu, 17 Aug 2023 16:56:39 GMT, Serguei Spitsyn wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More fixes
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/HeapSummary.java
> line 90:
>
>> 88:
On Thu, 17 Aug 2023 16:33:17 GMT, Chris Plummer wrote:
>> [JDK-8250630](https://bugs.openjdk.org/browse/JDK-8250630) introduced the
>> following change:
>>
>>
>> if (listenAddr == NULL) {
>> +// No address of preferred addres family found, grab the fist one.
>> +listenAddr
On Wed, 16 Aug 2023 08:09:42 GMT, Matthias Baesken wrote:
> AttachListener::pd_set_flag is the same across platforms (always returning
> JNI_ERR ). So it can be centralized or removed.
Looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git
On Thu, 17 Aug 2023 16:33:17 GMT, Chris Plummer wrote:
>> [JDK-8250630](https://bugs.openjdk.org/browse/JDK-8250630) introduced the
>> following change:
>>
>>
>> if (listenAddr == NULL) {
>> +// No address of preferred addres family found, grab the fist one.
>> +listenAddr
> [JDK-8250630](https://bugs.openjdk.org/browse/JDK-8250630) introduced the
> following change:
>
>
> if (listenAddr == NULL) {
> +// No address of preferred addres family found, grab the fist one.
> +listenAddr = &(addrInfo[0]);
> +}
> +
> +if (listenAddr == NULL) {
On Thu, 17 Aug 2023 15:06:44 GMT, Chris Plummer wrote:
> [JDK-8250630](https://bugs.openjdk.org/browse/JDK-8250630) introduced the
> following change:
>
>
> if (listenAddr == NULL) {
> +// No address of preferred addres family found, grab the fist one.
> +listenAddr = &(ad
On Wed, 16 Aug 2023 08:09:42 GMT, Matthias Baesken wrote:
> AttachListener::pd_set_flag is the same across platforms (always returning
> JNI_ERR ). So it can be centralized or removed.
Nice cleanup!
-
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk
On Thu, 17 Aug 2023 15:41:18 GMT, Aleksey Shipilev wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/HeapSummary.java
>> line 89:
>>
>>> 87: printValMB("CompressedClassSpaceSize = ",
>>> getFlagValue("CompressedClassSpaceSize", flagMap));
>>> 88: printValMB("MaxMe
> Current test expects `G1HeapRegionSize` flag to be printed out from jmap. But
> that one is not printed when Shenandoah is enabled. I opted for the minimally
> intrusive fix: move the additional Shenandoah printout to the
> Shenandoah-specific block.
>
> Additional testing:
> - [x] Affected
On Thu, 17 Aug 2023 15:13:16 GMT, Chris Plummer wrote:
>> Current test expects `G1HeapRegionSize` flag to be printed out from jmap.
>> But that one is not printed when Shenandoah is enabled. I opted for the
>> minimally intrusive fix: move the additional Shenandoah printout to the
>> Shenandoa
On Wed, 16 Aug 2023 08:09:42 GMT, Matthias Baesken wrote:
> AttachListener::pd_set_flag is the same across platforms (always returning
> JNI_ERR ). So it can be centralized or removed.
Marked as reviewed by cjplummer (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15304#
On Fri, 11 Aug 2023 01:49:57 GMT, Chris Plummer wrote:
> On OSX, don't require that sudo be used to launch SA tools if developer mode
> is enabled. More details are in the CR.
>
> Due to this change, the following tests are no longer being skipped if the
> host has developer mode is enabled.
On Fri, 11 Aug 2023 01:49:57 GMT, Chris Plummer wrote:
> On OSX, don't require that sudo be used to launch SA tools if developer mode
> is enabled. More details are in the CR.
>
> Due to this change, the following tests are no longer being skipped if the
> host has developer mode is enabled.
On Thu, 17 Aug 2023 10:11:58 GMT, Aleksey Shipilev wrote:
> Current test expects `G1HeapRegionSize` flag to be printed out from jmap. But
> that one is not printed when Shenandoah is enabled. I opted for the minimally
> intrusive fix: move the additional Shenandoah printout to the
> Shenandoah
[JDK-8250630](https://bugs.openjdk.org/browse/JDK-8250630) introduced the
following change:
if (listenAddr == NULL) {
+// No address of preferred addres family found, grab the fist one.
+listenAddr = &(addrInfo[0]);
+}
+
+if (listenAddr == NULL) {
dbgsysFree
On Sat, 12 Aug 2023 03:56:05 GMT, Chris Plummer wrote:
> VMConnection.open() expects launchTarget(), attachTarget(), and
> listentTarget() to either throw an exception or return a valid VirtualMachine
> instance. Instead they were catching certain exceptions and returning null,
> which resulte
On Sat, 12 Aug 2023 03:56:05 GMT, Chris Plummer wrote:
> VMConnection.open() expects launchTarget(), attachTarget(), and
> listentTarget() to either throw an exception or return a valid VirtualMachine
> instance. Instead they were catching certain exceptions and returning null,
> which resulte
Current test expects `G1HeapRegionSize` flag to be printed out from jmap. But
that one is not printed when Shenandoah is enabled. I opted for the minimally
intrusive fix: move the additional Shenandoah printout to the
Shenandoah-specific block.
Additional testing:
- [x] Affected test now passe
26 matches
Mail list logo
