On Tue, 1 Aug 2023 19:49:51 GMT, Leonid Mesnik wrote:
> The fix adds posting VmObjectAlloc events by Unsafe.allocateInstance(Class
> cls). The previous attempt to post event directly from
> 'LibraryCallKit::inline_unsafe_allocate()' cause performance regression even
> if jvmti event is not ena
On Fri, 4 Aug 2023 20:37:00 GMT, Serguei Spitsyn wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> The too many deopts check should be first.
>
> This looks okay to me.
> It needs to be reviewed by someone from the
> The fix adds posting VmObjectAlloc events by Unsafe.allocateInstance(Class
> cls). The previous attempt to post event directly from
> 'LibraryCallKit::inline_unsafe_allocate()' cause performance regression even
> if jvmti event is not enabled. Some optimizations have been disabled just
> bec
On Fri, 4 Aug 2023 19:45:56 GMT, Leonid Mesnik wrote:
>> The fix adds posting VmObjectAlloc events by
>> Unsafe.allocateInstance(Class cls). The previous attempt to post event
>> directly from 'LibraryCallKit::inline_unsafe_allocate()' cause performance
>> regression even if jvmti event is not
On Tue, 8 Aug 2023 18:50:25 GMT, Leonid Mesnik wrote:
> Test might times out if it suspend thread before it starts breakpoint event
> handler.
> The fix is to replace sleep with better synchronization and suspend virtual
> thread only when it runs native code.
>
> Also, the completed monitor i
On Wed, 26 Apr 2023 09:37:46 GMT, Yi Yang wrote:
> ### Motivation and proposal
> Hi, heap dump brings about pauses for application's execution(STW), this is a
> well-known pain. JDK-8252842 have added parallel support to heapdump in an
> attempt to alleviate this issue. However, all concurrent
On Tue, 8 Aug 2023 13:09:58 GMT, Kevin Walls wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> aware of serialgc and epsilongc
>
> Great, thanks for your patience with all of this! 8-)
Thank you all for reviews and sugge
On Tue, 8 Aug 2023 23:43:00 GMT, Kimura Yukihiro wrote:
>> I would like to fix this issue
>> because the svc jtreg test does not pass on localized Windows platform.
>> Testing:
>> all serviceability area tests (jdk_svc group).
>>
>> Could anyone review the fix please?
>>
>> Thanks,
>> Kimura
On Tue, 8 Aug 2023 23:17:27 GMT, Chris Plummer wrote:
>> Kimura Yukihiro has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge master
>> - 8313854: Some tests in serviceability area fail on localized Windo
> I would like to fix this issue
> because the svc jtreg test does not pass on localized Windows platform.
> Testing:
> all serviceability area tests (jdk_svc group).
>
> Could anyone review the fix please?
>
> Thanks,
> Kimura Yukihiro
Kimura Yukihiro has updated the pull request incremental
On Tue, 8 Aug 2023 23:04:43 GMT, Kimura Yukihiro wrote:
>> I would like to fix this issue
>> because the svc jtreg test does not pass on localized Windows platform.
>> Testing:
>> all serviceability area tests (jdk_svc group).
>>
>> Could anyone review the fix please?
>>
>> Thanks,
>> Kimura
On Tue, 8 Aug 2023 23:04:43 GMT, Kimura Yukihiro wrote:
>> I would like to fix this issue
>> because the svc jtreg test does not pass on localized Windows platform.
>> Testing:
>> all serviceability area tests (jdk_svc group).
>>
>> Could anyone review the fix please?
>>
>> Thanks,
>> Kimura
> I would like to fix this issue
> because the svc jtreg test does not pass on localized Windows platform.
> Testing:
> all serviceability area tests (jdk_svc group).
>
> Could anyone review the fix please?
>
> Thanks,
> Kimura Yukihiro
Kimura Yukihiro has updated the pull request with a new
Test might times out if it suspend thread before it starts breakpoint event
handler.
The fix is to replace sleep with better synchronization and suspend virtual
thread only when it runs native code.
Also, the completed monitor is acquired earlier to avoid racing when completing
test.
-
On Tue, 8 Aug 2023 18:50:25 GMT, Leonid Mesnik wrote:
> Test might times out if it suspend thread before it starts breakpoint event
> handler.
> The fix is to replace sleep with better synchronization and suspend virtual
> thread only when it runs native code.
>
> Also, the completed monitor i
On Tue, 8 Aug 2023 11:27:55 GMT, Kimura Yukihiro wrote:
> Hello Chris, I realized that my fix conflicted to another fix.
Yes, due to my changes you now have a merge conflict you'll need to resolve,
and that will involve reworking your fix.
-
PR Review Comment: https://git.openjdk.
On Tue, 8 Aug 2023 13:03:59 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all concurre
> ### Motivation and proposal
> Hi, heap dump brings about pauses for application's execution(STW), this is a
> well-known pain. JDK-8252842 have added parallel support to heapdump in an
> attempt to alleviate this issue. However, all concurrent threads
> competitively write heap data to the sam
On Fri, 4 Aug 2023 14:37:07 GMT, Coleen Phillimore wrote:
> This patch fixes Wconversion in code in the src/hotspot/share/prims
> directory. Most of the changes correct the types. jfieldID's are created
> with the int offset returned by InstanceKlass::field_offset().
> int field_offs
On Sat, 5 Aug 2023 16:21:57 GMT, Coleen Phillimore wrote:
>> This patch fixes Wconversion in code in the src/hotspot/share/prims
>> directory. Most of the changes correct the types. jfieldID's are created
>> with the int offset returned by InstanceKlass::field_offset().
>> int field_
On Tue, 8 Aug 2023 09:52:53 GMT, Kimura Yukihiro wrote:
>> test/jdk/sun/tools/jhsdb/JShellHeapDumpTest.java line 153:
>>
>>> 151: long startTime = System.currentTimeMillis();
>>> 152: try {
>>> 153: ProcessBuilder pb = new
>>> ProcessBuilder(JDKToolFinder.getTestJDKT
On Tue, 8 Aug 2023 09:22:07 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all concurre
On Mon, 7 Aug 2023 21:51:39 GMT, Chris Plummer wrote:
>> Kimura Yukihiro has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8313854: Some tests in serviceability area fail on localized Windows
>> platform
>
> test/jdk/sun/tools/jhsdb/JShel
> I would like to fix this issue
> because the svc jtreg test does not pass on localized Windows platform.
> Testing:
> all serviceability area tests (jdk_svc group).
>
> Could anyone review the fix please?
>
> Thanks,
> Kimura Yukihiro
Kimura Yukihiro has updated the pull request incremental
> ### Motivation and proposal
> Hi, heap dump brings about pauses for application's execution(STW), this is a
> well-known pain. JDK-8252842 have added parallel support to heapdump in an
> attempt to alleviate this issue. However, all concurrent threads
> competitively write heap data to the sam
On Tue, 8 Aug 2023 07:41:23 GMT, Kevin Walls wrote:
> It's not too bad to change the test to launch a LingeredApp and test the
> output, I made an attempt at that. I'll share a testcase suggestion here, see
> what you think.
Thank you for the share! It makes sense to me. This test will start J
On Fri, 4 Aug 2023 13:04:28 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all concurre
On Fri, 4 Aug 2023 13:04:28 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all concurre
28 matches
Mail list logo
