On Tue, 1 Aug 2023 20:53:45 GMT, Ashutosh Mehra wrote:
>> @ashu-mehra That was one case. I also want to know that you have tested
>> deeply nested classes; and hidden classes (if applicable). Thanks.
>
> @dholmes-ora I verified the case for hidden dynamically injected classes. The
> dumped clas
On Tue, 1 Aug 2023 08:33:24 GMT, David Holmes wrote:
>> @dholmes-ora I confirmed there is no nest-host or nest-members attributes
>> generated by this patch for a top level class which doesn't have any
>> nest-members. Is that what you wanted to verify?
>
> @ashu-mehra That was one case. I also
On Tue, 1 Aug 2023 17:32:55 GMT, Chris Plummer wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test failure on mac
>
> test/hotspot/jtreg/serviceability/HeapDump/IntegrityHeapDumpTest.java line 84:
>
>> 82:
On Tue, 1 Aug 2023 05:50:42 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all concurre
On Tue, 1 Aug 2023 05:50:42 GMT, Yi Yang wrote:
>> ### Motivation and proposal
>> Hi, heap dump brings about pauses for application's execution(STW), this is
>> a well-known pain. JDK-8252842 have added parallel support to heapdump in an
>> attempt to alleviate this issue. However, all concurre
On Mon, 31 Jul 2023 15:27:36 GMT, Ashutosh Mehra wrote:
>> @ashu-mehra you indicated that you had only done two basic manual tests to
>> check the output. You need to check it for the cases that I flagged too. In
>> the VM every top-level class is its own nest-host, but that is not expressed
>
