On Mon, 3 Jul 2023 00:19:56 GMT, David Holmes wrote:
>> Please review this attempt to fix ignored-qualifiers warning.
>>
>> Example warnings:
>>
>> src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier
>> on return type has no effect [-Wignored-qualifiers]
>>Compiled
On Fri, 30 Jun 2023 22:23:19 GMT, Alex Menkov wrote:
>> Yi Yang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> memory leak
>
> I think commit "use HandshakeClosure instead of VMOperation" is a wrong way
> to go.
> It restricts use of p
On 3/07/2023 10:55 am, David Holmes wrote:
On Fri, 30 Jun 2023 13:10:06 GMT, Coleen Phillimore wrote:
Please review change for mostly fixing return types in the constant pool and metadata
to fix -Wconversion warnings in JVMTI code. The order of preference for changes are:
1. change the type
On Fri, 30 Jun 2023 12:49:50 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/prims/jvmtiRawMonitor.cpp line 385:
>>
>>> 383: OrderAccess::fence();
>>> 384:
>>> 385: int save = _recursions;
>>
>> `_recursions` is `intx`
>
> JvmtiRawMonitor _recursions is an int. Maybe it shouldn't be.
On Fri, 30 Jun 2023 13:10:06 GMT, Coleen Phillimore wrote:
>> Please review change for mostly fixing return types in the constant pool and
>> metadata to fix -Wconversion warnings in JVMTI code. The order of
>> preference for changes are: 1. change the types to more distinct types
>> (fields
On Fri, 30 Jun 2023 13:10:06 GMT, Coleen Phillimore wrote:
>> Please review change for mostly fixing return types in the constant pool and
>> metadata to fix -Wconversion warnings in JVMTI code. The order of
>> preference for changes are: 1. change the types to more distinct types
>> (fields
On Tue, 27 Jun 2023 12:22:43 GMT, Daniel Jeliński wrote:
> Please review this attempt to fix ignored-qualifiers warning.
>
> Example warnings:
>
> src/hotspot/share/oops/method.hpp:413:19: warning: 'volatile' type qualifier
> on return type has no effect [-Wignored-qualifiers]
>CompiledMet
On Fri, 30 Jun 2023 11:27:58 GMT, Serguei Spitsyn wrote:
> The JVMTI function `SetEventNotificationMode` can set notification mode
> globally (`event_thread == nullptr`) for all threads or for a specific thread
> (`event_thread != nullptr`). To get a stable mount/unmount vision of virtual
> th
