Re: RFR: JDK-8306441: Two-stage Segmented Heap Dump [v10]

2023-06-16 Thread Alex Menkov
On Sat, 17 Jun 2023 00:22:09 GMT, Alex Menkov wrote: >> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> whitespace > > src/hotspot/share/services/diagnosticCommand.cpp line 474: > >> 472: _overwrite("-overwrite", "If specified

Re: RFR: JDK-8306441: Two-stage Segmented Heap Dump [v10]

2023-06-16 Thread Alex Menkov
On Wed, 14 Jun 2023 06:54:10 GMT, Yi Yang wrote: >> ### Motivation and proposal >> Hi, heap dump brings about pauses for application's execution(STW), this is >> a well-known pain. JDK-8252842 have added parallel support to heapdump in an >> attempt to alleviate this issue. However, all concurr

Integrated: 8309632: JDK 21 RDP1 L10n resource files update

2023-06-16 Thread Justin Lu
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote: > Please review this PR which updates the JDK's localized resources since the > previous L10n translation drop (1/26). > > To help with reviewing the changes, @jonathan-gibbons created a tool which > displays the localized changes next to the

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-16 Thread Naoto Sato
On Fri, 16 Jun 2023 04:39:42 GMT, Justin Lu wrote: >> Please review this PR which updates the JDK's localized resources since the >> previous L10n translation drop (1/26). >> >> To help with reviewing the changes, @jonathan-gibbons created a tool which >> displays the localized changes next to

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-16 Thread Daniel D . Daugherty
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Integrated: 8309605: StubRoutines are not used by SA

2023-06-16 Thread Coleen Phillimore
On Fri, 16 Jun 2023 13:28:26 GMT, Coleen Phillimore wrote: > Please remove this trivial fix to remove StubRoutines that the SA doesn't use. > Tested serviceability/sa tests. This pull request has now been integrated. Changeset: 71baf00a Author:Coleen Phillimore URL: https://git.open

Re: RFR: 8309605: StubRoutines are not used by SA [v2]

2023-06-16 Thread Coleen Phillimore
On Fri, 16 Jun 2023 13:45:06 GMT, Coleen Phillimore wrote: >> Please remove this trivial fix to remove StubRoutines that the SA doesn't >> use. >> Tested serviceability/sa tests. > > Coleen Phillimore has updated the pull request with a new target base due to > a merge or a rebase. The pull req

Re: RFR: JDK-8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX [v2]

2023-06-16 Thread Chris Plummer
On Fri, 16 Jun 2023 11:59:39 GMT, Matthias Baesken wrote: >> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , >> the following test started to fail on AIX : >> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output : >> >> java.lang.RuntimeException

Re: RFR: 8309605: StubRoutines are not used by SA [v2]

2023-06-16 Thread Chris Plummer
On Fri, 16 Jun 2023 13:45:06 GMT, Coleen Phillimore wrote: >> Please remove this trivial fix to remove StubRoutines that the SA doesn't >> use. >> Tested serviceability/sa tests. > > Coleen Phillimore has updated the pull request with a new target base due to > a merge or a rebase. The pull req

Re: RFR: 8309979: BootstrapMethods attribute is missing in class files recreated by SA [v2]

2023-06-16 Thread Ashutosh Mehra
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote: >> Please review this PR that extends SA to write BootstrapMethods attribute >> when dumping the class files. >> >> Tested it by dumping the class file for java/lang/String and comparing the >> BootstrapMethods attribute shown by javap fo

Re: RFR: 8309979: BootstrapMethods attribute is missing in class files recreated by SA [v2]

2023-06-16 Thread Chris Plummer
On Thu, 15 Jun 2023 20:24:39 GMT, Ashutosh Mehra wrote: >> Please review this PR that extends SA to write BootstrapMethods attribute >> when dumping the class files. >> >> Tested it by dumping the class file for java/lang/String and comparing the >> BootstrapMethods attribute shown by javap fo

Integrated: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing

2023-06-16 Thread Daniel D . Daugherty
On Fri, 16 Jun 2023 17:10:08 GMT, Daniel D. Daugherty wrote: > A trivia fix for > serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java > failing. This pull request has now been integrated. Changeset: 16134f44 Author:Daniel D. Daugherty URL: https://git.openjdk

Re: Integrated: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing

2023-06-16 Thread Daniel D . Daugherty
On Fri, 16 Jun 2023 17:26:38 GMT, Mikael Vidstedt wrote: >> A trivia fix for >> serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java >> failing. > > Marked as reviewed by mikael (Reviewer). @vidmik - Thanks for the review! It appears that the bots are running very, very sl

Re: Integrated: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing

2023-06-16 Thread Daniel D . Daugherty
On Fri, 16 Jun 2023 17:10:08 GMT, Daniel D. Daugherty wrote: > A trivia fix for > serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java > failing. This fix is being tested with an urgent Mach5 Tier1. macosx-aarch64-debug has passed the test when it failed before. linux-x6

Re: Integrated: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing

2023-06-16 Thread Mikael Vidstedt
On Fri, 16 Jun 2023 17:10:08 GMT, Daniel D. Daugherty wrote: > A trivia fix for > serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java > failing. Marked as reviewed by mikael (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14524#pullrequestreview-14

Integrated: 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing

2023-06-16 Thread Daniel D . Daugherty
A trivia fix for serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing. - Commit messages: - 8310211: serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java failing Changes: https://git.openjdk.org/jdk/pull/14524/files Webrev: https:/

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-16 Thread Naoto Sato
On Fri, 16 Jun 2023 15:06:30 GMT, Jonathan Gibbons wrote: >> Left some comments on the translations mainly in Japanese. It is now very >> easy to look at the l10n changes in the generated HTML. One small comment to >> the tool is that it would be nice if the order in HTML (alphabetically >> so

Re: RFR: 8309979: BootstrapMethods attribute is missing in class files recreated by SA [v2]

2023-06-16 Thread Ashutosh Mehra
On Thu, 15 Jun 2023 23:20:56 GMT, Chris Plummer wrote: >> Ashutosh Mehra has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments by plummercj >> >> Signed-off-by: Ashutosh Mehra > > Can you run the tests in `test/ho

Re: RFR: 8309632: JDK 21 RDP1 L10n resource files update [v2]

2023-06-16 Thread Jonathan Gibbons
On Tue, 13 Jun 2023 18:38:28 GMT, Naoto Sato wrote: > Left some comments on the translations mainly in Japanese. It is now very > easy to look at the l10n changes in the generated HTML. One small comment to > the tool is that it would be nice if the order in HTML (alphabetically sorted > curre

Re: RFR: 8310194: Generational ZGC: Lock-order asserts in JVMTI IterateThroughHeap

2023-06-16 Thread Axel Boldt-Christmas
On Fri, 16 Jun 2023 11:52:51 GMT, Stefan Karlsson wrote: > Generational ZGC changed the location where the heap object iterator called > the visit function. It used to be called when the objects were popped and > then followed, but it was changed so that the function where called > immediately

Re: RFR: 8310194: Generational ZGC: Lock-order asserts in JVMTI IterateThroughHeap

2023-06-16 Thread Erik Ă–sterlund
On Fri, 16 Jun 2023 11:52:51 GMT, Stefan Karlsson wrote: > Generational ZGC changed the location where the heap object iterator called > the visit function. It used to be called when the objects were popped and > then followed, but it was changed so that the function where called > immediately

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-16 Thread Stefan Karlsson
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Re: RFR: JDK-8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX

2023-06-16 Thread Alan Bateman
On Fri, 16 Jun 2023 11:54:52 GMT, Matthias Baesken wrote: > Hi Alan, I adjusted / simplified the coding. Thanks for taking the suggestion. - PR Comment: https://git.openjdk.org/jdk/pull/14515#issuecomment-1594595016

Re: RFR: JDK-8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX [v2]

2023-06-16 Thread Alan Bateman
On Fri, 16 Jun 2023 11:59:39 GMT, Matthias Baesken wrote: >> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , >> the following test started to fail on AIX : >> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output : >> >> java.lang.RuntimeException

RFR: 8310194: Generational ZGC: Lock-order asserts in JVMTI IterateThroughHeap

2023-06-16 Thread Stefan Karlsson
Generational ZGC changed the location where the heap object iterator called the visit function. It used to be called when the objects were popped and then followed, but it was changed so that the function where called immediately when the objects are marked. This gave the benefit that the verifi

Re: RFR: 8310194: Generational ZGC: Lock-order asserts in JVMTI IterateThroughHeap

2023-06-16 Thread Stefan Karlsson
On Fri, 16 Jun 2023 11:52:51 GMT, Stefan Karlsson wrote: > Generational ZGC changed the location where the heap object iterator called > the visit function. It used to be called when the objects were popped and > then followed, but it was changed so that the function where called > immediately

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-16 Thread Erik Ă–sterlund
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Re: RFR: JDK-8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX

2023-06-16 Thread Matthias Baesken
On Fri, 16 Jun 2023 10:44:47 GMT, Matthias Baesken wrote: > After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , > the following test started to fail on AIX : > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output : > > java.lang.RuntimeException: 'WA

Re: RFR: JDK-8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX [v2]

2023-06-16 Thread Matthias Baesken
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , > the following test started to fail on AIX : > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output : > > java.lang.RuntimeException: 'WARNING: A JVM TI agent has been loaded > dynamically' found

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-16 Thread Axel Boldt-Christmas
> The current implementation for testing generational ZGC with jtreg is > implemented with a filter on the mode flag `ZGenerational`. Because of this > only environments which set this flag explicitly will run most of the tests. > So they get missed in Github Actions and for developers running j

Re: RFR: JDK-8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX

2023-06-16 Thread Alan Bateman
On Fri, 16 Jun 2023 10:44:47 GMT, Matthias Baesken wrote: > After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , > the following test started to fail on AIX : > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output : > > java.lang.RuntimeException: 'WA

RFR: JDK-8310191: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java second failure on AIX

2023-06-16 Thread Matthias Baesken
After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , the following test started to fail on AIX : com/sun/tools/attach/warnings/DynamicLoadWarningTest.java ; failure output : java.lang.RuntimeException: 'WARNING: A JVM TI agent has been loaded dynamically' found in stderr at

RFR: 8303916: ThreadLists.java inconsistent results

2023-06-16 Thread Kevin Walls
Clean backport from latest jdk repo to jdk21 for the test change: 8303916: ThreadLists.java inconsistent results - Commit messages: - Backport 8c9b85a990d955487f9141207cc83d0051defc57 Changes: https://git.openjdk.org/jdk21/pull/24/files Webrev: https://webrevs.openjdk.org/?repo=jdk

RFR: 8310187: Improve Generational ZGC jtreg testing

2023-06-16 Thread Axel Boldt-Christmas
The current implementation for testing generational ZGC with jtreg is implemented with a filter on the mode flag `ZGenerational`. Because of this only environments which set this flag explicitly will run most of the tests. So they get missed in Github Actions and for developers running jtreg loc

Integrated: 8303916: ThreadLists.java inconsistent results

2023-06-16 Thread Kevin Walls
On Wed, 14 Jun 2023 09:30:49 GMT, Kevin Walls wrote: > This test fails when additional threads are created, as it compares thread > lists from different sources and sees a mismatch. > > It needs to tolerate some threads with certain names appearing, e.g. JVMCI > and ForkJoin threads. If there

Integrated: 8309408: Thread.sleep cleanup

2023-06-16 Thread Alan Bateman
On Sun, 4 Jun 2023 11:28:33 GMT, Alan Bateman wrote: > Thread.sleep has had quite a bit of churn recently to support virtual > threads, add sleep(Duration), a JFR event, and the change the underlying > implementation to support sub-millis precision. I think the changes have > settled down now