Re: RFR: 8308986: Disable svc tests failing with virtual thread factory

2023-05-27 Thread Alan Bateman
On Sat, 27 May 2023 20:21:46 GMT, Leonid Mesnik wrote: > Disable test > java/util/concurrent/locks/Lock/OOMEInAQS.java > Test provokes OOME and might catch it in an unexpected location. It looks > like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. > However, generally the OOM

Re: RFR: 8308286 Fix clang warnings in linux code

2023-05-27 Thread Kim Barrett
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote: > When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. All of the -Wformat-nonliteral changes make me wonder why we're seeing these with clang but not

Re: RFR: 8308286 Fix clang warnings in linux code

2023-05-27 Thread Kim Barrett
On Fri, 26 May 2023 07:48:06 GMT, Daniel JeliƄski wrote: > According to our docs, [clang is a supported compiler for > Linux](https://github.com/openjdk/jdk/blob/master/doc/building.md#native-compiler-toolchain-requirements). I think that's aspirational rather than actual. Clang has been inclu

RFR: 8308986: Disable svc tests failing with virtual thread factory

2023-05-27 Thread Leonid Mesnik
Disable test java/util/concurrent/locks/Lock/OOMEInAQS.java Test provokes OOME and might catch it in an unexpected location. It looks like an issue similar to https://bugs.openjdk.org/browse/JDK-8298066. However, generally the OOME might be thrown mount/umount or in unparker thread. There are no

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-27 Thread Kim Barrett
On Sat, 27 May 2023 11:50:11 GMT, Thomas Stuefe wrote: >>> This one is not just to get rid of a warning. We get real test errors >>> because malloc gets replaced by vec_malloc in log tags. >> >> That does not invalidate my argument, nor does it answer my question. Those >> test errors could be

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-27 Thread Thomas Stuefe
On Sat, 27 May 2023 11:25:41 GMT, Thomas Stuefe wrote: >> This one is not just to get rid of a warning. We get real test errors >> because malloc gets replaced by vec_malloc in log tags. > >> This one is not just to get rid of a warning. We get real test errors >> because malloc gets replaced b

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-27 Thread Thomas Stuefe
On Fri, 26 May 2023 20:27:12 GMT, Martin Doerr wrote: > This one is not just to get rid of a warning. We get real test errors because > malloc gets replaced by vec_malloc in log tags. That does not invalidate my argument, nor does it answer my question. Those test errors could be also fixed by

Re: RFR: 8307478: Implementation of Prepare to Restrict The Dynamic Loading of Agents [v5]

2023-05-27 Thread Alan Bateman
On Fri, 26 May 2023 23:58:12 GMT, Andrei Pangin wrote: > When testing the proposed patch, I stumbled upon two (related) issues: Thanks for bringing this up. The question is whether dynamically loading the same same agent library N times is treated as one or N agents. Similarly, if an agent lib