Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Serguei Spitsyn
On Fri, 21 Apr 2023 18:58:22 GMT, Chris Plummer wrote: >> Do you ask this question to check if we want to extend this test to provide >> coverage for platform threads as well? >> >> The support of platform threads is much simpler. The JVMTI `StopThread` >> never returns the `THREAD_NOT_SUSPEND

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v2]

2023-04-21 Thread Serguei Spitsyn
On Fri, 21 Apr 2023 17:12:32 GMT, Alan Bateman wrote: >> Nice catch - fixed now. > > Okay but JvmtiVTMSTransitionDisabler prevent the thread from being resumed > for the -XX:-VMContinuations case? Thank you for the catch. Will check it. I have to extend the test to cover the BoundVirtualThread

Re: RFR: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again

2023-04-21 Thread Daniel D . Daugherty
On Fri, 21 Apr 2023 21:35:07 GMT, Daniel D. Daugherty wrote: > Trivial fixes to increase timeouts for tests that timeout under heavy stress: > [JDK-8301377](https://bugs.openjdk.org/browse/JDK-8301377) adjust timeout for > JLI GetObjectSizeIntrinsicsTest.java subtest again > [JDK-8305502](https

Re: RFR: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again

2023-04-21 Thread Daniel D . Daugherty
On Fri, 21 Apr 2023 22:16:32 GMT, Naoto Sato wrote: >> Trivial fixes to increase timeouts for tests that timeout under heavy stress: >> [JDK-8301377](https://bugs.openjdk.org/browse/JDK-8301377) adjust timeout >> for JLI GetObjectSizeIntrinsicsTest.java subtest again >> [JDK-8305502](https://bug

Re: RFR: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again

2023-04-21 Thread Leonid Mesnik
On Fri, 21 Apr 2023 21:35:07 GMT, Daniel D. Daugherty wrote: > Trivial fixes to increase timeouts for tests that timeout under heavy stress: > [JDK-8301377](https://bugs.openjdk.org/browse/JDK-8301377) adjust timeout for > JLI GetObjectSizeIntrinsicsTest.java subtest again > [JDK-8305502](https

Re: RFR: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again

2023-04-21 Thread Naoto Sato
On Fri, 21 Apr 2023 21:35:07 GMT, Daniel D. Daugherty wrote: > Trivial fixes to increase timeouts for tests that timeout under heavy stress: > [JDK-8301377](https://bugs.openjdk.org/browse/JDK-8301377) adjust timeout for > JLI GetObjectSizeIntrinsicsTest.java subtest again > [JDK-8305502](https

Re: RFR: 8291555: Implement alternative fast-locking scheme [v60]

2023-04-21 Thread Daniel D . Daugherty
On Mon, 17 Apr 2023 20:00:58 GMT, Roman Kennke wrote: >> Roman Kennke has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 156 commits: >> >> - Merge remote-tracking branch 'upstream/master' into JDK-8291555-v2 >> - A few more LM_ pr

RFR: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again

2023-04-21 Thread Daniel D . Daugherty
Trivial fixes to increase timeouts for tests that timeout under heavy stress: [JDK-8301377](https://bugs.openjdk.org/browse/JDK-8301377) adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again [JDK-8305502](https://bugs.openjdk.org/browse/JDK-8305502) adjust timeouts in three more M

Re: RFR: 8306437: jhsdb cannot resolve image/symbol paths being used for analysis of Windows coredumps

2023-04-21 Thread Chris Plummer
On Wed, 19 Apr 2023 10:39:40 GMT, Alexey Pavlyutkin wrote: > Hi! The patch fixes image/symbol lookup by jhsdb on alanysis Windows > coredump. It uses executableName as a hint prepending image path with > > `;\server` > > and symbol path with > > `srv*https://msdl.microsoft.com/download/symbol

Re: RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v17]

2023-04-21 Thread Roger Riggs
> Define an internal jdk.internal.util.Architecture enumeration and static > methods to replace uses of the system property `os.arch`. > The enumeration values are defined to match those used in the build. > The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64` > Note that `amd64` and

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Chris Plummer
On Fri, 21 Apr 2023 18:41:41 GMT, Serguei Spitsyn wrote: >> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java >> line 89: >> >>> 87: log("\nMain #A: method A() must be blocked on entering a >>> synchronized statement"); >>> 88: synchronized (Tes

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Serguei Spitsyn
On Fri, 21 Apr 2023 16:34:34 GMT, Chris Plummer wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> corrections for BoundVirtualThread and test typos > > test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTes

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Serguei Spitsyn
On Fri, 21 Apr 2023 16:33:06 GMT, Chris Plummer wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> corrections for BoundVirtualThread and test typos > > test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTes

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v2]

2023-04-21 Thread Alan Bateman
On Fri, 21 Apr 2023 06:06:16 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiEnv.cpp line 1197: >> >>> 1195: if (is_virtual && !is_JavaThread_current(java_thread, thread_oop)) { >>> 1196: if (!JvmtiVTSuspender::is_vthread_suspended(thread_oop)) { >>> 1197: return JVMTI_ER

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Chris Plummer
On Fri, 21 Apr 2023 08:09:55 GMT, Serguei Spitsyn wrote: >> This enhancement adds support of virtual threads to the JVMTI `StopThread` >> function. >> In preview releases before this enhancement the StopThread returned the >> JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads. >>

Re: RFR: 8298048: Combine CDS archive heap into a single block

2023-04-21 Thread Ioi Lam
On Tue, 11 Apr 2023 21:47:40 GMT, Ashutosh Mehra wrote: >> This PR combines the "open" and "closed" regions of the CDS archive heap >> into a single region. This significantly simplifies the implementation, >> making it more compatible with non-G1 collectors. There's a net removal of >> ~1100

Integrated: 8298048: Combine CDS archive heap into a single block

2023-04-21 Thread Ioi Lam
On Mon, 3 Apr 2023 03:32:27 GMT, Ioi Lam wrote: > This PR combines the "open" and "closed" regions of the CDS archive heap into > a single region. This significantly simplifies the implementation, making it > more compatible with non-G1 collectors. There's a net removal of ~1100 lines > in src

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v2]

2023-04-21 Thread Alan Bateman
On Fri, 21 Apr 2023 13:09:58 GMT, David Holmes wrote: >> The JVMTI `StopThread` spec has this description: >>> The StopThread function may be used to send an asynchronous >>> exception to a virtual thread when it is suspended at an event. >>> An implementation may support sending an asynchronous

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v2]

2023-04-21 Thread David Holmes
On Fri, 21 Apr 2023 07:58:45 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiEnv.cpp line 1200: >> >>> 1198: } >>> 1199: if (java_thread == nullptr) { // unmounted virtual thread >>> 1200: return JVMTI_ERROR_OPAQUE_FRAME; >> >> Where is the check for "suspended at an e

Re: RFR: 8305590: Remove nothrow exception specifications from operator new [v3]

2023-04-21 Thread Afshin Zafari
On Thu, 20 Apr 2023 08:41:58 GMT, Afshin Zafari wrote: >> - The `throw()` (i.e., no throw) specifications are removed from the >> instances of `operator new` where _do not_ return `nullptr`. >> >> - The `-fcheck-new` is removed from the gcc compile flags. >> >> - The `operator new` and `operat

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v3]

2023-04-21 Thread Serguei Spitsyn
> This enhancement adds support of virtual threads to the JVMTI `StopThread` > function. > In preview releases before this enhancement the StopThread returned the > JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads. > > The `StopThread` supports sending an asynchronous exception t

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v2]

2023-04-21 Thread Serguei Spitsyn
On Fri, 21 Apr 2023 06:26:33 GMT, David Holmes wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> addressed review comments on new test > > src/hotspot/share/prims/jvmtiEnv.cpp line 1200: > >> 1198: } >> 1199:

Re: RFR: 8306034: add support of virtual threads to JVMTI StopThread [v2]

2023-04-21 Thread Serguei Spitsyn
On Fri, 21 Apr 2023 06:31:52 GMT, David Holmes wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> addressed review comments on new test > > test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThreadT