On Fri, 21 Apr 2023 02:33:37 GMT, SUN Guoyun wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> s390x NULL to nullptr
>
> src/hotspot/cpu/riscv/templateTable_riscv.cpp line 2233:
>
>> 2231:
>> 2232: __ lo
On Thu, 20 Apr 2023 16:40:48 GMT, Serguei Spitsyn wrote:
>> This enhancement adds support of virtual threads to the JVMTI `StopThread`
>> function.
>> In preview releases before this enhancement the StopThread returned the
>> JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads.
>>
On Thu, 20 Apr 2023 18:17:19 GMT, Alan Bateman wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressed review comments on new test
>
> src/hotspot/share/prims/jvmtiEnv.cpp line 1197:
>
>> 1195: if (is_virtu
On Thu, 20 Apr 2023 16:09:29 GMT, Leonid Mesnik wrote:
> ProcessTools.startProcess() creates process and read it's output error
> streams. So the any other using of corresponding Process.getInputStream() and
> Process.getErrorStream() doesn't get process streams.
>
> This fix preserve process
On Tue, 28 Mar 2023 19:50:36 GMT, Matias Saavedra Silva
wrote:
>> The current structure used to store the resolution information for
>> invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its
>> ambigious fields f1 and f2. This structure can hold information for fields,
>>
On Thu, 20 Apr 2023 22:54:49 GMT, David Holmes wrote:
>> test/lib/jdk/test/lib/process/ProcessTools.java line 750:
>>
>>> 748: public InputStream getInputStream() {
>>> 749: try {
>>> 750: waitFor();
>>
>> With this added `waitFor()` the assumption now is tha
On Thu, 20 Apr 2023 22:22:06 GMT, Chris Plummer wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JStackStressTest.java updated.
>
> test/jdk/sun/tools/jhsdb/JStackStressTest.java line 86:
>
>> 84: } ca
On Thu, 20 Apr 2023 22:31:55 GMT, Chris Plummer wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JStackStressTest.java updated.
>
> test/lib/jdk/test/lib/process/ProcessTools.java line 750:
>
>> 748: publi
> This PR combines the "open" and "closed" regions of the CDS archive heap into
> a single region. This significantly simplifies the implementation, making it
> more compatible with non-G1 collectors. There's a net removal of ~1000 lines
> in src code and another ~1200 lines of tests.
>
> **Not
On Thu, 20 Apr 2023 18:40:52 GMT, Leonid Mesnik wrote:
>> ProcessTools.startProcess() creates process and read it's output error
>> streams. So the any other using of corresponding Process.getInputStream()
>> and Process.getErrorStream() doesn't get process streams.
>>
>> This fix preserve pro
On Wed, 19 Apr 2023 22:46:55 GMT, Coleen Phillimore wrote:
> Moved three read-only InstanceKlass flags out of AccessFlags to
> InstanceKlassFlags, and removed unused and unneeded SA code.
> Tested with tier1-4.
This pull request has now been integrated.
Changeset: f6336231
Author:Coleen Ph
On Thu, 20 Apr 2023 00:27:20 GMT, Coleen Phillimore wrote:
>> Moved three read-only InstanceKlass flags out of AccessFlags to
>> InstanceKlassFlags, and removed unused and unneeded SA code.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one
> addit
On Thu, 20 Apr 2023 00:35:06 GMT, Coleen Phillimore wrote:
> Please review this small change to remove Method AccessFlags that are unused.
> These flags were moved to ConstMethod a long time ago.
> Tested with tier1-4, SA tests locally
This pull request has now been integrated.
Changeset: afd
On Thu, 20 Apr 2023 00:35:06 GMT, Coleen Phillimore wrote:
> Please review this small change to remove Method AccessFlags that are unused.
> These flags were moved to ConstMethod a long time ago.
> Tested with tier1-4, SA tests locally
Thanks David and Matias.
-
PR Comment: https
On Thu, 20 Apr 2023 00:35:06 GMT, Coleen Phillimore wrote:
> Please review this small change to remove Method AccessFlags that are unused.
> These flags were moved to ConstMethod a long time ago.
> Tested with tier1-4, SA tests locally
Nice cleanup, LGTM!
-
Marked as reviewed by
> ProcessTools.startProcess() creates process and read it's output error
> streams. So the any other using of corresponding Process.getInputStream() and
> Process.getErrorStream() doesn't get process streams.
>
> This fix preserve process streams content and allow to read it after process
> com
On Thu, 20 Apr 2023 08:36:53 GMT, Afshin Zafari wrote:
>> JVMTI does not abort on OOM it reports an error, so we definitely do not
>> want a terminating allocator!
>>
>> jvmtiError
>> JvmtiEnv::CreateRawMonitor(const char* name, jrawMonitorID* monitor_ptr) {
>> JvmtiRawMonitor* rmonitor = new
On Thu, 20 Apr 2023 08:41:58 GMT, Afshin Zafari wrote:
>> - The `throw()` (i.e., no throw) specifications are removed from the
>> instances of `operator new` where _do not_ return `nullptr`.
>>
>> - The `-fcheck-new` is removed from the gcc compile flags.
>>
>> - The `operator new` and `operat
On Thu, 20 Apr 2023 16:40:48 GMT, Serguei Spitsyn wrote:
>> This enhancement adds support of virtual threads to the JVMTI `StopThread`
>> function.
>> In preview releases before this enhancement the StopThread returned the
>> JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads.
>>
On Thu, 20 Apr 2023 02:46:58 GMT, Leonid Mesnik wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressed review comments on new test
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThread
> This enhancement adds support of virtual threads to the JVMTI `StopThread`
> function.
> In preview releases before this enhancement the StopThread returned the
> JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads.
>
> The `StopThread` supports sending an asynchronous exception t
ProcessTools.startProcess() creates process and read it's output error streams.
So the any other using of corresponding Process.getInputStream() and
Process.getErrorStream() doesn't get process streams.
This fix preserve process streams content and allow to read it after process
completion. The
On Thu, 20 Apr 2023 01:27:37 GMT, Leonid Mesnik wrote:
>> This enhancement adds support of virtual threads to the JVMTI `StopThread`
>> function.
>> In preview releases before this enhancement the StopThread returned the
>> JVMTI_ERROR_UNSUPPORTED_OPERATION error code for virtual threads.
>>
>
On Thu, 20 Apr 2023 01:46:46 GMT, David Holmes wrote:
> Why was has_finalizer not included with this group?
There are 4 flags that aren't included because these flags are referenced from
assembly or compiler code. I'm going to write more about this in a comment in
the bug as I'm trying to dec
On Thu, 20 Apr 2023 10:10:57 GMT, Zixian Cai wrote:
> This follows the same style of fix applied in #13512. I noticed this issue
> when cross-compiling zero slowdebug for riscv64. I confirmed locally that
> this PR fixes the linking errors.
This pull request has now been integrated.
Changeset
On Thu, 20 Apr 2023 12:20:05 GMT, David Holmes wrote:
> I think the better fix is that `os::find_builtin_agent` should be guarded by
> `#if INCLUDE_JVMTI`. Or even moved to a JVMTI file instead.
Right. This is also the pattern used to exclude C1/C2 specific stuff from a
zero build. Perhaps we
On Thu, 20 Apr 2023 10:10:57 GMT, Zixian Cai wrote:
> This follows the same style of fix applied in #13512. I noticed this issue
> when cross-compiling zero slowdebug for riscv64. I confirmed locally that
> this PR fixes the linking errors.
Agreed. As discussed #13512, relevant code should be
On Thu, 20 Apr 2023 10:10:57 GMT, Zixian Cai wrote:
> This follows the same style of fix applied in #13512. I noticed this issue
> when cross-compiling zero slowdebug for riscv64. I confirmed locally that
> this PR fixes the linking errors.
I'll approve this to get a quick fix in place but:
1
On Thu, 20 Apr 2023 10:10:57 GMT, Zixian Cai wrote:
> This follows the same style of fix applied in #13512. I noticed this issue
> when cross-compiling zero slowdebug for riscv64. I confirmed locally that
> this PR fixes the linking errors.
Looks fine and trivial.
-
Marked as rev
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
JDK-8306538: Zero variant build failure after JDK-8257967
-
Commit messages:
- Define JvmtiAgent::set_os_lib when JVMTI feature is not available
Changes: https://git.openjdk.org/jdk/pull/13557/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13557&range=00
Issue: https://bu
On Thu, 20 Apr 2023 08:41:58 GMT, Afshin Zafari wrote:
>> - The `throw()` (i.e., no throw) specifications are removed from the
>> instances of `operator new` where _do not_ return `nullptr`.
>>
>> - The `-fcheck-new` is removed from the gcc compile flags.
>>
>> - The `operator new` and `operat
On Thu, 20 Apr 2023 06:58:20 GMT, David Holmes wrote:
>> A possible reason for keeping this `operator new` is to force the use of
>> null return for oom for this class.
>> If it's removed then we have the option of (perhaps unintentionally) using
>> the terminating allocator.
>> That doesn't se
On Tue, 18 Apr 2023 18:25:55 GMT, Kim Barrett wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8305590: Remove nothrow exception specifications from operator new
>
> src/hotspot/share/jfr/utilities/jfrAllocation.hp
On Wed, 19 Apr 2023 11:49:49 GMT, David Holmes wrote:
>> Afshin Zafari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8305590: Remove nothrow exception specifications from operator new
>
> src/hotspot/share/jfr/utilities/jfrAllocation.h
> - The `throw()` (i.e., no throw) specifications are removed from the
> instances of `operator new` where _do not_ return `nullptr`.
>
> - The `-fcheck-new` is removed from the gcc compile flags.
>
> - The `operator new` and `operator delete` are deleted from `StackObj`.
>
> - The `GrowableArr
On Thu, 6 Apr 2023 14:38:20 GMT, Daniel D. Daugherty wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> RISCV update
>
> src/hotspot/share/services/management.cpp line 1131:
>
>> 1129: if (maxDepth == 0) {
>> 1130:
On Thu, 20 Apr 2023 05:05:17 GMT, Kim Barrett wrote:
>> This `operator new` just calls the `CHeapObj::operator new` with nothrow
>> argument. So changing the caller will call the right one in `CHeapObj`. This
>> object is deleted in
>> https://github.com/openjdk/jdk/blob/c738c8ea3e9fda87abb03
38 matches
Mail list logo
