Re: RFR: 8303702: Provide ThreadFactory to create platform/virtual threads for com/sun/jdi tests [v2]

2023-03-06 Thread Chris Plummer
On Tue, 7 Mar 2023 03:54:56 GMT, Leonid Mesnik wrote: >> Provide a way to start debugee threads as platform or virtual for debugee in >> com/sun/jdi tests. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > more threads are

Re: RFR: 8303617: update for deprecated sprintf for jdk.jdwp.agent [v3]

2023-03-06 Thread Chris Plummer
On Tue, 7 Mar 2023 02:16:56 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because >> of security concerns. The issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-

Re: RFR: 8303702: Provide ThreadFactory to create platform/virtual threads for com/sun/jdi tests [v2]

2023-03-06 Thread Leonid Mesnik
> Provide a way to start debugee threads as platform or virtual for debugee in > com/sun/jdi tests. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: more threads are virtualized. - Changes: - all: https://git.openjdk.

Re: RFR: 8303617: update for deprecated sprintf for jdk.jdwp.agent [v2]

2023-03-06 Thread Xue-Lei Andrew Fan
On Mon, 6 Mar 2023 20:23:13 GMT, Chris Plummer wrote: > windows/native/libjdwp/linker_md.c also needs its copyright updated. Ooops, I missed this file. Updated. Thanks! - PR: https://git.openjdk.org/jdk/pull/12870

Re: RFR: 8303617: update for deprecated sprintf for jdk.jdwp.agent [v3]

2023-03-06 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because > of security concerns. The issue was addressed in > [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building > failure, and > [JDK-8299378](https://bugs.

Re: RFR: 8303702: Provide ThreadFactory to create platform/virtual threads for com/sun/jdi tests

2023-03-06 Thread Chris Plummer
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Mon, 6 Mar 2023 23:47:09 GMT, Leonid Mesnik wrot

Re: RFR: 8303702: Provide ThreadFactory to create platform/virtual threads for com/sun/jdi tests

2023-03-06 Thread Chris Plummer
On Mon, 6 Mar 2023 23:47:09 GMT, Leonid Mesnik wrote: > Provide a way to start debugee threads as platform or virtual for debugee in > com/sun/jdi tests. Changes requested by cjplummer (Reviewer). test/jdk/com/sun/jdi/TestScaffold.java line 1037: > 1035: Object builder = > Thread

RFR: 8303702: Provide ThreadFactory to create platform/virtual threads for com/sun/jdi tests

2023-03-06 Thread Leonid Mesnik
Provide a way to start debugee threads as platform or virtual for debugee in com/sun/jdi tests. - Commit messages: - Added newThread method. Changes: https://git.openjdk.org/jdk/pull/12894/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12894&range=00 Issue: https://bugs.

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Roger Riggs
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on t

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Lance Andersen
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on t

Re: RFR: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector

2023-03-06 Thread Chris Plummer
On Thu, 2 Mar 2023 20:16:35 GMT, Andrey Turbanov wrote: > `LinkedList` is used as value in > `com.sun.jmx.mbeanserver.Introspector.SimpleIntrospector#cache` > It's created, filled (with `add`) and then iterated. No removes from the head > or something like this. `ArrayList` should be preferred

Re: RFR: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector

2023-03-06 Thread Kevin Walls
On Thu, 2 Mar 2023 20:16:35 GMT, Andrey Turbanov wrote: > `LinkedList` is used as value in > `com.sun.jmx.mbeanserver.Introspector.SimpleIntrospector#cache` > It's created, filled (with `add`) and then iterated. No removes from the head > or something like this. `ArrayList` should be preferred

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Jonathan Gibbons
On Mon, 6 Mar 2023 20:22:48 GMT, Pavel Rappo wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on t

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Jonathan Gibbons
On Fri, 3 Mar 2023 11:31:04 GMT, Alexey Ivanov wrote: >> Yes, iff means if-and-only-if and is used for extra precision in formal >> logic, mathematics. As @pavelrappo points out it's a relatively common >> occurrence in the OpenJDK sources, though perhaps not in the public >> javadocs. Perhaps

Re: RFR: 8303617: update for deprecated sprintf for jdk.jdwp.agent [v2]

2023-03-06 Thread Chris Plummer
On Mon, 6 Mar 2023 20:08:31 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because >> of security concerns. The issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments [v2]

2023-03-06 Thread Pavel Rappo
> Please review this superficial documentation cleanup that was triggered by > unrelated analysis of doc comments in JDK API. > > The only effect that this multi-area PR has on the JDK API Documentation > (i.e. the observable effect on the generated HTML pages) can be summarized as > follows: >

RFR: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector

2023-03-06 Thread Andrey Turbanov
`LinkedList` is used as value in `com.sun.jmx.mbeanserver.Introspector.SimpleIntrospector#cache` It's created, filled (with `add`) and then iterated. No removes from the head or something like this. `ArrayList` should be preferred as more efficient and widely used collection. Also I've done some

Re: RFR: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector

2023-03-06 Thread Sergey Tsypanov
On Thu, 2 Mar 2023 20:16:35 GMT, Andrey Turbanov wrote: > `LinkedList` is used as value in > `com.sun.jmx.mbeanserver.Introspector.SimpleIntrospector#cache` > It's created, filled (with `add`) and then iterated. No removes from the head > or something like this. `ArrayList` should be preferred

Re: RFR: 8303617: update for deprecated sprintf for jdk.jdwp.agent [v2]

2023-03-06 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because > of security concerns. The issue was addressed in > [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building > failure, and > [JDK-8299378](https://bugs.

Re: RFR: 8303617: update for deprecated sprintf for jdk.jdwp.agent

2023-03-06 Thread Chris Plummer
On Sat, 4 Mar 2023 06:29:20 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because > of security concerns. The issue was addressed in > [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812

RFR: 8292818: replace 96-bit representation for field metadata with variable-sized streams

2023-03-06 Thread Frederic Parain
Please review this change re-implementing the FieldInfo data structure. The FieldInfo array is an old data structure storing fields metadata. It has poor extension capabilities, a complex management code because of lack of stong typing and semantic overloading, and a poor memory efficiency. The

RFR: 8303617: update for deprecated sprintf for jdk.jdwp.agent

2023-03-06 Thread Xue-Lei Andrew Fan
Hi, May I have this update reviewed? The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of security concerns. The issue was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building failure, and [JDK-8299378](https://bugs.openjdk.org/browse

Re: RFR: 8303534: Merge CompactibleSpace into ContiguousSpace [v2]

2023-03-06 Thread Thomas Schatzl
On Fri, 3 Mar 2023 12:30:38 GMT, Albert Mingkun Yang wrote: >> Simple refactoring of merging two types. >> >> Test: tier1-5 > > Albert Mingkun Yang has updated the pull request incrementally with one > additional commit since the last revision: > > copyright-year Marked as reviewed by tscha