On Tue, 24 Jan 2023 00:16:10 GMT, Alex Menkov wrote:
> classFileParser drops stack map frames for JDK classes (when verification is
> not required).
> As a result JvmtiClassFileReconstituter cannot restore the attribute for
> class redefinition.
> Note that if the class is in CDS archive, the f
On Thu, 19 Jan 2023 18:54:08 GMT, Xue-Lei Andrew Fan wrote:
>> The sprintf is deprecated in Xcode 14 because of security concerns. The
>> issue was addressed in
>> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for hotspot impl,
>> and [JDK-8299378](https://bugs.openjdk.org/browse/
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 00:16:10 GMT, Alex Menkov wrote:
> classFileParser drops stack map frames for JDK classes (when verification is
> not required).
> As a result JvmtiClassFileReconstituter cannot restore the attribute for
> class redefinition.
> Note that if the class is in CDS archive, the f
On Tue, 24 Jan 2023 06:19:51 GMT, David Holmes wrote:
>> classFileParser drops stack map frames for JDK classes (when verification is
>> not required).
>> As a result JvmtiClassFileReconstituter cannot restore the attribute for
>> class redefinition.
>> Note that if the class is in CDS archive,
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 23:16:02 GMT, Alexey Semenyuk wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change localization codes. Add CNY back
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInst
On Tue, 24 Jan 2023 22:55:43 GMT, Alexey Semenyuk wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change German help of jar command
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerS
On Tue, 24 Jan 2023 23:02:58 GMT, Justin Lu wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change localization codes. Add CNY back
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_ja.properties
>
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Revert culture attribute
-
Changes:
- all
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Remove trailing whitespace
-
Changes:
- a
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 22:40:55 GMT, Justin Lu wrote:
>> OK, I can make the manual edit for this
>
> This change was made because it was compared to the original
> messages.properties. In that file, the respective line is given as
> `MANAGE_HOTSPOT_MBEANS_IN_COLON_=Manage Hotspot MBeans in:` with
On Tue, 24 Jan 2023 22:49:20 GMT, Naoto Sato wrote:
>> This change was made because it was compared to the original
>> messages.properties. In that file, the respective line is given as
>> `MANAGE_HOTSPOT_MBEANS_IN_COLON_=Manage Hotspot MBeans in:` with no trailing
>> space. That's why in this
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 22:20:22 GMT, Damon Nguyen wrote:
>> src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties
>> line 174:
>>
>>> 172:
>>> MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON=\u53D6\u6D88\u8BA2\u9605(&U)
>>> 173:
>>> MBEANS_TAB_UNSUBSCRIBE_NOTIFICATION
On Tue, 24 Jan 2023 22:12:26 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 22:14:36 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change localization codes. Add CNY back
>
> src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_zh_CN.p
On Tue, 24 Jan 2023 22:12:02 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change German help of jar command
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.pr
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Change localization codes. Add CNY back
-
C
On Tue, 24 Jan 2023 22:05:55 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change German help of jar command
>
> src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properti
On Tue, 24 Jan 2023 22:12:26 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Change German help of jar command
-
Changes
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote:
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
jdk.console and jdk.management.agent changes look good.
-
Marked as reviewed by cjplummer (Reviewer
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote:
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
@magicus @LanceAndersen @jonathan-gibbons @pavelrappo @dougxc @lahodaj
Could you review the changes from this loc
On Tue, 24 Jan 2023 21:10:31 GMT, Johan Sjölen wrote:
>> Do the conversion in the share/jfr/ sub-directory and all of its files.
>
> Johan Sjölen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix outdated copyright
Status: Clang fails bu
On Tue, 24 Jan 2023 20:58:27 GMT, Johan Sjölen wrote:
>> Do the conversion in the share/jfr/ sub-directory and all of its files.
>
> Johan Sjölen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Manual fix
Found one file which now has no ch
> Do the conversion in the share/jfr/ sub-directory and all of its files.
Johan Sjölen has updated the pull request incrementally with one additional
commit since the last revision:
Fix outdated copyright
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12034/files
- new: h
On Tue, 24 Jan 2023 20:50:00 GMT, Damon Nguyen wrote:
> Open l10n drop. Files have been updated with translated versions. Whitespace
> tool has been ran on files.
> All tests passed
@prrace @wangweij @naotoj @JoeWang-Java @plummercj @alexeysemenyukoracle
Could you review the changes from this l
> Do the conversion in the share/jfr/ sub-directory and all of its files.
Johan Sjölen has updated the pull request incrementally with one additional
commit since the last revision:
Manual fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12034/files
- new: https://git.o
Open l10n drop. Files have been updated with translated versions. Whitespace
tool has been ran on files.
All tests passed
-
Commit messages:
- Remove currency symbol entries
- Remove whitespace using tool
- Remove double quotes generated by translation tool
- Revert translation's
> Do the conversion in the share/jfr/ sub-directory and all of its files.
Johan Sjölen has updated the pull request incrementally with one additional
commit since the last revision:
Fix two faulty NULL_STRING misses
-
Changes:
- all: https://git.openjdk.org/jdk/pull/12034/files
On Tue, 17 Jan 2023 11:26:12 GMT, Johan Sjölen wrote:
> Do the conversion in the share/jfr/ sub-directory and all of its files.
Hi @mgronlun, the "fix" comments are there because I intend to revert the
macros to regular old `NULL`. I'll copy paste a more informative comment next
time :).
Also
On Fri, 20 Jan 2023 18:20:10 GMT, Xue-Lei Andrew Fan wrote:
>> Nothing further from me. I think this is okay as-is now. Thanks.
>
>> Nothing further from me. I think this is okay as-is now. Thanks.
>
> @dholmes-ora Thank you for the review!
> @XueleiFan You need two reviews before integrating a
On Tue, 24 Jan 2023 14:34:35 GMT, Severin Gehwolf wrote:
>> Please review this refactoring of a container test. It now uses WhiteBox to
>> retrieve the host values it asserts for. In terms of functionality this is
>> basically a no-op except for the now more precise assertion on systems with
>
On Tue, 24 Jan 2023 08:48:13 GMT, Matthias Baesken wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains one additional
>> c
> Please review this refactoring of a container test. It now uses WhiteBox to
> retrieve the host values it asserts for. In terms of functionality this is
> basically a no-op except for the now more precise assertion on systems with
> swap accounting disabled at the kernel level.
>
> *Testing*
> Please review this refactoring of a container test. It now uses WhiteBox to
> retrieve the host values it asserts for. In terms of functionality this is
> basically a no-op except for the now more precise assertion on systems with
> swap accounting disabled at the kernel level.
>
> *Testing*
On Thu, 19 Jan 2023 17:24:57 GMT, Severin Gehwolf wrote:
>> Please review this refactoring of a container test. It now uses WhiteBox to
>> retrieve the host values it asserts for. In terms of functionality this is
>> basically a no-op except for the now more precise assertion on systems with
>
41 matches
Mail list logo
