Re: RFR: JDK-8300357: Use generalized see and link tags in java.management

2023-01-17 Thread Alan Bateman
On Wed, 18 Jan 2023 00:37:05 GMT, Joe Darcy wrote: > Use new javadoc capabilities courtesy JDK-8200337 to have > more-readable-in-javadoc-source links to anchors in several management types. > Analogous change is out for review in core libs, JDK-8300133. src/java.management/share/classes/java/

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Martin Doerr
On Tue, 17 Jan 2023 17:02:04 GMT, Fredrik Bredberg wrote: >> src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp line 1035: >> >>> 1033: __ sub(R12_scratch2, R18_locals, R1_SP); >>> 1034: __ srdi(R12_scratch2, R12_scratch2, >>> Interpreter::logStackElementSize); >>> 1035: // Now &fp(

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v12]

2023-01-17 Thread David Holmes
On Tue, 17 Jan 2023 13:23:51 GMT, Afshin Zafari wrote: >> test of tier1-5 passed. > > Afshin Zafari has updated the pull request incrementally with one additional > commit since the last revision: > > 8292741: Convert JvmtiTagMapTable to ResourceHashtable Marked as reviewed by dholmes (Revie

RFR: JDK-8300357: Use generalized see and link tags in java.management

2023-01-17 Thread Joe Darcy
Use new javadoc capabilities courtesy JDK-8200337 to have more-readable-in-javadoc-source links to anchors in several management types. Analogous change is out for review in core libs, JDK-8300133. - Commit messages: - JDK-8300357: Use generalized see and link tags in java.manageme

Re: RFR: 8299635: Hotspot update for deprecated sprintf in Xcode 14 [v5]

2023-01-17 Thread Chris Plummer
On Tue, 17 Jan 2023 01:28:08 GMT, David Holmes wrote: >> Xue-Lei Andrew Fan has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains six >> additional co

Re: RFR: 8291555: Implement alternative fast-locking scheme

2023-01-17 Thread David Holmes
On Fri, 28 Oct 2022 20:17:37 GMT, Roman Kennke wrote: > This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mar

Re: RFR: 8291555: Implement alternative fast-locking scheme

2023-01-17 Thread Robbin Ehn
On Fri, 28 Oct 2022 20:17:37 GMT, Roman Kennke wrote: > This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mar

Re: RFR: 8291555: Implement alternative fast-locking scheme

2023-01-17 Thread Roman Kennke
On Fri, 28 Oct 2022 20:17:37 GMT, Roman Kennke wrote: > This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mar

Re: RFR: 8291555: Implement alternative fast-locking scheme

2023-01-17 Thread Fei Yang
On Fri, 28 Oct 2022 20:17:37 GMT, Roman Kennke wrote: > This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mar

RFR: 8291555: Implement alternative fast-locking scheme

2023-01-17 Thread Roman Kennke
This change adds a fast-locking scheme as an alternative to the current stack-locking implementation. It retains the advantages of stack-locking (namely fast locking in uncontended code-paths), while avoiding the overload of the mark word. That overloading causes massive problems with Lilliput,

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Andrew Haley
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote: >> Implementation of relativized locals in interpreter frames for x86. x64, >> arm, aarch64, ppc64le and riscv. >> Not relativized locals on zero and s390 but done some changes to cope with >> the changed generic code. >> Tested tier1-ti

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Fredrik Bredberg
On Tue, 17 Jan 2023 13:32:47 GMT, Martin Doerr wrote: >> Fredrik Bredberg has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> com

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Martin Doerr
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote: >> Implementation of relativized locals in interpreter frames for x86. x64, >> arm, aarch64, ppc64le and riscv. >> Not relativized locals on zero and s390 but done some changes to cope with >> the changed generic code. >> Tested tier1-ti

Re: RFR: 8299795: Relativize locals in interpreter frames

2023-01-17 Thread Martin Doerr
On Tue, 17 Jan 2023 08:40:18 GMT, Fredrik Bredberg wrote: > > Works on PPC64. Thanks! Tests have passed on other platforms as well. > > Does "other platforms" include S390? No, @backwaterred you may want to check. - PR: https://git.openjdk.org/jdk/pull/11902

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v12]

2023-01-17 Thread Afshin Zafari
> test of tier1-5 passed. Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision: 8292741: Convert JvmtiTagMapTable to ResourceHashtable - Changes: - all: https://git.openjdk.org/jdk/pull/11288/files - new: https://git.open

Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-01-17 Thread Magnus Ihse Bursie
On Tue, 17 Jan 2023 11:44:32 GMT, Vladimir Sitnikov wrote: >> @RogerRiggs Thanks! > > @magicus , have you considered adding `.editorconfig` file (see > https://editorconfig.org/ ) so it configures developers' editors to trim the > whitespace? > > Of course, `.editorconfig` does not enforce th

Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-01-17 Thread Vladimir Sitnikov
On Mon, 16 Jan 2023 18:52:24 GMT, Magnus Ihse Bursie wrote: >> The non-client parts look fine. > > @RogerRiggs Thanks! @magicus , have you considered adding `.editorconfig` file (see https://editorconfig.org/ ) so it configures developers' editors to trim the whitespace? Of course, `.editorco

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v11]

2023-01-17 Thread Afshin Zafari
> test of tier1-5 passed. Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision: 8292741: Convert JvmtiTagMapTable to ResourceHashtable - Changes: - all: https://git.openjdk.org/jdk/pull/11288/files - new: https://git.open

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Robbin Ehn
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote: >> Implementation of relativized locals in interpreter frames for x86. x64, >> arm, aarch64, ppc64le and riscv. >> Not relativized locals on zero and s390 but done some changes to cope with >> the changed generic code. >> Tested tier1-ti

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Fredrik Bredberg
On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg wrote: >> Implementation of relativized locals in interpreter frames for x86. x64, >> arm, aarch64, ppc64le and riscv. >> Not relativized locals on zero and s390 but done some changes to cope with >> the changed generic code. >> Tested tier1-ti

Re: RFR: 8299795: Relativize locals in interpreter frames

2023-01-17 Thread Fredrik Bredberg
On Tue, 10 Jan 2023 15:14:34 GMT, Martin Doerr wrote: > Works on PPC64. Thanks! Tests have passed on other platforms as well. Does "other platforms" include S390? - PR: https://git.openjdk.org/jdk/pull/11902

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-17 Thread Fredrik Bredberg
> Implementation of relativized locals in interpreter frames for x86. x64, arm, > aarch64, ppc64le and riscv. > Not relativized locals on zero and s390 but done some changes to cope with > the changed generic code. > Tested tier1-tier8 on supported platforms. The rest was sanity tested using > Q