On Wed, 4 Jan 2023 12:56:18 GMT, Daniel Jeliński wrote:
> Please review this patch that removes the remaining uses of non-reentrant
> `getprotobyname` function.
>
> While the protocol number for TCP could theoretically be modified to
> something other than the default `IPPROTO_TCP`, that scena
On Fri, 6 Jan 2023 06:38:46 GMT, Yi Yang wrote:
>> As long as all the platform-specific `VirtualMachineImpl` classes define a
>> `read` and `close` method then we can simply have the shared socket stream
>> class call those methods. Windows will need an extra level of indirection
>> because it
On Sat, 7 Jan 2023 21:08:07 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gener
On Thu, 5 Jan 2023 04:28:46 GMT, David Holmes wrote:
> I was thinking more about describing what the parameters are - in particular
> it is unclear why the actual IOE can be replaced by a passed in one. If we
> wanted a custom message then I would at least expect to chain the actual IOE
> to t
> harmless refactor to share code across different platforms of
> VirtualMachineImpl:
> 1. Shared code to process command response after requesting a command
> execution
> 2. Read functionality in SocketInputStream can be reused
Yi Yang has updated the pull request incrementally with two additio
On Fri, 6 Jan 2023 22:01:45 GMT, Chris Plummer wrote:
> I would also like to request that the variable renames be omitted from this
> PR. They create too much noise and would best left to a PR that focuses on
> just the renames and possibly other style changes.
Okay, reverted.
-
