Re: RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v39]

2022-12-13 Thread Michael Ennen
On Mon, 5 Dec 2022 13:46:09 GMT, Maurizio Cimadamore wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix Preview annotation for JEP 434 > > Note: there are 4 tests failing in x86: > * MemoryLayoutPrincipalT

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS [v2]

2022-12-13 Thread David Holmes
On Tue, 13 Dec 2022 22:00:04 GMT, Coleen Phillimore wrote: >> These access flags were implemented to enable passing access flag values >> from Method* to InstanceKlass*, but only covered one flag. Towards only >> have access flags represent read-only flags in the class file, remove this >> an

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS [v2]

2022-12-13 Thread Coleen Phillimore
On Tue, 13 Dec 2022 20:42:04 GMT, Daniel D. Daugherty wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add a space > > src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 4376: > >> 4374: if (scratch_clas

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS

2022-12-13 Thread Coleen Phillimore
On Tue, 13 Dec 2022 18:28:22 GMT, Coleen Phillimore wrote: > These access flags were implemented to enable passing access flag values from > Method* to InstanceKlass*, but only covered one flag. Towards only have > access flags represent read-only flags in the class file, remove this and > pa

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS [v2]

2022-12-13 Thread Coleen Phillimore
> These access flags were implemented to enable passing access flag values from > Method* to InstanceKlass*, but only covered one flag. Towards only have > access flags represent read-only flags in the class file, remove this and > pass has_localvariable_table up to InstanceKlass in classfile p

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS

2022-12-13 Thread Daniel D . Daugherty
On Tue, 13 Dec 2022 18:28:22 GMT, Coleen Phillimore wrote: > These access flags were implemented to enable passing access flag values from > Method* to InstanceKlass*, but only covered one flag. Towards only have > access flags represent read-only flags in the class file, remove this and > pa

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS

2022-12-13 Thread Coleen Phillimore
On Tue, 13 Dec 2022 18:28:22 GMT, Coleen Phillimore wrote: > These access flags were implemented to enable passing access flag values from > Method* to InstanceKlass*, but only covered one flag. Towards only have > access flags represent read-only flags in the class file, remove this and > pa

Re: RFR: 8298692: Fix typos in test/jdk/com/sun/jdi files

2022-12-13 Thread Serguei Spitsyn
On Tue, 13 Dec 2022 19:16:41 GMT, Chris Plummer wrote: > These are the typos from #10029 that relate to test/jdk/com/sun/jdi. Looks good. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.org/jdk/pull/11656

Re: RFR: 8287812: Cleanup JDWP agent GetEnv initialization [v2]

2022-12-13 Thread Serguei Spitsyn
On Fri, 9 Dec 2022 01:16:58 GMT, Chris Plummer wrote: >> 3 things to cleanup in this area: >> >> (1) The JDWP agent uses `JNI GetEnv(JVMTI_VERSION_1)` to get a JVMTI >> environment. If `GetEnv` fails the JDWP agent prints this: >> >> `ERROR: JDWP unable to access JVMTI Version 1 (0x3001),

Re: RFR: 8287812: Cleanup JDWP agent GetEnv initialization [v2]

2022-12-13 Thread Serguei Spitsyn
On Fri, 9 Dec 2022 19:44:34 GMT, Daniel D. Daugherty wrote: > Of course, it is possible that JVMTI_VERSION_9 is compatible with > JVMTI_VERSION_1_N and JVMTI_VERSION_11 is compatible with both > JVMTI_VERSION_9 and JVMTI_VERSION_1_N. We might have simply bumped the major > number because we we

Integrated: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker

2022-12-13 Thread Alex Menkov
On Fri, 9 Dec 2022 23:18:23 GMT, Alex Menkov wrote: > The fix updates the test to ignore ThreadDeathEvent event from non-test > threads waiting for breakpoint This pull request has now been integrated. Changeset: 220781fa Author:Alex Menkov URL: https://git.openjdk.org/jdk/commit/

Integrated: 8298514: vmTestbase/nsk/jdi/EventRequestManager/threadDeathRequests/thrdeathreq002/TestDescription.java fails with usage tracker

2022-12-13 Thread Alex Menkov
On Fri, 9 Dec 2022 23:21:04 GMT, Alex Menkov wrote: > One more test fix to ignore ThreadDeathEvent event from non-test threads > waiting for breakpoint This pull request has now been integrated. Changeset: a120764c Author:Alex Menkov URL: https://git.openjdk.org/jdk/commit/a120764c

Re: RFR: 8298692: Fix typos in test/jdk/com/sun/jdi files

2022-12-13 Thread Alex Menkov
On Tue, 13 Dec 2022 19:16:41 GMT, Chris Plummer wrote: > These are the typos from #10029 that relate to test/jdk/com/sun/jdi. Marked as reviewed by amenkov (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11656

RFR: 8298692: Fix typos in test/jdk/com/sun/jdi files

2022-12-13 Thread Chris Plummer
These are the typos from #10029 that relate to test/jdk/com/sun/jdi. - Commit messages: - Fix some jdi test typos in comments Changes: https://git.openjdk.org/jdk/pull/11656/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11656&range=00 Issue: https://bugs.openjdk.org/brow

Re: RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS

2022-12-13 Thread Serguei Spitsyn
On Tue, 13 Dec 2022 18:28:22 GMT, Coleen Phillimore wrote: > These access flags were implemented to enable passing access flag values from > Method* to InstanceKlass*, but only covered one flag. Towards only have > access flags represent read-only flags in the class file, remove this and > pa

RFR: 8298475: Remove JVM_ACC_PROMOTED_FLAGS

2022-12-13 Thread Coleen Phillimore
These access flags were implemented to enable passing access flag values from Method* to InstanceKlass*, but only covered one flag. Towards only have access flags represent read-only flags in the class file, remove this and pass has_localvariable_table up to InstanceKlass in classfile parsing,