> The can_support_virtual_thread was initially implemented as an onload
> capability.
> It is why this capability does not work for the agents loaded into running VM.
> The fix is to move it from `onload` to `always`capabilities list.
>
> Testing:
> New test is added: VirtualStartThreadTest.
> TB
The can_support_virtual_thread was initially implemented as an onload
capability.
It is why this capability does not work for the agents loaded into running VM.
The fix is to move it from `onload` to `always`capabilities list.
Testing:
New test is added: VirtualStartThreadTest.
TBD: mach5 jvmti,
On Sat, 19 Nov 2022 06:48:24 GMT, Thomas Stuefe wrote:
>> This is a breakout from
>> [JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114), which is starved
>> for reviews. So I attempt to break up that fix into smaller units which are
>> hopefully easier to review separately.
>>
>> We c
> This is a breakout from
> [JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114), which is starved
> for reviews. So I attempt to break up that fix into smaller units which are
> hopefully easier to review separately.
>
> We can trim the C-heap manually using jcmd since
> [JDK-8268893](h
On Fri, 18 Nov 2022 23:35:57 GMT, Serguei Spitsyn wrote:
> A trivial fix to ProblemList two tests:
> runtime/vthread/RedefineClass.java
> runtime/vthread/TestObjectAllocationSampleEvent.java
This pull request has now been integrated.
Changeset: 0ec575a2
Author:Serguei Spitsyn
URL:
On Fri, 18 Nov 2022 23:35:57 GMT, Serguei Spitsyn wrote:
> A trivial fix to ProblemList two tests:
> runtime/vthread/RedefineClass.java
> runtime/vthread/TestObjectAllocationSampleEvent.java
Thank you, Dan!
-
PR: https://git.openjdk.org/jdk/pull/11245
A trivial fix to ProblemList two tests:
runtime/vthread/RedefineClass.java
runtime/vthread/TestObjectAllocationSampleEvent.java
-
Commit messages:
- 8297289: problem list runtime/vthread/RedefineClass.java and
TestObjectAllocationSampleEvent.java
Changes: https://git.openjdk.or
On Fri, 18 Nov 2022 23:35:57 GMT, Serguei Spitsyn wrote:
> A trivial fix to ProblemList two tests:
> runtime/vthread/RedefineClass.java
> runtime/vthread/TestObjectAllocationSampleEvent.java
Thumbs up. This is a trivial fix.
-
Marked as reviewed by dcubed (Reviewer).
PR: https
On Fri, 18 Nov 2022 19:06:02 GMT, Alan Bateman wrote:
>> Right; ideally when the feature becomes non-preview the test update would
>> just be removing the "@enablePreview" line. I didn't author these tests so I
>> initially left any "othervm" directives in place since they aren't
>> incorrect,
On Thu, 17 Nov 2022 09:12:07 GMT, Serguei Spitsyn wrote:
> The `VirtualThread` static field `notifyJvmtiEvents` is not set correctly in
> cases JVMTI agents are loaded into running VM. It is because an extra call to
> java_lang_VirtualThread::init_static_notify_jvmti_events() is needed.
> This
On Fri, 18 Nov 2022 07:23:20 GMT, Serguei Spitsyn wrote:
>> The `VirtualThread` static field `notifyJvmtiEvents` is not set correctly in
>> cases JVMTI agents are loaded into running VM. It is because an extra call
>> to java_lang_VirtualThread::init_static_notify_jvmti_events() is needed.
>> T
On Fri, 18 Nov 2022 07:23:20 GMT, Serguei Spitsyn wrote:
>> The `VirtualThread` static field `notifyJvmtiEvents` is not set correctly in
>> cases JVMTI agents are loaded into running VM. It is because an extra call
>> to java_lang_VirtualThread::init_static_notify_jvmti_events() is needed.
>> T
On Fri, 18 Nov 2022 03:37:03 GMT, Chris Plummer wrote:
> > Gotta wonder how the fix for 8284027 was tested with the test still
> > on the ProblemList. Or did the ProblemList update just get lost?
>
> I'm not sure. Maybe @alexmenkov remembers.
I don't remember, but most likely by running the tes
On Fri, 18 Nov 2022 19:34:19 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ajust condition when init_static_notify_jvmti_events() is called
>
> src/hotspot/share/prims/jvmtiExport.cpp line 3
On Fri, 18 Nov 2022 07:23:20 GMT, Serguei Spitsyn wrote:
>> The `VirtualThread` static field `notifyJvmtiEvents` is not set correctly in
>> cases JVMTI agents are loaded into running VM. It is because an extra call
>> to java_lang_VirtualThread::init_static_notify_jvmti_events() is needed.
>> T
On Fri, 18 Nov 2022 01:16:13 GMT, Leonid Mesnik wrote:
> Test serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java
> timed out with -Xcomp. It starts 2000 threads at the same time. However,
> there is no goal to start them simultaneously. It is needed just to start a
> lot o
On Thu, 17 Nov 2022 20:49:53 GMT, Chris Plummer wrote:
> Remove vmTestbase/nsk/jvmti/GetAllThreads/allthr001 from vthread problem
> list. [JDK-8284027](https://bugs.openjdk.org/browse/JDK-8284027) has been
> fixed.
>
> Ran test on all supported platforms with:
>
> `JTREG_EXTRA_PROBLEM_LISTS=P
On Thu, 17 Nov 2022 18:53:58 GMT, Chris Plummer wrote:
> The bug is closed (was specific to sparc) and the test no longer exists
> (Nashorn has been removed).
>
> I'd like to push this as a trivial change.
This pull request has now been integrated.
Changeset: 9b4e0e84
Author:Chris Plumme
On Fri, 18 Nov 2022 18:38:46 GMT, Joe Darcy wrote:
>> test/jdk/java/lang/Thread/BuilderTest.java line 29:
>>
>>> 27: * @enablePreview
>>> 28: * @compile BuilderTest.java
>>> 29: * @run testng/othervm BuilderTest
>>
>> I assume `@compile` can be dropped from most of these tests now. Also I
>
On Fri, 18 Nov 2022 02:31:19 GMT, David Holmes wrote:
> Hi @jonathan-gibbons ,
>
> I notice that in the new version dash characters are no longer escaped as
> `-`, do these still display correctly?
Yes, at least in all the files I verified and I have no reason to believe it
might be different
On Fri, 18 Nov 2022 08:28:22 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> test/jdk/java/lang/Thread/BuilderTest.java line 29:
>
>> 27: * @enablePreview
>> 28: *
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
--
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote:
>> This patch moves the acquisition of the boot class loader lock out of the
>> JVM and into the Java function.
>> Tested with tier1-4, and jvmti and jdi tests locally.
>
> Coleen Phillimore has updated the pull request incrementally with
On Fri, 18 Nov 2022 01:16:13 GMT, Leonid Mesnik wrote:
> Test serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java
> timed out with -Xcomp. It starts 2000 threads at the same time. However,
> there is no goal to start them simultaneously. It is needed just to start a
> lot o
On Fri, 18 Nov 2022 12:54:34 GMT, Roman Kennke wrote:
> Looks good to me.
Thank you!
> I kinda like the OS interface. If the proliferation of lots of unimplemented
> methods in os/* is a concern, we could provide default impls in shared if
> !**GLIBC** as a middle-ground. WDYT?
I fear this w
On Mon, 14 Nov 2022 07:32:25 GMT, Thomas Stuefe wrote:
>> This is a breakout from
>> [JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114), which is starved
>> for reviews. So I attempt to break up that fix into smaller units which are
>> hopefully easier to review separately.
>>
>> We c
On Thu, 17 Nov 2022 06:28:37 GMT, Poison wrote:
> As the title says, add the volatile modifier.
This pull request has now been integrated.
Changeset: dd18d76b
Author:tianshuang
Committer: Severin Gehwolf
URL:
https://git.openjdk.org/jdk/commit/dd18d76b4c1dfa79707634bcd4df4f8e7cfb8b
On Thu, 17 Nov 2022 09:43:39 GMT, Poison wrote:
>> As the title says, add the volatile modifier.
>
> Poison has updated the pull request incrementally with one additional commit
> since the last revision:
>
> 8297173: usageTicks and totalTicks should be volatile
@tianshuang If you /integrate
On Thu, 17 Nov 2022 21:48:11 GMT, Joe Darcy wrote:
> Similar to an update recently done for langtools tests, update the libraries
> regression tests to take advantage of the @enablePreview jtreg feature.
test/jdk/java/lang/Thread/BuilderTest.java line 29:
> 27: * @enablePreview
> 28: * @comp
30 matches
Mail list logo
