RFR: 8295376: Improve debug agent virtual thread performance when no debugger is attached

2022-10-25 Thread Chris Plummer
This PR disables VIRTUAL_THREAD_START/END events when no debugger is attached. Some customers like to launch (in production mode) the JVM with the debug agent enabled, but with no debugger attached. This usually has a very minimal performance impact as long as the debugger remains unattached. La

Integrated: 8294486: Remove vmTestbase/nsk/jvmti/ tests ported to serviceability/jvmti.

2022-10-25 Thread Leonid Mesnik
On Tue, 11 Oct 2022 19:00:11 GMT, Leonid Mesnik wrote: > The fix removes nsk/jvmti/ tests ported to serviceability/jvmti and > forward-ports corresponding fixed. The suspend/resume tests require more work > covered by https://bugs.openjdk.org/browse/JDK-8295169. This pull request has now been

Integrated: 8295816: jdwp jck tests failing with "FATAL ERROR in native method: JDWP SetTag, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"

2022-10-25 Thread Chris Plummer
On Mon, 24 Oct 2022 05:29:26 GMT, Chris Plummer wrote: > Various debugger tests (mainly JCK vm/jdwp tests) are failing with: > > `FATAL ERROR in native method: JDWP SetTag, > jvmtiError=JVMTI_ERROR_WRONG_PHASE(112) ` > > Sometimes instead of `SetTag` the message says `GetTag` or `signature`.

Re: RFR: 8295816: jdwp jck tests failing with "FATAL ERROR in native method: JDWP SetTag, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"

2022-10-25 Thread Chris Plummer
On Mon, 24 Oct 2022 05:29:26 GMT, Chris Plummer wrote: > Various debugger tests (mainly JCK vm/jdwp tests) are failing with: > > `FATAL ERROR in native method: JDWP SetTag, > jvmtiError=JVMTI_ERROR_WRONG_PHASE(112) ` > > Sometimes instead of `SetTag` the message says `GetTag` or `signature`.

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter [v3]

2022-10-25 Thread Serguei Spitsyn
On Wed, 19 Oct 2022 17:54:02 GMT, Kevin Walls wrote: >> Set the management.properties >> "com.sun.management.jmxremote.serial.filter.pattern" value by default, to >> restrict types that can be deserialized. >> >> Use the example value from the Core Libraries guide (see section 2. >> Serializ

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter [v3]

2022-10-25 Thread Kevin Walls
On Tue, 25 Oct 2022 18:31:29 GMT, Serguei Spitsyn wrote: > How was this set of segments to be filtered by default identified? I started with the set of classes given as an example in the Core Libraries guide, https://docs.oracle.com/en/java/javase/19/core/serialization-filtering1.html in the "

Re: RFR: 8295816: jdwp jck tests failing with "FATAL ERROR in native method: JDWP SetTag, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"

2022-10-25 Thread Daniel D . Daugherty
On Mon, 24 Oct 2022 05:29:26 GMT, Chris Plummer wrote: > Various debugger tests (mainly JCK vm/jdwp tests) are failing with: > > `FATAL ERROR in native method: JDWP SetTag, > jvmtiError=JVMTI_ERROR_WRONG_PHASE(112) ` > > Sometimes instead of `SetTag` the message says `GetTag` or `signature`.

Re: RFR: 8295816: jdwp jck tests failing with "FATAL ERROR in native method: JDWP SetTag, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"

2022-10-25 Thread Alex Menkov
On Mon, 24 Oct 2022 05:29:26 GMT, Chris Plummer wrote: > Various debugger tests (mainly JCK vm/jdwp tests) are failing with: > > `FATAL ERROR in native method: JDWP SetTag, > jvmtiError=JVMTI_ERROR_WRONG_PHASE(112) ` > > Sometimes instead of `SetTag` the message says `GetTag` or `signature`.

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter [v3]

2022-10-25 Thread Serguei Spitsyn
On Wed, 19 Oct 2022 17:54:02 GMT, Kevin Walls wrote: >> Set the management.properties >> "com.sun.management.jmxremote.serial.filter.pattern" value by default, to >> restrict types that can be deserialized. >> >> Use the example value from the Core Libraries guide (see section 2. >> Serializ

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter [v3]

2022-10-25 Thread Kevin Walls
On Wed, 19 Oct 2022 17:54:02 GMT, Kevin Walls wrote: >> Set the management.properties >> "com.sun.management.jmxremote.serial.filter.pattern" value by default, to >> restrict types that can be deserialized. >> >> Use the example value from the Core Libraries guide (see section 2. >> Serializ

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter [v3]

2022-10-25 Thread Serguei Spitsyn
On Wed, 19 Oct 2022 17:54:02 GMT, Kevin Walls wrote: >> Set the management.properties >> "com.sun.management.jmxremote.serial.filter.pattern" value by default, to >> restrict types that can be deserialized. >> >> Use the example value from the Core Libraries guide (see section 2. >> Serializ

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter [v3]

2022-10-25 Thread Serguei Spitsyn
On Wed, 19 Oct 2022 17:54:02 GMT, Kevin Walls wrote: >> Set the management.properties >> "com.sun.management.jmxremote.serial.filter.pattern" value by default, to >> restrict types that can be deserialized. >> >> Use the example value from the Core Libraries guide (see section 2. >> Serializ

Integrated: 8295808: GrowableArray should support capacity management

2022-10-25 Thread Kim Barrett
On Sat, 22 Oct 2022 01:38:44 GMT, Kim Barrett wrote: > Please review this change to GrowableArray to support capacity management. > Two functions are added to GrowableArray, reserve and shrink_to_fit. Also > renamed the max_length function to capacity. > > Used these new functions in StringDedu

Re: RFR: 8295808: GrowableArray should support capacity management [v2]

2022-10-25 Thread Kim Barrett
On Mon, 24 Oct 2022 08:11:42 GMT, Axel Boldt-Christmas wrote: >> Kim Barrett has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >

Re: RFR: 8295808: GrowableArray should support capacity management [v2]

2022-10-25 Thread Kim Barrett
> Please review this change to GrowableArray to support capacity management. > Two functions are added to GrowableArray, reserve and shrink_to_fit. Also > renamed the max_length function to capacity. > > Used these new functions in StringDedupTable. > > Testing: mach5 tier1-3 Kim Barrett has up

Re: RFR: 8295808: GrowableArray should support capacity management

2022-10-25 Thread Kim Barrett
On Mon, 24 Oct 2022 08:11:42 GMT, Axel Boldt-Christmas wrote: > Any thoughts of moving `expand_to` and `shrink_to_fit` to a common function, > given that they share a lot of logic. Something like a general resize that > [...] You are right that there are some opportunities for factoring out c

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-25 Thread Naoto Sato
On Tue, 25 Oct 2022 13:43:56 GMT, Weijun Wang wrote: > I wonder if this means even if we get everything right now the tool might add > trailing spaces again later. Good catch, Max. Yes, that should be dealt with in the translation process. > I suggest we focus on the English files this time an

Integrated: 8295810: cleanup debug agent removeThread() api

2022-10-25 Thread Chris Plummer
On Sat, 22 Oct 2022 03:05:07 GMT, Chris Plummer wrote: > The implementation of removeThread() is currently: > > > static void > removeThread(JNIEnv *env, ThreadList *list, jthread thread) > { > ThreadNode *node; > > node = findThread(list, thread); > if (node != NULL) { > r

Re: RFR: 8295816: jdwp jck tests failing with "FATAL ERROR in native method: JDWP SetTag, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"

2022-10-25 Thread Daniel D . Daugherty
On Mon, 24 Oct 2022 05:29:26 GMT, Chris Plummer wrote: > Various debugger tests (mainly JCK vm/jdwp tests) are failing with: > > `FATAL ERROR in native method: JDWP SetTag, > jvmtiError=JVMTI_ERROR_WRONG_PHASE(112) ` > > Sometimes instead of `SetTag` the message says `GetTag` or `signature`.

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-25 Thread Weijun Wang
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-25 Thread Weijun Wang
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Integrated: 8294993: LingeredApp test update

2022-10-25 Thread Kevin Walls
On Fri, 7 Oct 2022 19:54:54 GMT, Kevin Walls wrote: > There are a few changes we can make to better understand the LingeredApp test > when it goes wrong: > > startAppExactJvmOpts() should not try and call finishApp unless the process > isAlive, that just creates a misleading exception. > > wa

Re: RFR: 8294993: LingeredApp test update [v4]

2022-10-25 Thread Kevin Walls
On Mon, 17 Oct 2022 20:16:49 GMT, Kevin Walls wrote: >> There are a few changes we can make to better understand the LingeredApp >> test when it goes wrong: >> >> startAppExactJvmOpts() should not try and call finishApp unless the process >> isAlive, that just creates a misleading exception. >

Re: RFR: 8295808: GrowableArray should support capacity management

2022-10-25 Thread Serguei Spitsyn
On Sat, 22 Oct 2022 01:38:44 GMT, Kim Barrett wrote: > Please review this change to GrowableArray to support capacity management. > Two functions are added to GrowableArray, reserve and shrink_to_fit. Also > renamed the max_length function to capacity. > > Used these new functions in StringDedu