RFR: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32

2022-10-21 Thread Jie Fu
It fails on x86_32 due to `Unrecognized VM option ObjectAlignmentInBytes=8`. So let's only run the test on 64-bit platforms. Thanks. Best regards, Jie - Commit messages: - 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32 Changes: https://git.openjdk.org/jdk/pull/

RFR: 8295810: cleanup debug agent removeThread() api

2022-10-21 Thread Chris Plummer
The implementation of removeThread() is currently: static void removeThread(JNIEnv *env, ThreadList *list, jthread thread) { ThreadNode *node; node = findThread(list, thread); if (node != NULL) { removeNode(list, node); clearThread(env, node); } } However, curren

RFR: 8295808: GrowableArray should support capacity management

2022-10-21 Thread Kim Barrett
Please review this change to GrowableArray to support capacity management. Two functions are added to GrowableArray, reserve and shrink_to_fit. Also renamed the max_length function to capacity. Used these new functions in StringDedupTable. Testing: mach5 tier1-3 - Commit messages:

Integrated: 8295427: popframe004: report more details on error

2022-10-21 Thread Alex Menkov
On Fri, 21 Oct 2022 01:02:21 GMT, Alex Menkov wrote: > Failures of the test are usually caused by unexpected frame in the stack. > Also the failures are intermittent, so it makes sense to report more details > on error to simplify analysis. > The fix adds stack trace printing if the test fails

RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process

2022-10-21 Thread Bill Huang
The current non local registry tests require a manual process that runs rmiregitrty on a different machine and changes the -Dregistry.host property in the source before running the tests on the local machine. This task is created to improve this manual process and provide a clearer instruction t

Re: RFR: 8294486: Remove vmTestbase/nsk/jvmti/ tests ported to serviceability/jvmti.

2022-10-21 Thread Leonid Mesnik
On Tue, 11 Oct 2022 19:00:11 GMT, Leonid Mesnik wrote: > The fix removes nsk/jvmti/ tests ported to serviceability/jvmti and > forward-ports corresponding fixed. The suspend/resume tests require more work > covered by https://bugs.openjdk.org/browse/JDK-8295169. Thank you, I deleted vmTestba

Re: RFR: 8294486: Remove vmTestbase/nsk/jvmti/ tests ported to serviceability/jvmti. [v2]

2022-10-21 Thread Leonid Mesnik
> The fix removes nsk/jvmti/ tests ported to serviceability/jvmti and > forward-ports corresponding fixed. The suspend/resume tests require more work > covered by https://bugs.openjdk.org/browse/JDK-8295169. Leonid Mesnik has updated the pull request incrementally with one additional commit si

Re: RFR: 8295375: debug agent class tracking should not piggy back on the cbClassPrepare() callback

2022-10-21 Thread Chris Plummer
On Thu, 20 Oct 2022 01:21:19 GMT, Chris Plummer wrote: > The debug agent needs to keep track of all loaded classes, and also be > notified when they are unloaded. It tracks classes loading by getting > CLASS_PREPARE events and it tracks their unloading by tagging them, which > triggers OBJECT_

Integrated: 8295375: debug agent class tracking should not piggy back on the cbClassPrepare() callback

2022-10-21 Thread Chris Plummer
On Thu, 20 Oct 2022 01:21:19 GMT, Chris Plummer wrote: > The debug agent needs to keep track of all loaded classes, and also be > notified when they are unloaded. It tracks classes loading by getting > CLASS_PREPARE events and it tracks their unloading by tagging them, which > triggers OBJECT_

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Andy Goryachev
On Fri, 21 Oct 2022 16:04:14 GMT, Naoto Sato wrote: > replace those dangling white spaces with explicit Unicode escapes this is a *very good* idea. - PR: https://git.openjdk.org/jdk/pull/10792

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Naoto Sato
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Erik Joelsson
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter [v3]

2022-10-21 Thread Daniel Fuchs
On Fri, 21 Oct 2022 09:59:15 GMT, Kevin Walls wrote: >> src/jdk.management.agent/share/conf/management.properties line 306: >> >>> 304: # Otherwise, the status is UNDECIDED. >>> 305: >>> com.sun.management.jmxremote.serial.filter.pattern=java.lang.*;java.math.BigInteger;java.math.BigDecimal;j

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter [v3]

2022-10-21 Thread Kevin Walls
On Tue, 11 Oct 2022 17:48:30 GMT, Daniel Fuchs wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Additional test with command-line filter setting. > > src/jdk.management.agent/share/conf/management.properties line 306

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter [v3]

2022-10-21 Thread Kevin Walls
On Wed, 19 Oct 2022 17:54:02 GMT, Kevin Walls wrote: >> Set the management.properties >> "com.sun.management.jmxremote.serial.filter.pattern" value by default, to >> restrict types that can be deserialized. >> >> Use the example value from the Core Libraries guide (see section 2. >> Serializ

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter [v3]

2022-10-21 Thread Daniel Fuchs
On Wed, 19 Oct 2022 17:54:02 GMT, Kevin Walls wrote: >> Set the management.properties >> "com.sun.management.jmxremote.serial.filter.pattern" value by default, to >> restrict types that can be deserialized. >> >> Use the example value from the Core Libraries guide (see section 2. >> Serializ

Re: RFR: 8283093: JMX connections should default to using an ObjectInputFilter [v3]

2022-10-21 Thread Daniel Fuchs
On Wed, 19 Oct 2022 17:54:02 GMT, Kevin Walls wrote: >> Set the management.properties >> "com.sun.management.jmxremote.serial.filter.pattern" value by default, to >> restrict types that can be deserialized. >> >> Use the example value from the Core Libraries guide (see section 2. >> Serializ

Re: RFR: 8295729: Remove trailing whitespace from non-value lines in properties files [v2]

2022-10-21 Thread Magnus Ihse Bursie
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Integrated: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port

2022-10-21 Thread Jaikiran Pai
On Sun, 18 Sep 2022 11:52:28 GMT, Jaikiran Pai wrote: > Can I please get a review of this test only change which proposes to fix the > recent intermittent failures in `RmiBootstrapTest` reported in > https://bugs.openjdk.org/browse/JDK-8030616? > > The test has been intermittently failing with

Re: RFR: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port [v2]

2022-10-21 Thread Jaikiran Pai
On Thu, 20 Oct 2022 10:01:19 GMT, Jaikiran Pai wrote: >> Can I please get a review of this test only change which proposes to fix the >> recent intermittent failures in `RmiBootstrapTest` reported in >> https://bugs.openjdk.org/browse/JDK-8030616? >> >> The test has been intermittently failing

Integrated: 8295657: SA: Allow larger object alignments

2022-10-21 Thread Aleksey Shipilev
On Wed, 19 Oct 2022 12:04:49 GMT, Aleksey Shipilev wrote: > Found this when working on JOL support > ([CODETOOLS-7903364](https://bugs.openjdk.org/browse/CODETOOLS-7903364)). If > you try to attach to VM running with -XX:ObjectAlignmentInBytes=32, then SA > would fail with: > > > Caused by:

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v2]

2022-10-21 Thread Magnus Ihse Bursie
> Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the coverage of the > whitespace checks (in the old mercurial ve

Re: RFR: 8295657: SA: Allow larger object alignments [v2]

2022-10-21 Thread Aleksey Shipilev
On Thu, 20 Oct 2022 09:40:55 GMT, Aleksey Shipilev wrote: >> Found this when working on JOL support >> ([CODETOOLS-7903364](https://bugs.openjdk.org/browse/CODETOOLS-7903364)). If >> you try to attach to VM running with -XX:ObjectAlignmentInBytes=32, then SA >> would fail with: >> >> >> Caus