On Tue, 20 Sep 2022 05:37:44 GMT, Thomas Stuefe wrote:
>> Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be
>> omitted from the output if a parent class loader never loaded any class and
>> therefore had no associated DCmd.
>>
>> The fix changes the command to not rely
On Tue, 20 Sep 2022 05:33:10 GMT, Thomas Stuefe wrote:
> Hi @plummercj , thanks for your Review. I worked most of your your feedback.
>
> .. Thomas
-
PR: https://git.openjdk.org/jdk/pull/10312
> Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be
> omitted from the output if a parent class loader never loaded any class and
> therefore had no associated DCmd.
>
> The fix changes the command to not rely on the existence of a CLD structure
> for the loader; instead
On Tue, 20 Sep 2022 16:29:08 GMT, Stuart Marks wrote:
>>> Good to see this finally become non-functional but as long as the
>>> debugger/JVMTI can trigger throwing an async ThreadDeath then I have to
>>> question the potential change in behaviour introduced by removing all the
>>> `catch (Thre
On Wed, 21 Sep 2022 02:26:02 GMT, David Holmes wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cjplummer feedback
>
> src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp line 209:
>
>> 207: st->print
On Tue, 20 Sep 2022 05:37:44 GMT, Thomas Stuefe wrote:
>> Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be
>> omitted from the output if a parent class loader never loaded any class and
>> therefore had no associated DCmd.
>>
>> The fix changes the command to not rely
On Mon, 19 Sep 2022 20:41:50 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed typo in VirtualThread.c
>
> src/hotspot/share/runtime/javaThread.cpp line 1174:
>
>> 1172: #if INCLUDE_JVMTI
On Mon, 19 Sep 2022 20:22:54 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed typo in VirtualThread.c
>
> src/hotspot/share/prims/jvmtiExport.cpp line 1055:
>
>> 1053: if (JavaThread::
On Mon, 12 Sep 2022 21:52:31 GMT, Serguei Spitsyn wrote:
>> There is a workaround we can do for
>> [JDK-8292217](https://bugs.openjdk.org/browse/JDK-8292217) for the use case
>> where a step over or step out is being done. This workaround can't be made
>> to also work for the step into case. F
On Mon, 19 Sep 2022 20:19:10 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed typo in VirtualThread.c
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 713:
>
>> 711: if (!jt->is_in_tm
On Tue, 20 Sep 2022 21:11:30 GMT, Serguei Spitsyn wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert changes
>
> test/hotspot/jtreg/testlibrary/jvmti/libJvmtiUtils.cpp line 84:
>
>> 82: }
>> 83: check_jvm
On Tue, 20 Sep 2022 00:36:38 GMT, Leonid Mesnik wrote:
>> The Thread.suspend/resume is replaced by JVM TI SuspendThread/ResumeThread
>> whether it is possible.
>> Testcase from test
>> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java
>> was removed because o
On Wed, 31 Aug 2022 00:25:20 GMT, Chris Plummer wrote:
> There is a workaround we can do for
> [JDK-8292217](https://bugs.openjdk.org/browse/JDK-8292217) for the use case
> where a step over or step out is being done. This workaround can't be made to
> also work for the step into case. From
>
On Tue, 20 Sep 2022 00:36:38 GMT, Leonid Mesnik wrote:
>> The Thread.suspend/resume is replaced by JVM TI SuspendThread/ResumeThread
>> whether it is possible.
>> Testcase from test
>> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java
>> was removed because o
On Tue, 20 Sep 2022 00:36:38 GMT, Leonid Mesnik wrote:
>> The Thread.suspend/resume is replaced by JVM TI SuspendThread/ResumeThread
>> whether it is possible.
>> Testcase from test
>> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java
>> was removed because o
On Tue, 20 Sep 2022 00:36:38 GMT, Leonid Mesnik wrote:
>> The Thread.suspend/resume is replaced by JVM TI SuspendThread/ResumeThread
>> whether it is possible.
>> Testcase from test
>> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java
>> was removed because o
On Fri, 16 Sep 2022 23:24:29 GMT, Alex Menkov wrote:
> The fix deletes bad test.
>
> Background:
> The test does not work as described in the test summary.
> It supposed to redefine test class from
> ClassLoad/ClassFileLoadHook/ClassPrepare/ClassFileLoadHook callbacks and then
> suspend the th
On Wed, 31 Aug 2022 00:25:20 GMT, Chris Plummer wrote:
> There is a workaround we can do for
> [JDK-8292217](https://bugs.openjdk.org/browse/JDK-8292217) for the use case
> where a step over or step out is being done. This workaround can't be made to
> also work for the step into case. From
>
On Tue, 20 Sep 2022 05:29:12 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp line 187:
>>
>>> 185: }
>>> 186:
>>> 187: void print_with_childs(outputStream* st, BranchTracker&
>>> branchtracker,
>>
>> I know this isn't part of your changes, but the plu
On Tue, 20 Sep 2022 06:00:14 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/io/FilterOutputStream.java line 195:
>>
>>> 193:// evaluate possible precedence of flushException
>>> over closeException
>>> 194:if ((flushException instanceof Thre
On Fri, 16 Sep 2022 23:24:29 GMT, Alex Menkov wrote:
> The fix deletes bad test.
>
> Background:
> The test does not work as described in the test summary.
> It supposed to redefine test class from
> ClassLoad/ClassFileLoadHook/ClassPrepare/ClassFileLoadHook callbacks and then
> suspend the th
21 matches
Mail list logo
