Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v9]

2022-09-08 Thread Axel Boldt-Christmas
On Mon, 29 Aug 2022 08:35:58 GMT, Axel Boldt-Christmas wrote: >> The proposal is to encapsulate the nmethod mark for deoptimization logic in >> one place and only allow access to the `mark_for_deoptimization` from a >> closure object: >> ```C++ >> class DeoptimizationMarkerClosure : StackObj {

Re: RFR: 8293218: serviceability/tmtools/jstat/GcNewTest.java fails with "Error in the percent calculation"

2022-09-08 Thread Kevin Walls
On Thu, 8 Sep 2022 09:56:05 GMT, Kevin Walls wrote: > Test update to cope with heap size changing (shrinking) in the early life of > the test app. > > A change in GC timing affects this test which reads eden size and heap size. > Both eden and heap are likely to shrink initially for this test

Re: RFR: 8293218: serviceability/tmtools/jstat/GcNewTest.java fails with "Error in the percent calculation"

2022-09-08 Thread Serguei Spitsyn
On Thu, 8 Sep 2022 14:51:06 GMT, Chris Plummer wrote: > What is the purpose of the outer loop of this test? Is it to test while the > heap is shrinking? If so, it seems there is no reason for the inner loop to > be added, and also possibly just re-ordering the read of the heap size is the > co

Integrated: 8293548: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64

2022-09-08 Thread Daniel D . Daugherty
On Thu, 8 Sep 2022 16:19:15 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64. > This time for sure Rocky! I've included the "#id1" sub-test identifier. This pull request has now been integrated. Changeset

Re: RFR: 8293548: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64

2022-09-08 Thread Daniel D . Daugherty
On Thu, 8 Sep 2022 16:24:19 GMT, Calvin Cheung wrote: >> A trivial fix to ProblemList >> sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64. >> This time for sure Rocky! I've included the "#id1" sub-test identifier. > > LGTM @calvinccheung and @azvegint - Thanks for the f

Re: RFR: 8293548: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64

2022-09-08 Thread Alexander Zvegintsev
On Thu, 8 Sep 2022 16:19:15 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64. > This time for sure Rocky! I've included the "#id1" sub-test identifier. Marked as reviewed by azvegint (Reviewer). -

Re: RFR: 8293548: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64

2022-09-08 Thread Calvin Cheung
On Thu, 8 Sep 2022 16:19:15 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64. > This time for sure Rocky! I've included the "#id1" sub-test identifier. LGTM - Marked as reviewed by ccheung (R

RFR: 8293548: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64

2022-09-08 Thread Daniel D . Daugherty
A trivial fix to ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64. This time for sure Rocky! I've included the "#id1" sub-test identifier. - Commit messages: - 8293548: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on

Re: RFR: 8293218: serviceability/tmtools/jstat/GcNewTest.java fails with "Error in the percent calculation"

2022-09-08 Thread Chris Plummer
On Thu, 8 Sep 2022 09:56:05 GMT, Kevin Walls wrote: > Test update to cope with heap size changing (shrinking) in the early life of > the test app. > > A change in GC timing affects this test which reads eden size and heap size. > Both eden and heap are likely to shrink initially for this test

Integrated: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT

2022-09-08 Thread Stefan Karlsson
On Fri, 2 Sep 2022 09:51:06 GMT, Stefan Karlsson wrote: > During the discussion of > [JDK-8292981](https://bugs.openjdk.org/browse/JDK-8292981) an opinion was > voiced that we should stop using INTPTR_FORMAT when printing pointers. > > Some background that could explain why some tend to use IN

Re: RFR: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT [v2]

2022-09-08 Thread Stefan Karlsson
On Thu, 8 Sep 2022 08:42:30 GMT, Stefan Karlsson wrote: >> During the discussion of >> [JDK-8292981](https://bugs.openjdk.org/browse/JDK-8292981) an opinion was >> voiced that we should stop using INTPTR_FORMAT when printing pointers. >> >> Some background that could explain why some tend to u

Re: RFR: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT [v2]

2022-09-08 Thread Coleen Phillimore
On Thu, 8 Sep 2022 08:42:30 GMT, Stefan Karlsson wrote: >> During the discussion of >> [JDK-8292981](https://bugs.openjdk.org/browse/JDK-8292981) an opinion was >> voiced that we should stop using INTPTR_FORMAT when printing pointers. >> >> Some background that could explain why some tend to u

Integrated: 8293432: Use diamond operator in java.management

2022-09-08 Thread Andrey Turbanov
On Mon, 5 Sep 2022 19:56:44 GMT, Andrey Turbanov wrote: > The diamond operator was introduced in Java 7. We can take advantage of this > language feature to make code easier to read. > Tested on Linux release x64. `make test TEST="jdk/java/lang/management > jdk/javax/management jdk/com/sun/jmx

Re: RFR: 8293432: Use diamond operator in java.management

2022-09-08 Thread Andrey Turbanov
On Mon, 5 Sep 2022 19:56:44 GMT, Andrey Turbanov wrote: > The diamond operator was introduced in Java 7. We can take advantage of this > language feature to make code easier to read. > Tested on Linux release x64. `make test TEST="jdk/java/lang/management > jdk/javax/management jdk/com/sun/jmx

RFR: 8293218: serviceability/tmtools/jstat/GcNewTest.java fails with "Error in the percent calculation"

2022-09-08 Thread Kevin Walls
Test update to cope with heap size changing (shrinking) in the early life of the test app. A change in GC timing affects this test which reads eden size and heap size. Both eden and heap are likely to shrink initially for this test. Failures were that heap size shrank after reading eden size,

Re: RFR: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT [v2]

2022-09-08 Thread Stefan Karlsson
On Wed, 7 Sep 2022 22:06:11 GMT, Kim Barrett wrote: > Looks good. Thanks. > Also noticed some pre-existing unnecessary (void*) casts of the pointer > argument to p2i. Not your problem, and not really appropriate for this change > to do anything about them, but I really hate eye-catching cast

Re: RFR: 8293304: Replace some usages of INTPTR_FORMAT with PTR_FORMAT [v2]

2022-09-08 Thread Stefan Karlsson
> During the discussion of > [JDK-8292981](https://bugs.openjdk.org/browse/JDK-8292981) an opinion was > voiced that we should stop using INTPTR_FORMAT when printing pointers. > > Some background that could explain why some tend to use INTPTR_FORMAT instead > of PTR_FORMAT: > > Both those form

Integrated: 8292758: put support for UNSIGNED5 format into its own header file

2022-09-08 Thread John R Rose
On Mon, 29 Aug 2022 18:20:42 GMT, John R Rose wrote: > Refactor code from inside of CompressedStream into its own unit. > > This code is likely to be used in future refactorings, such as JDK-8292818 > (replace 96-bit representation for field metadata with variable-sized > streams). > > Add gt

Re: RFR: 8292758: put support for UNSIGNED5 format into its own header file [v2]

2022-09-08 Thread John R Rose
On Sat, 3 Sep 2022 07:48:50 GMT, Dean Long wrote: >> John R Rose has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since