Re: RFR: JDK-8292067 Convert test/sun/management/jmxremote/bootstrap shell tests to java version

2022-08-29 Thread Bill Huang
On Mon, 29 Aug 2022 22:11:38 GMT, Leonid Mesnik wrote: >> This task convert 3 shell tests below to java version. >> test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh >> test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh >> test/sun/management/jmxremote/bootstrap/RmiSslNoK

Re: RFR: JDK-8292066 Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version [v2]

2022-08-29 Thread Leonid Mesnik
On Mon, 29 Aug 2022 23:25:11 GMT, Bill Huang wrote: >> This task converts 2 shell tests to java version. >> test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh >> test/java/lang/management/RuntimeMXBean/TestInputArgument.sh > > Bill Huang has updated the pull request incrementa

Re: RFR: JDK-8292067 Convert test/sun/management/jmxremote/bootstrap shell tests to java version

2022-08-29 Thread Bill Huang
On Mon, 29 Aug 2022 22:06:18 GMT, Leonid Mesnik wrote: >> This task convert 3 shell tests below to java version. >> test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh >> test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh >> test/sun/management/jmxremote/bootstrap/RmiSslNoK

Re: RFR: JDK-8292066 Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version [v2]

2022-08-29 Thread Bill Huang
> This task converts 2 shell tests to java version. > test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh > test/java/lang/management/RuntimeMXBean/TestInputArgument.sh Bill Huang has updated the pull request incrementally with two additional commits since the last revision:

Re: RFR: JDK-8292067 Convert test/sun/management/jmxremote/bootstrap shell tests to java version

2022-08-29 Thread Leonid Mesnik
On Mon, 22 Aug 2022 22:51:50 GMT, Bill Huang wrote: > This task convert 3 shell tests below to java version. > test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh > test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh > test/sun/management/jmxremote/bootstrap/RmiSslNoKeyStore

Re: RFR: JDK-8292066 Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version

2022-08-29 Thread Bill Huang
On Mon, 29 Aug 2022 21:50:14 GMT, Leonid Mesnik wrote: >> This task converts 2 shell tests to java version. >> test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh >> test/java/lang/management/RuntimeMXBean/TestInputArgument.sh > > test/jdk/java/lang/management/OperatingSystemMX

Re: RFR: 8293037: Remove DebuggerBase.writeBytes() and related code from SA

2022-08-29 Thread Alex Menkov
On Mon, 29 Aug 2022 18:54:58 GMT, Chris Plummer wrote: > DebuggerBase.writeBytes() is not needed. It is only called by a number of > other "write" methods, such as writeJBoolean(), but these methods are never > called, so they can be removed along with writeBytes(). Lastly, writeBytes() > call

Re: RFR: JDK-8292066 Convert TestInputArgument.sh and TestSystemLoadAvg.sh to java version

2022-08-29 Thread Leonid Mesnik
On Thu, 11 Aug 2022 21:12:08 GMT, Bill Huang wrote: > This task converts 2 shell tests to java version. > test/java/lang/management/OperatingSystemMXBean/TestSystemLoadAvg.sh > test/java/lang/management/RuntimeMXBean/TestInputArgument.sh test/jdk/java/lang/management/OperatingSystemMXBean/GetS

RFR: 8292995: improve the SA page cache

2022-08-29 Thread Chris Plummer
The page caching support in SA is woefully dated. I think it has stayed the same for over 20 years when it was originally done for solarix-x86. This code has been replicated for every port. Currently all ports only have a 16mb cache. They use 4k pages and there are 4k of them. I think the 4k pa

RFR: 8293037: Remove DebuggerBase.writeBytes() and related code from SA

2022-08-29 Thread Chris Plummer
DebuggerBase.writeBytes() is not needed. It is only called by a number of other "write" methods, such as writeJBoolean(), but these methods are never called, so they can be removed along with writeBytes(). Lastly, writeBytes() calls writeBytesToProcess() which has no other callers, so it too can

Re: RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v4]

2022-08-29 Thread Coleen Phillimore
> Please review this simple conversion for the ProtectionDomainCacheTable from > Old Hashtable to ResourceHashtable. There are specific tests for this table > in test/hotspot/jtreg/runtime/Dictionary and > serviceability/dcmd/vm/DictionaryStatsTest.java. > Also tested with tier1-7. Coleen Phil

Re: RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v3]

2022-08-29 Thread Coleen Phillimore
On Mon, 29 Aug 2022 00:12:36 GMT, David Holmes wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> include mutexLocker.hpp for minimal build. > > src/hotspot/share/classfile/protectionDomainCache.cpp line 42: > >

Re: RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v3]

2022-08-29 Thread Coleen Phillimore
On Fri, 26 Aug 2022 17:07:54 GMT, Coleen Phillimore wrote: >> Please review this simple conversion for the ProtectionDomainCacheTable from >> Old Hashtable to ResourceHashtable. There are specific tests for this table >> in test/hotspot/jtreg/runtime/Dictionary and >> serviceability/dcmd/vm/D

Re: RFR: JDK-8292595: jdwp utf_util getWideString might leak memory [v2]

2022-08-29 Thread Alan Bateman
On Sun, 28 Aug 2022 22:42:14 GMT, Chris Plummer wrote: > If you are going to do that, then you should track down all uses of this code > (direct and indirect) to see if this error is ever acceptable and is handled > properly. It seems that if the unicode string is bad, we should be exiting. I

Re: RFR: 8292657: Calling GetLocalXXX from virtual thread with thread parameter set to NULL returns carrier locals [v2]

2022-08-29 Thread Serguei Spitsyn
On Fri, 26 Aug 2022 21:33:13 GMT, Serguei Spitsyn wrote: >> If JVM TI GetLocalXXX/SetLocalXXX is called from a virtual thread with the >> thread parameter set to NULL (meaning current thread) then it should get/set >> the value of the locals in the virtual thread frames. Instead, it reads the

Re: RFR: 8291237: Encapsulate nmethod Deoptimization logic [v9]

2022-08-29 Thread Axel Boldt-Christmas
> The proposal is to encapsulate the nmethod mark for deoptimization logic in > one place and only allow access to the `mark_for_deoptimization` from a > closure object: > ```C++ > class DeoptimizationMarkerClosure : StackObj { > public: > virtual void marker_do(Deoptimization::MarkFn mark_fn)

Re: RFR: JDK-8292595: jdwp utf_util getWideString might leak memory [v2]

2022-08-29 Thread Matthias Baesken
On Fri, 26 Aug 2022 12:04:57 GMT, Matthias Baesken wrote: >> There seems to be a case where utf_util.c getWideString might leak memory in >> an early return. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Introduce UT