Re: RFR: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version [v4]

2022-07-15 Thread Alex Menkov
On Fri, 15 Jul 2022 18:09:08 GMT, Bill Huang wrote: >> This is a task to convert shell tests to Java tests. The shell scripts to be >> removed are responsible for compiling Java files and running the tests on >> Linux systems. This functionality can be achieved with JTReg tag @requires >> (os.

Re: RFR: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version [v4]

2022-07-15 Thread Leonid Mesnik
On Fri, 15 Jul 2022 18:09:08 GMT, Bill Huang wrote: >> This is a task to convert shell tests to Java tests. The shell scripts to be >> removed are responsible for compiling Java files and running the tests on >> Linux systems. This functionality can be achieved with JTReg tag @requires >> (os.

Re: RFR: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version [v4]

2022-07-15 Thread Bill Huang
> This is a task to convert shell tests to Java tests. The shell scripts to be > removed are responsible for compiling Java files and running the tests on > Linux systems. This functionality can be achieved with JTReg tag @requires > (os.family=="linux"). Bill Huang has updated the pull request

Re: RFR: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version [v2]

2022-07-15 Thread Bill Huang
On Thu, 14 Jul 2022 23:01:50 GMT, Leonid Mesnik wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed othervm option and fixed @requires coding style. > > The variables should use camelCase. Like min_count_for_pass

Re: RFR: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version [v3]

2022-07-15 Thread Bill Huang
> This is a task to convert shell tests to Java tests. The shell scripts to be > removed are responsible for compiling Java files and running the tests on > Linux systems. This functionality can be achieved with JTReg tag @requires > (os.family=="linux"). Bill Huang has updated the pull request

Re: RFR: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version [v2]

2022-07-15 Thread Bill Huang
On Fri, 15 Jul 2022 01:56:39 GMT, David Holmes wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed othervm option and fixed @requires coding style. > > Is the restriction to run on Linux actually still valid? Sho

Re: RFR: 8286030: Avoid JVM crash when containers share the same /tmp dir [v6]

2022-07-15 Thread Severin Gehwolf
On Tue, 12 Jul 2022 22:39:36 GMT, Ioi Lam wrote: >> Some Kubernetes setups share the /tmp directory across multiple containers. >> On rare occasions, the JVM may crash when it tries to write to >> `/tmp/hsperfdata_/` when a process in a separate container >> decides to do the same thing (becau

Re: RFR: 8286030: Avoid JVM crash when containers share the same /tmp dir [v6]

2022-07-15 Thread Severin Gehwolf
On Tue, 12 Jul 2022 22:39:36 GMT, Ioi Lam wrote: >> Some Kubernetes setups share the /tmp directory across multiple containers. >> On rare occasions, the JVM may crash when it tries to write to >> `/tmp/hsperfdata_/` when a process in a separate container >> decides to do the same thing (becau