On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
On Fri, 2 Dec 2022 16:40:51 GMT, Magnus Ihse Bursie wrote:
> According to [the
> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader))
> trailing whitespaces in the values of properties files are (somewhat
> surprisingly) ac
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote:
> Open l10n drop
> All tests passed
src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties
line 188:
> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757
> 187:
> 188: main.plugin.category=\u7C7B\u522B
As Naoto poin
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote:
> Open l10n drop
> All tests passed
src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line 26:
> 24: #
> 25:
> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener
> JMOD-Dateien auflisten
`jlink.de
On Thu, 15 Dec 2022 00:58:06 GMT, Justin Lu wrote:
>> Open l10n drop
>> All tests passed
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties
> line 188:
>
>> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757
>> 187:
>&
On Tue, 7 Mar 2023 23:15:14 GMT, Jonathan Gibbons wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support readin
This PR converts Unicode sequences to UTF-8 native in .properties file.
(Excluding the Unicode space and tab sequence). The conversion was done using
native2ascii.
In addition, the build logic is adjusted to support reading in the .properties
files as UTF-8 during the conversion from .propertie
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with four additional
commits since the last revision:
- Bug6204853 should not be converted
- Copyright year for CompileProperties
- Redo translation for CS.prope
On Wed, 15 Mar 2023 20:19:51 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Bug6204853 should not be converted
>> - Copyright year for CompileProperties
>>
On Wed, 15 Mar 2023 16:18:44 GMT, Archie L. Cobbs wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Bug6204853 should not be converted
>> - Copyright year for CompilePropert
On Thu, 16 Mar 2023 18:19:29 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with two additional
commits since the last revision:
- Reconvert CS.properties to UTF-8
- Revert all changes to CurrencySymbols.properties
-
Ch
On Thu, 16 Mar 2023 18:31:23 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Adjust CF test to read in with UTF-8 to fix failing test
-
Changes:
- all: https://git.openj
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Close streams when finished loading into props
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Fri, 17 Mar 2023 22:27:48 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 16 commits:
- Convert the merged master changes to UTF-8
- Merge master and fix conflicts
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
On Fri, 12 May 2023 16:17:38 GMT, Brian Burkhalter wrote:
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
src/java.base/share/classes/java/io/Console.java line 124:
> 122: * if (con != null) {
> 123: * Scanner sc = new Scanner(co
Please review this PR which updates the JDK's localized resources since the
previous L10n translation drop (1/26).
To help with reviewing the changes, @jonathan-gibbons created a tool which
displays the localized changes next to the original file's changes in UTF-8
native. Those files can be vi
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
On Mon, 12 Jun 2023 21:42:24 GMT, Kevin Rushforth wrote:
>> @prrace @jonathan-gibbons @pavelrappo @lahodaj @wangweij @igraves
>> @AlanBateman @eirbjo could you please review the modules / changes you are
>> familiar with, thank you.
>
> @justin-curtis-lu Unless there is a strong reason to do ot
Please review this PR which updates the JDK's localized resources since the
previous L10n translation drop (1/26).
To help with reviewing the changes, @jonathan-gibbons created a tool which
displays the localized changes next to the original file's changes in UTF-8
native. Those files can be vi
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
On Mon, 12 Jun 2023 22:17:25 GMT, Eirik Bjorsnos wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> src/jdk.jarto
On Tue, 13 Jun 2023 18:13:12 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> src/jdk.compiler/sha
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
On Tue, 13 Jun 2023 19:59:28 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> src/java.deskto
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
On Tue, 13 Jun 2023 20:56:31 GMT, Weijun Wang wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> Some comments:
>
&g
On Tue, 13 Jun 2023 18:50:42 GMT, Justin Lu wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties
>> line 140:
>>
>>> 138:
>>> 139: # 0: type, 1: name
>>> 140: compiler.err.annotation.unrecognized.attribute.n
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
On Thu, 15 Jun 2023 21:06:32 GMT, Kevin Rushforth wrote:
> Is the patch expected to be the same as in jdk mainline? I see some
> differences between the two patches (which is why Skara didn't mark it as
> "clean")
Hi Kevin, yes it is. I still need to grab the changes from mainline and include
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
Please review this PR which addresses `KeytoolReaderP12Test.java` failing for
non-English locale users.
This test checks output from keytool, but fails on finding the value 'alias
name' for non-English locale users. This is because 'alias name' is a localized
value. (For example, in `ja` this i
a
> localized value. (For example, in `ja` this is '別名').
>
> To fix the failing issue, the keytool process should be ran with
> `-J-Duser.language=en -J-Duser.country=US`.
Justin Lu has updated the pull request incrementally with two additional
commi
On Fri, 7 Jul 2023 18:58:02 GMT, Justin Lu wrote:
> Please review this PR which addresses `KeytoolReaderP12Test.java` failing for
> non-English locale users.
>
> This test checks output from keytool, but fails on finding the value 'alias
> name' for non-English loca
On Fri, 7 Jul 2023 18:58:02 GMT, Justin Lu wrote:
> Please review this PR which addresses `KeytoolReaderP12Test.java` failing for
> non-English locale users.
>
> This test checks output from keytool, but fails on finding the value 'alias
> name' for non-English loca
JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
would improve readability to see the native characters instead of escape
sequences (especially for the L10n process). The majority of files changed are
localized resource files.
This change converts the Unicode escape
or .properties files need
> to be updated to UTF-8. (IntelliJ IDEA locks .properties files as ISO-8859-1
> unless manually changed).
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Replace InputStreamReader with BufferedReader
---
On Wed, 13 Sep 2023 18:12:15 GMT, Naoto Sato wrote:
> Looks good to me, although I did not look at each l10n file, but sampled
> some. Thanks for tackling this conversion.
Thanks for the review; (In addition to testing), I ran a script to verify only
white space escape sequences exist in JDK .
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote:
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files chang
On Wed, 9 Oct 2024 16:22:13 GMT, Weijun Wang wrote:
> Switch to `ExceptionCheck`.
>
> This is a part of an umbrella bug [JDK-8341542 JNI uses of
> ExceptionOccurred() treated as if function returns a
> bool](https://bugs.openjdk.org/browse/JDK-8341542).
src/java.security.jgss/macosx/native/li
On Wed, 9 Oct 2024 16:22:13 GMT, Weijun Wang wrote:
> Switch to `ExceptionCheck`.
>
> This is a part of an umbrella bug [JDK-8341542 JNI uses of
> ExceptionOccurred() treated as if function returns a
> bool](https://bugs.openjdk.org/browse/JDK-8341542).
Marked as reviewed by jlu (Committer).
On Wed, 18 Sep 2024 06:53:27 GMT, Alan Bateman wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review comments
>
> src/java.base/share/classes/java/nio/charset/spi/CharsetP
On Wed, 18 Sep 2024 06:52:17 GMT, Alan Bateman wrote:
>> `repaint()` could be substituted with another arbitrary method name to
>> highlight some work this thread has to perform.
>>
>> given the thread name `blink`, perhaps we could just use `blink()` in this
>> example.
>
> Don't waste too mu
PI.
>
>
> in _src/java.base/share/classes/java/lang/ThreadGroup.java_.
> Please see the JBS issue comments for further reasoning on why other
> occurrences were not removed.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote:
>> Please review this PR which removes occurrences of 'applet' within the
>> corelibs specification. Applet has been deprecated since JDK9, and may be a
>> confusing term for new Java developers, so i
On Tue, 17 Sep 2024 23:14:16 GMT, Justin Lu wrote:
> Please review this PR which removes occurrences of 'applet' within the
> corelibs specification. Applet has been deprecated since JDK9, and may be a
> confusing term for new Java developers, so it should be removed from t
Please review this PR which removes occurrences of 'applet' within the corelibs
specification. Applet has been deprecated since JDK9, and may be a confusing
term for new Java developers, so it should be removed from the documentation.
Primarily, usages where 'applet' is used interchangeably with
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Tue, 10 Dec 2024 18:04:30 GMT, Weijun Wang wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - implement Severin's review
>>
>>Co-authored-by: Severin Gehwolf
>
nslations themselves.
>
> Generally speaking, observed differences in punctuation can be attributed to
> language rules. Any keys requiring localization that came in after the JDK
> was submitted for translations will be handled in the RDP2 L10n drop.
Justin Lu has updated the pull
On Tue, 10 Dec 2024 09:31:57 GMT, Jan Lahoda wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - implement Severin's review
>>
>>Co-authored-by: Severin Gehwolf
>
On Tue, 10 Dec 2024 09:27:42 GMT, Severin Gehwolf wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - implement Severin's review
>>
>>Co-authored-by: Seve
On Tue, 10 Dec 2024 00:40:23 GMT, Henry Jen wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - implement Severin's review
>>
>>Co-authored-by: Severin Gehwolf
>
On Mon, 16 Dec 2024 19:23:55 GMT, Justin Lu wrote:
>> Please review this PR which contains the open L10n drop changes for RDP1.
>>
>> I recommend viewing the improved diffs which are built out by Jon's tool
>> here: https://cr.openjdk.org/~jlu/output/. As
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote:
> Please review this PR which contains the open L10n drop changes for RDP1.
>
> I recommend viewing the improved diffs which are built out by Jon's tool
> here: https://cr.openjdk.org/~jlu/output/. As always, I ca
Hi all,
This pull request contains a backport of commit
[fd0207d5](https://github.com/openjdk/jdk/commit/fd0207d59309ae1af9539580f5bfcbc7627789cb)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Justin Lu on 16 Dec 2024 and was
nslations themselves.
>
> Generally speaking, observed differences in punctuation can be attributed to
> language rules. Any keys requiring localization that came in after the JDK
> was submitted for translations will be handled in the RDP2 L10n drop.
Justin Lu has updated the pul
On Mon, 16 Dec 2024 23:15:11 GMT, Justin Lu wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [fd0207d5](https://github.com/openjdk/jdk/commit/fd0207d59309ae1af9539580f5bfcbc7627789cb)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
Please review this PR which contains the open L10n drop changes for RDP1.
I recommend viewing the improved diffs which are built out by Jon's tool here:
https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the
correctness on the quality of the translations themselves.
Generally sp
On Fri, 6 Dec 2024 00:21:34 GMT, Damon Nguyen wrote:
>> Please review this PR which contains the open L10n drop changes for RDP1.
>>
>> I recommend viewing the improved diffs which are built out by Jon's tool
>> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the
>> co
On Fri, 6 Dec 2024 00:27:36 GMT, Damon Nguyen wrote:
> > Looks generally fine overall. But, looking at the URL for the differences
> > in each file per language, I see changes for
> > `src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher`. I
> > don't see any changes for this
On Thu, 16 Jan 2025 23:38:48 GMT, Naoto Sato wrote:
> This fix is a follow on for
> [JDK-8342550](https://bugs.openjdk.org/browse/JDK-8342550). Replaces/Removes
> usages of those deprecated time zone ids in tests.
Looks good.
test/jdk/java/text/Format/DateFormat/DateFormatTest.java line 190:
On Fri, 17 Jan 2025 00:45:54 GMT, Naoto Sato wrote:
>> This fix is a follow on for
>> [JDK-8342550](https://bugs.openjdk.org/browse/JDK-8342550). Replaces/Removes
>> usages of those deprecated time zone ids in tests.
>
> Naoto Sato has updated the pull request incrementally with one additional
On Fri, 17 Jan 2025 00:42:03 GMT, Naoto Sato wrote:
>> test/jdk/java/util/TimeZone/TimeZoneBoundaryTest.java line 417:
>>
>>> 415: //findBoundariesStepwise(1997, ONE_DAY,
>>> TimeZone.getTimeZone("EST"), 2);
>>> 416: findBoundariesStepwise(1997, ONE_DAY,
>>> TimeZone.getTimeZon
On Thu, 10 Apr 2025 08:44:28 GMT, Eirik Bjørsnøs wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replace InputStreamReader with BufferedReader
>
> FWIW, I checked out the revision
On Wed, 9 Apr 2025 15:06:32 GMT, Magnus Ihse Bursie wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 16 commits:
>>
>> - Convert the merged master changes to UTF-8
>> -
On Wed, 5 Mar 2025 00:23:51 GMT, Justin Lu wrote:
> Please review this PR which provides localization updates for resources in
> `jarsigner` and `keytool`.
> The key/vals in this PR are updated to match the changes made in the English
> source files.
> Further context is prov
On Fri, 7 Mar 2025 21:42:13 GMT, Artur Barashev wrote:
>> These resources files are in Java classes. If converted to properties files,
>> the localized versions can use UTF-8 encoding directly.
>>
>> ./src/java.base/share/classes/sun/security/tools/keytool/Resources.java
>> ./src/java.base/shar
Please review this PR which provides localization updates for resources in
`jarsigner` and `keytool`.
The key/vals in this PR are updated to match the changes made in the English
source files.
Further context is provided on the JBS issue.
-
Commit messages:
- zh_CN l10n
- ja l10n
On Thu, 6 Mar 2025 18:03:25 GMT, Artur Barashev wrote:
>>> Hi @justin-curtis-lu! Just curious how urgent is this change? I'm going to
>>> finish the .java -> .properties conversion draft soon and then you can
>>> modify the properties files in plain UTF-8 text: #22774
>>
>> We want to get this
On Wed, 5 Mar 2025 00:23:51 GMT, Justin Lu wrote:
> Please review this PR which provides localization updates for resources in
> `jarsigner` and `keytool`.
> The key/vals in this PR are updated to match the changes made in the English
> source files.
> Further context is prov
On Mon, 10 Mar 2025 14:33:14 GMT, Artur Barashev wrote:
>> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties
>> line 40:
>>
>>> 38:
>>> If.keystore.is.not.password.protected.then.storepass.and.keypass.must.not.be.specified=Wenn
>>> der Keystore nicht
On Wed, 5 Mar 2025 14:45:34 GMT, Weijun Wang wrote:
>> Please review this PR which provides localization updates for resources in
>> `jarsigner` and `keytool`.
>> The key/vals in this PR are updated to match the changes made in the English
>> source files.
>> Further context is provided on the
On Mon, 10 Mar 2025 17:57:42 GMT, Artur Barashev wrote:
>> These resources files are in Java classes. If converted to properties files,
>> the localized versions can use UTF-8 encoding directly.
>>
>> ./src/java.base/share/classes/sun/security/tools/keytool/Resources.java
>> ./src/java.base/sha
On Wed, 14 May 2025 16:59:23 GMT, Phil Race wrote:
>> Non-breaking space characters are problematic. They look identical to the
>> normal space character, but is not. For that reason, it should never be
>> typed as an UTF-8 literal, but only by using unicode sequences.
>>
>> I have checked:
>>
On Wed, 18 Jun 2025 15:28:49 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties
> line 56:
On Wed, 18 Jun 2025 15:34:38 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 1:
>
>> 1: # Copyright (c)
On Wed, 18 Jun 2025 15:59:35 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_de.proper
On Wed, 25 Jun 2025 00:27:48 GMT, Damon Nguyen wrote:
>> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties
>> line 49:
>>
>>> 47: .Principal.=\t主用户：\u0020
>>> 48: .Public.Credential.=\t公共身份证明:\u0020
>>> 49: .Private.Credential.=\t专用身份证明:\u0020
>>
>> Why aren't t
On Tue, 17 Jun 2025 01:22:31 GMT, Alisen Chung wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK since the previous L10n drop.
src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties
line 2:
> 1: #
> 2:
On Tue, 17 Jun 2025 01:22:31 GMT, Alisen Chung wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK since the previous L10n drop.
src/java.base/share/classes/sun/security/tools/keytool/resources/keytool_de.properties
line 30:
> 28:
On Wed, 18 Jun 2025 18:48:04 GMT, Damon Nguyen wrote:
>> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2001, 2023, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> Looks wrong but is correct. File had
On Wed, 18 Jun 2025 15:52:15 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix unicode escapes
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties
>
On Tue, 24 Jun 2025 14:58:38 GMT, Weijun Wang wrote:
>> However, there is no space required between two Chinese sentences. In
>> English, we usually write "I am here, and you are there." But in Chinese,
>> with the full-width punctuation, it's always "我在这里，你在那里。".
>
> Some people like to insert
Please review this PR which removes an incorrect localization test case in
_sun/security/tools/keytool/i18n.java_. The manual test was identified to not
emit any localized output for an incorrect `keystore` password via
"-storepass". However, this message is not localized and there are no plans
ocalized and there are no plans
> to localize it.
>
> The test should be updated to remove this test case.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Rajan review - swap Jtreg header bug ID
-
Changes:
- a
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Wed, 25 Jun 2025 17:08:20 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with three additional
> commits since the
On Fri, 27 Jun 2025 18:27:15 GMT, Alisen Chung wrote:
> 8359761: JDK 25 RDP1 L10n resource files update
Marked as reviewed by jlu (Committer).
-
PR Review: https://git.openjdk.org/jdk/pull/26026#pullrequestreview-2967612181
On Wed, 25 Jun 2025 21:56:10 GMT, Justin Lu wrote:
>> Please review this PR which removes an incorrect localization test case in
>> _sun/security/tools/keytool/i18n.java_. The manual test was identified to
>> not emit any localized output for an incorrect `keys
On Wed, 25 Jun 2025 20:50:43 GMT, Justin Lu wrote:
> Please review this PR which removes an incorrect localization test case in
> _sun/security/tools/keytool/i18n.java_. The manual test was identified to not
> emit any localized output for an incorrect `keystore` password via
>
Please review this PR which is a backport of commit
[5540a785](https://github.com/openjdk/jdk/commit/5540a7859b3ae0faf6b6c7f50e53ff611b253a9f)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
This is a test-only issue which removes an incorrect l10n test case.
-
Comm
On Tue, 22 Jul 2025 20:44:55 GMT, Justin Lu wrote:
> Please review this PR which is a backport of commit
> [5540a785](https://github.com/openjdk/jdk/commit/5540a7859b3ae0faf6b6c7f50e53ff611b253a9f)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This is a
On Tue, 22 Jul 2025 20:44:55 GMT, Justin Lu wrote:
> Please review this PR which is a backport of commit
> [5540a785](https://github.com/openjdk/jdk/commit/5540a7859b3ae0faf6b6c7f50e53ff611b253a9f)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This is a
1 - 100 of 101 matches
Mail list logo
