On Thu, 14 Nov 2024 14:42:30 GMT, Alan Bateman wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More obsolete code. Fix trace_class_resolution (doesn't throw exception -
>> shouldn't take TRAPS).
>
> I see a
On Thu, 14 Nov 2024 00:44:35 GMT, Volodymyr Paprotski
wrote:
>> Measuring throughput with JMH parameters `-f 1 -i 2 -wi 3 -r 20 -w 30 -p
>> algorithm=AES/CBC/NoPadding -p dataSize=3000 -p provider=SunJCE -p
>> keyLength=128 org.openjdk.bench.javax.crypto.full.AESBench`
>>
>> Before:
>>
On Thu, 14 Nov 2024 13:21:33 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Tue, 12 Nov 2024 20:35:54 GMT, Artur Barashev wrote:
>> The current syntax of the jdk.tls.disabledAlgorithms makes it difficult to
>> disable algorithms that affect both the key exchange and authentication
>> parts of a TLS cipher suite. For example, if you add "RSA" to the
>> jdk.tls.disab
> This patch remove access to the shared variable to fix scalability issue in
> the multithread environment. According to testing by the
> specjvm2008::crypto.rsa the one thread performance reduced for less than 1%
> while the score for the multithread run increased in ~2x. For the 2 socket
> s
On Fri, 1 Nov 2024 18:06:30 GMT, Artur Barashev wrote:
> The current syntax of the jdk.tls.disabledAlgorithms makes it difficult to
> disable algorithms that affect both the key exchange and authentication parts
> of a TLS cipher suite. For example, if you add "RSA" to the
> jdk.tls.disabledAl
Now that JEP 486 is integrated, the jdk.crypto.mscapi module implementation
dependencies on System.getSecurityManager and AccessController.doPrivileged can
be removed.
-
Commit messages:
- Initial cleanup.
Changes: https://git.openjdk.org/jdk/pull/22112/files
Webrev: https://web
On Thu, 14 Nov 2024 07:53:32 GMT, David Holmes wrote:
> > > To be fair I'm unclear what role PD still plays on the JDK side and would
> > > not be surprised if it is destined for removal at some point.
> >
> >
> > PD is not deprecated as PD::getCodeSource is widely used. It may be that an
> >
On Wed, 13 Nov 2024 22:03:37 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, java.security.sasl implementation
> dependencies on AccessController.doPrivileged can be removed.
looks good
-
Marked as reviewed by ascarpino (Reviewer).
PR Review: https://git.openjdk.o
> Java implementation of ML-KEM, the [FIPS
> 203](https://csrc.nist.gov/pubs/fips/203/final) post-quantum KEM scheme.
> Depends on https://github.com/openjdk/jdk/pull/21167
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Tidying up sea
> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme
> https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on
> https://github.com/openjdk/jdk/pull/21167
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
On Thu, 14 Nov 2024 00:20:06 GMT, Bradford Wetmore wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> keep expand option and add test coverage
>
> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 90:
>
On Tue, 12 Nov 2024 11:49:25 GMT, Sean Coffey wrote:
>> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation
>> was introduced many years ago.
>>
>> Where "ssl" was previously a value to obtain all TLS debug traces (except
>> network type dumps, verbose data), it now pr
Please find here a patch that cleans up the java.net.http module code to remove
permission checks and doPriviliged calls.
This was mostly mechanical.
-
Commit messages:
- 8344228: Revisit SecurityManager usage in java.net.http after JEP 486
integration
Changes: https://git.openjdk
On Thu, 14 Nov 2024 17:20:14 GMT, Artur Barashev wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments from Kevin
>
> src/java.base/share/classes/com/sun/crypto/provider/CipherBlockChaining.java
> line 2
On Thu, 14 Nov 2024 19:30:58 GMT, Sean Mullan wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fold lines for System::getProperty when reading enableMultiRelease and
>> inhibitZip64
>
> src/java.base/share/classe
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Thu, 14 Nov 2024 10:18:18 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which cleans up security manager related code in
> `java.util.zip` and `java.util.jar`:
>
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of
> `GetPropertyAction::privilegedGetProperty`
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Thu, 14 Nov 2024 00:44:35 GMT, Volodymyr Paprotski
wrote:
>> Measuring throughput with JMH parameters `-f 1 -i 2 -wi 3 -r 20 -w 30 -p
>> algorithm=AES/CBC/NoPadding -p dataSize=3000 -p provider=SunJCE -p
>> keyLength=128 org.openjdk.bench.javax.crypto.full.AESBench`
>>
>> Before:
>>
On Thu, 14 Nov 2024 20:25:35 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
> Please review this PR which cleans up security manager related code in
> `java.util.zip` and `java.util.jar`:
>
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of
> `GetPropertyAction::privilegedGetProperty`
> * `ZipFile` is updated to not call SM::checkRead, SM::
On Thu, 14 Nov 2024 20:02:50 GMT, Lance Andersen wrote:
>> I think both are in the 90-100 range. Line length is a bit subjective, but I
>> know that at least in the Security Group, we try to keep code to around 80
>> chars so it is easy to review in a side-by-side diff. It also is visually
>>
On Thu, 14 Nov 2024 13:21:33 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Thu, 14 Nov 2024 19:45:27 GMT, Eirik Bjørsnøs wrote:
>> src/java.base/share/classes/java/util/jar/JarFile.java line 182:
>>
>>> 180: }
>>> 181: RUNTIME_VERSION =
>>> Runtime.Version.parse(Integer.toString(runtimeVersion));
>>> 182: String enableMultiRelease =
>>> Sys
On Wed, 13 Nov 2024 22:03:37 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, java.security.sasl implementation
> dependencies on AccessController.doPrivileged can be removed.
This pull request has now been integrated.
Changeset: d959c7de
Author:Sean Mullan
URL:
http
On Wed, 13 Nov 2024 21:12:39 GMT, Ben Perez wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/ML_KEM.java line 471:
>>
>>> 469: }
>>> 470: }
>>> 471: return null;
>>
>> Why return null? Why not just use `void` as return type? Same for the
>> `checkPrivat
On Thu, 14 Nov 2024 20:28:31 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
> Java implementation of ML-KEM, the [FIPS
> 203](https://csrc.nist.gov/pubs/fips/203/final) post-quantum KEM scheme.
> Depends on https://github.com/openjdk/jdk/pull/21167
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Responded to c
JDK-8320743: The particular issues mentioned in the bug report seem to be
behaving as desired at this point, but we will prefer ProviderException over
RuntimeException in these classes.
-
Commit messages:
- JDK-8320743: The particular issues mentioned in the bug report seem to be
On Thu, 14 Nov 2024 22:36:39 GMT, Valerie Peng wrote:
>> This is because the `NamedKEM` methods for checking keys can optionally
>> return the key. I can pass that key along if that makes more sense
>
> Yes, passing the key along seems to make more sense.
I'm going to leave this returning null
> Java implementation of ML-KEM, the [FIPS
> 203](https://csrc.nist.gov/pubs/fips/203/final) post-quantum KEM scheme.
> Depends on https://github.com/openjdk/jdk/pull/21167
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
Moved SHA3Para
> Now that JEP 486 is integrated, the jdk.crypto.mscapi module implementation
> dependencies on System.getSecurityManager and AccessController.doPrivileged
> can be removed.
Sean Mullan has updated the pull request incrementally with one additional
commit since the last revision:
Fix compile
On Thu, 14 Nov 2024 19:58:21 GMT, Eirik Bjørsnøs wrote:
>> As long as the line in your ide is around 80 characters or less you are
>> good to go. If it is say 100 bytes so you have to scroll, that is when I
>> would fold the line.
>>
>> I think you are OK here
>
> Yes, they are 96 and 98 cha
On Thu, 14 Nov 2024 19:51:33 GMT, Lance Andersen wrote:
>> See review comments from @RogerRiggs:
>>
>> https://github.com/openjdk/jdk/pull/22099#pullrequestreview-2435969401
>> https://github.com/openjdk/jdk/pull/22099#discussion_r1842150753
>>
>> where the folding of these lines into one was s
On Thu, 14 Nov 2024 19:59:55 GMT, Sean Mullan wrote:
>> Yes, they are 96 and 98 chars long, which means I sympathise with both views
>> :)
>>
>> Unless hearing back from @seanjmullan I'll go with Roger's suggestion of one
>> line here.
>
> I think both are in the 90-100 range. Line length is a
On Mon, 21 Oct 2024 20:42:20 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/provider/ML_DSA_Provider.java line
>> 33:
>>
>>> 31: import java.util.Arrays;
>>> 32:
>>> 33: public class ML_DSA_Provider {
>>
>> This class isn't a `Provider`. Can we name it something else,
>
> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme
> https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on
> https://github.com/openjdk/jdk/pull/21167
Ben Perez has updated the pull request incrementally with one additional commit
since the last revision:
On Thu, 14 Nov 2024 20:49:55 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/CipherBlockChaining.java
>> line 222:
>>
>>> 220: processed +=
>>> 221: implDecrypt(cipher, cipherOffset, cipherLen, plain,
>>> plainOffset);
>>> 222: r
On Thu, 14 Nov 2024 15:23:35 GMT, Jonathan Gibbons wrote:
> The policy has long been to use Classpath Exception in the src and make
> directories, but not in the test directories. If you're changing the policy,
> you might want to check and update any documentation where the policy might
> be
On Thu, 14 Nov 2024 16:40:22 GMT, Vladimir Ivanov wrote:
>> This patch remove access to the shared variable to fix scalability issue in
>> the multithread environment. According to testing by the
>> specjvm2008::crypto.rsa the one thread performance reduced for less than 1%
>> while the score
On Thu, 14 Nov 2024 20:40:46 GMT, Daniel Fuchs wrote:
> Please find here a patch that cleans up the java.net.http module code to
> remove permission checks and doPriviliged calls.
> This was mostly mechanical.
Great cleanup! Good to see a lot of complicated cruft being removed.
src/java.net.ht
On Thu, 14 Nov 2024 19:53:42 GMT, Sean Mullan wrote:
>> Now that JEP 486 is integrated, the jdk.crypto.mscapi module implementation
>> dependencies on System.getSecurityManager and AccessController.doPrivileged
>> can be removed.
>
> Sean Mullan has updated the pull request incrementally with o
On Thu, 14 Nov 2024 20:28:31 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Thu, 14 Nov 2024 16:02:56 GMT, Coleen Phillimore wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
On Thu, 7 Nov 2024 17:52:53 GMT, Sean Mullan wrote:
>> Prasadrao Koppula has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 11 commits:
>>
>> - Merge master
>> - initialized storeName with empty string
>> - Replaced Paths.get with
On Wed, 13 Nov 2024 11:42:11 GMT, Coleen Phillimore wrote:
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> T
On Thu, 14 Nov 2024 00:44:35 GMT, Volodymyr Paprotski
wrote:
>> Measuring throughput with JMH parameters `-f 1 -i 2 -wi 3 -r 20 -w 30 -p
>> algorithm=AES/CBC/NoPadding -p dataSize=3000 -p provider=SunJCE -p
>> keyLength=128 org.openjdk.bench.javax.crypto.full.AESBench`
>>
>> Before:
>>
On Thu, 14 Nov 2024 10:18:18 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which cleans up security manager related code in
> `java.util.zip` and `java.util.jar`:
>
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of
> `GetPropertyAction::privilegedGetProperty`
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> Tested with tier1-4.
Coleen Phillimore has updated the pull r
On Thu, 14 Nov 2024 08:28:14 GMT, Alan Bateman wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
>>
On Thu, 14 Nov 2024 13:02:22 GMT, Coleen Phillimore wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
On Thu, 14 Nov 2024 14:03:50 GMT, Coleen Phillimore wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote:
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms o
On Thu, 7 Nov 2024 18:46:42 GMT, Sean Mullan wrote:
>> Prasadrao Koppula has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 11 commits:
>>
>> - Merge master
>> - initialized storeName with empty string
>> - Replaced Paths.get with
On Wed, 13 Nov 2024 21:14:41 GMT, Ben Perez wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/SHA3Parallel.java line
>> 37:
>>
>>> 35: import static sun.security.provider.SHA3.keccak;
>>> 36:
>>> 37: public class SHA3Parallel {
>>
>> Why not merge this with `sun.security.provider.
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote:
> In several (most? all?) of the build system files, the copyright header
> includes the classpath exception. This makes no sense, and should be removed.
>
> I have removed the classpath exception from makefiles, autoconf, shell
> sc
On Thu, 14 Nov 2024 00:44:35 GMT, Volodymyr Paprotski
wrote:
>> Measuring throughput with JMH parameters `-f 1 -i 2 -wi 3 -r 20 -w 30 -p
>> algorithm=AES/CBC/NoPadding -p dataSize=3000 -p provider=SunJCE -p
>> keyLength=128 org.openjdk.bench.javax.crypto.full.AESBench`
>>
>> Before:
>>
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> Tested with tier1-4.
Coleen Phillimore has updated the pull r
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> Tested with tier1-4.
Coleen Phillimore has updated the pull r
On Wed, 13 Nov 2024 23:38:30 GMT, Vladimir Ivanov wrote:
>> This patch remove access to the shared variable to fix scalability issue in
>> the multithread environment. According to testing by the
>> specjvm2008::crypto.rsa the one thread performance reduced for less than 1%
>> while the score
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms of editing, we make changes to
> the man pages in markdown and
On Wed, 13 Nov 2024 21:55:53 GMT, Iris Clark wrote:
>> src/java.base/share/man/java.md line 9:
>>
>>> 7: # published by the Free Software Foundation. Oracle designates this
>>> 8: # particular file as subject to the "Classpath" exception as provided
>>> 9: # by Oracle in the LICENSE file that a
On Thu, 14 Nov 2024 12:29:38 GMT, Christian Stein wrote:
> Now `CheckManPageOptions` finds the `.md` file (good) and its checks fail
> (bad).
*sigh*
> A candidate for an ignore list as fixing it is out of scope of this PR?
Let me have a look at it first. It seems the test has the indention t
On Thu, 14 Nov 2024 10:18:18 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which cleans up security manager related code in
> `java.util.zip` and `java.util.jar`:
>
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of
> `GetPropertyAction::privilegedGetProperty`
On Thu, 14 Nov 2024 00:44:35 GMT, Volodymyr Paprotski
wrote:
>> Measuring throughput with JMH parameters `-f 1 -i 2 -wi 3 -r 20 -w 30 -p
>> algorithm=AES/CBC/NoPadding -p dataSize=3000 -p provider=SunJCE -p
>> keyLength=128 org.openjdk.bench.javax.crypto.full.AESBench`
>>
>> Before:
>>
On Wed, 13 Nov 2024 11:42:11 GMT, Coleen Phillimore wrote:
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> T
In several (most? all?) of the build system files, the copyright header
includes the classpath exception. This makes no sense, and should be removed.
I have removed the classpath exception from makefiles, autoconf, shell scripts,
properties files, configuration files, IDE support files, build t
On Thu, 14 Nov 2024 10:18:18 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which cleans up security manager related code in
> `java.util.zip` and `java.util.jar`:
>
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of
> `GetPropertyAction::privilegedGetProperty`
On Thu, 14 Nov 2024 05:42:51 GMT, David Holmes wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
>>
On Thu, 14 Nov 2024 08:28:14 GMT, Alan Bateman wrote:
> Do you plan a follow-up to purge the remaining refs to AccessController and
> AccessControlContext?
I was unclear if they were still needed in the places they appear. Maybe I
should do a follow-up.
-
PR Comment: https://git
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
Please review this PR which cleans up security manager related code in
`java.util.zip` and `java.util.jar`:
* `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of
`GetPropertyAction::privilegedGetProperty`
* `ZipFile` is updated to not call SM::checkRead, SM::checkDelete
> Please review this PR which cleans up security manager related code in
> `java.util.zip` and `java.util.jar`:
>
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of
> `GetPropertyAction::privilegedGetProperty`
> * `ZipFile` is updated to not call SM::checkRead, SM::
On Thu, 14 Nov 2024 12:37:33 GMT, Roger Riggs wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fold lines for System::getProperty when reading enableMultiRelease and
>> inhibitZip64
>
> src/java.base/share/classe
On Thu, 14 Nov 2024 13:07:55 GMT, Coleen Phillimore wrote:
> hotspot/share/include/jvm.h:JVM_GetClassContext(JNIEnv *env);
>
> I think this is obsolete too.
As part of the JEP 486 work, I changed SecurityManager::getClassContext to use
StackWalker, the native method that called into JVM_GetCla
On Thu, 14 Nov 2024 13:20:23 GMT, Alan Bateman wrote:
>> hotspot/share/include/jvm.h:JVM_GetClassContext(JNIEnv *env);
>>
>> I think this is obsolete too.
>
>> hotspot/share/include/jvm.h:JVM_GetClassContext(JNIEnv *env);
>>
>> I think this is obsolete too.
>
> As part of the JEP 486 work, I c
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote:
> In several (most? all?) of the build system files, the copyright header
> includes the classpath exception. This makes no sense, and should be removed.
>
> I have removed the classpath exception from makefiles, autoconf, shell
> sc
On Thu, 14 Nov 2024 13:21:33 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Thu, 14 Nov 2024 13:40:22 GMT, Coleen Phillimore wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> Tested with tier1-4.
Coleen Phillimore has updated the pull r
On Thu, 14 Nov 2024 13:21:33 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Wed, 13 Nov 2024 20:27:01 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, the `jdk.crypto.cryptoki`
>> implementation dependencies on `System.getSecurityManager` and
>> `AccessController.doPrivileged` can be removed.
>
> Sean Mullan has updated the pull request incrementally
On Wed, 13 Nov 2024 14:44:06 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, the `jdk.crypto.cryptoki`
> implementation dependencies on `System.getSecurityManager` and
> `AccessController.doPrivileged` can be removed.
This pull request has now been integrated.
Changeset: 4d1a5
85 matches
Mail list logo
