On Thu, 7 Nov 2024 17:52:53 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Prasadrao Koppula has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 11 commits: >> >> - Merge master >> - initialized storeName with empty string >> - Replaced Paths.get with Path.of >> - Removed unnecessary code >> - Removed unnecessary code >> - Handled nested wrappers around FileInputStream >> - Handled BIS case as well >> - JDK-8329251 >> - JDK-8329251 >> - JDK-8329251 >> - ... and 1 more: https://git.openjdk.org/jdk/compare/f2316f68...c90b4f30 > > src/java.base/share/classes/javax/net/ssl/TrustManagerFactory.java line 286: > >> 284: .getPath(ks); >> 285: if (keystorePath != null) { >> 286: SSLLogger.fine(provider.getName() + ": using \"" + >> Path.of( > > Suggest rewording as "Initializing with keystore: keystore.p12 in PKCS12 > format from SUN provider" > > Do you really need to log the provider name? Printing the provider name helps identify if it’s a third-party provider, default provider, or another type. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20414#discussion_r1843124527
