Re: RFR: 8341792: Fix ExceptionOccurred in java.security.jgss

2024-10-09 Thread Justin Lu
On Wed, 9 Oct 2024 16:22:13 GMT, Weijun Wang wrote: > Switch to `ExceptionCheck`. > > This is a part of an umbrella bug [JDK-8341542 JNI uses of > ExceptionOccurred() treated as if function returns a > bool](https://bugs.openjdk.org/browse/JDK-8341542). src/java.security.jgss/macosx/native/li

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v54]

2024-10-09 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

RFR: 8341792: Fix locations in java.security.jgss

2024-10-09 Thread Weijun Wang
Switch to `ExceptionCheck`. This is a part of an umbrella bug [JDK-8341542 JNI uses of ExceptionOccurred() treated as if function returns a bool](https://bugs.openjdk.org/browse/JDK-8341542). - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/21424/files Web

Re: RFR: 8298420: PEM API: Implementation (Preview) [v6]

2024-10-09 Thread Kevin Driver
On Wed, 25 Sep 2024 18:50:55 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview featur

Re: RFR: 8298420: PEM API: Implementation (Preview) [v6]

2024-10-09 Thread Kevin Driver
On Wed, 9 Oct 2024 18:53:39 GMT, Kevin Driver wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix decoding non-encrypted types > > src/java.base/share/classes/java/security/PEMDecoder.java line 93: > >> 91:

Re: RFR: 8298420: PEM API: Implementation (Preview) [v6]

2024-10-09 Thread Kevin Driver
On Wed, 25 Sep 2024 18:50:55 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview featur

Re: RFR: 8298420: PEM API: Implementation (Preview) [v6]

2024-10-09 Thread Kevin Driver
On Wed, 25 Sep 2024 18:50:55 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview featur

Re: RFR: 8298420: PEM API: Implementation (Preview) [v6]

2024-10-09 Thread Kevin Driver
On Wed, 9 Oct 2024 19:15:28 GMT, Kevin Driver wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix decoding non-encrypted types > > src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 85: >

Withdrawn: 8232838: Update VerifyCACerts test to ensure cacerts contain entries for CA

2024-10-09 Thread duke
On Tue, 13 Aug 2024 20:49:35 GMT, Rajan Halade wrote: > Updated VerifyCACerts test to check if BasicConstraints lists "CA:true" and > KeyUsage, if included, asserts the keyCertSign bit. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/p

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v18]

2024-10-09 Thread Artur Barashev
> Check for unexpected plaintext alert message during TLSv1.3 handshake. This > can happen if client doesn't receive ServerHello due to network timeout and > tries to close the connection by sending an alert message. Artur Barashev has updated the pull request incrementally with one additional

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v17]

2024-10-09 Thread Artur Barashev
On Wed, 9 Oct 2024 07:47:38 GMT, Daniel Jeliński wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Return null if there is no record we attempted to decode > > test/jdk/javax/net/ssl/TLSv13/SSLSocketNoServerHelloCl

Re: RFR: 8341792: Fix ExceptionOccurred in java.security.jgss

2024-10-09 Thread Justin Lu
On Wed, 9 Oct 2024 16:22:13 GMT, Weijun Wang wrote: > Switch to `ExceptionCheck`. > > This is a part of an umbrella bug [JDK-8341542 JNI uses of > ExceptionOccurred() treated as if function returns a > bool](https://bugs.openjdk.org/browse/JDK-8341542). Marked as reviewed by jlu (Committer).

Re: RFC: Remove Kerberos CLI tools from OpenJDK bin folder

2024-10-09 Thread Wei-Jun Wang
Hi Bruno, I don’t quite understand the motivation. When you say "The presence of these CLI tools can cause conflicts with native versions provided by the operating system”, what is the operating system you are referring to? For example, many *nix systems come preinstalled with its own kinit, bu

Re: RFC: Remove Kerberos CLI tools from OpenJDK bin folder

2024-10-09 Thread Bruno Borges
Windows does ship its own klist.exe file on C:\Windows\System32. This started with Windows Vista. I was not aware that these were not shipped in non-Windows JDK builds, thanks for the update. An alternative for developers to continue interacting with Kerberos, is by using 3rd-party solutions s

Re: RFR: 8341792: Fix ExceptionOccurred in java.security.jgss

2024-10-09 Thread Weijun Wang
On Wed, 9 Oct 2024 17:23:08 GMT, Justin Lu wrote: >> Switch to `ExceptionCheck`. >> >> This is a part of an umbrella bug [JDK-8341542 JNI uses of >> ExceptionOccurred() treated as if function returns a >> bool](https://bugs.openjdk.org/browse/JDK-8341542). > > src/java.security.jgss/macosx/nat

RFC: Remove Kerberos CLI tools from OpenJDK bin folder

2024-10-09 Thread Bruno Borges
Hi folks, I am writing to seek your feedback and opinions on a proposal to remove the Kerberos command-line tools (e.g., kinit, klist, etc.) from OpenJDK. The Kerberos CLI tools have traditionally been included in the JDK to facilitate the management of Kerberos tickets directly through the com

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell

2024-10-09 Thread Jan Lahoda
On Tue, 8 Oct 2024 15:38:01 GMT, Magnus Ihse Bursie wrote: > Yay! This looks so much better than the default blob. I think you are on the > right track, but the actual message can do with some fine tuning. For > instance, `` seems a bit ... untypically non-formal. What > about just ``? I am n

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v12]

2024-10-09 Thread Sean Mullan
On Tue, 8 Oct 2024 23:43:42 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > We

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v17]

2024-10-09 Thread Daniel Jeliński
On Tue, 8 Oct 2024 14:59:23 GMT, Artur Barashev wrote: >> Check for unexpected plaintext alert message during TLSv1.3 handshake. This >> can happen if client doesn't receive ServerHello due to network timeout and >> tries to close the connection by sending an alert message. > > Artur Barashev h

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell

2024-10-09 Thread Weijun Wang
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote: > Currently, running `java` without any parameters will lead to an output that > is a full `--help`, which is over 100 lines (on my computer at least), and it > feels overwhelming. And many people might actually want to run JShell/REPL, > not

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell

2024-10-09 Thread Goetz Lindenmaier
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote: > Currently, running `java` without any parameters will lead to an output that > is a full `--help`, which is over 100 lines (on my computer at least), and it > feels overwhelming. And many people might actually want to run JShell/REPL, > not

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell

2024-10-09 Thread Jaikiran Pai
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote: > Currently, running `java` without any parameters will lead to an output that > is a full `--help`, which is over 100 lines (on my computer at least), and it > feels overwhelming. And many people might actually want to run JShell/REPL, > not

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell

2024-10-09 Thread Magnus Ihse Bursie
On Wed, 9 Oct 2024 07:44:49 GMT, Jan Lahoda wrote: > I was thinking of a different way to say , that would not > loose the descriptiveness, but none so far. Any more descriptive/specific > suggestions than ? I understand why you ended up with that choice of words, since it is not trivial to

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell

2024-10-09 Thread Magnus Ihse Bursie
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote: > Currently, running `java` without any parameters will lead to an output that > is a full `--help`, which is over 100 lines (on my computer at least), and it > feels overwhelming. And many people might actually want to run JShell/REPL, > not

Re: RFR: 8340133: Investigate if the java launcher could give hints about JShell

2024-10-09 Thread Kevin Bourrillion
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote: > Currently, running `java` without any parameters will lead to an output that > is a full `--help`, which is over 100 lines (on my computer at least), and it > feels overwhelming. And many people might actually want to run JShell/REPL, > not

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v12]

2024-10-09 Thread Weijun Wang
On Tue, 8 Oct 2024 23:43:42 GMT, Weijun Wang wrote: >> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are >> only named standardized parameter sets, a common framework is introduced. >> >> A example of EdDSA implementation using this framework is included as a test. > > We

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v13]

2024-10-09 Thread Weijun Wang
> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only > named standardized parameter sets, a common framework is introduced. > > A example of EdDSA implementation using this framework is included as a test. Weijun Wang has updated the pull request incrementally with one