Re: Improving logging in Krb5LoginModule

2024-03-11 Thread Seán Coffey
On 10/03/2024 16:01, Wei-Jun Wang wrote: Hi Seán, I know you are working on enhancing the security debug output with timestamps and thread info now. Do you think it can also cover Kerberos? I'd love to see Kerberos fall under the same debug implementation used by other JDK security libraries

RFR: 8327779: Remove deprecated internal field sun.security.x509.X509Key.key

2024-03-11 Thread Eirik Bjørsnøs
Please review this cleanup PR which removes the protected, deprecated field `X509Key.key` in the internal package `sun.security.x509`. This field and the associated field `unusedBits` have been marked `@Deprecated` since the initial load. The recommended replacement is to use the `BitArray` rep

Re: RFR: 8312444: Delete unused parameters and variables in SocketPermission [v3]

2024-03-11 Thread Daniel Fuchs
On Thu, 7 Mar 2024 16:53:22 GMT, Korov wrote: >> Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`, >> so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too. >> >> Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and >> `SocketPermission.a

Re: Improving logging in Krb5LoginModule

2024-03-11 Thread Wei-Jun Wang
I've filed https://bugs.openjdk.org/browse/JDK-8327818. But first, in order to make sure the debug option in Krb5LoginModule and other JGSS/krb5-related system properties still work, there needs a way to instantiate a Debug object without providing the `-Djava.security.debug` system property.

Re: Improving logging in Krb5LoginModule

2024-03-11 Thread Wei-Jun Wang
In fact, I've started working on it, see https://github.com/openjdk/jdk/pull/18199. --Weijun > On Mar 11, 2024, at 9:21 AM, Wei-Jun Wang wrote: > > I've filed https://bugs.openjdk.org/browse/JDK-8327818. > > But first, in order to make sure the debug option in Krb5LoginModule and > other JGS

Re: RFR: 8327461: KeyStore getEntry is not thread-safe [v6]

2024-03-11 Thread Hai-May Chao
On Fri, 8 Mar 2024 09:22:21 GMT, Daniel Jeliński wrote: >> Hai-May Chao has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commit

Integrated: 8327461: KeyStore getEntry is not thread-safe

2024-03-11 Thread Hai-May Chao
On Thu, 7 Mar 2024 17:06:19 GMT, Hai-May Chao wrote: > Change was made to engineGetEntry() in PKCS12KeyStore to extract the key and > certificate chain from Entry only once. This is because the entry may get > updated between engineGetKey() and engineGetCertificateChain() which causes > incons

RFR: 8327818: Implement Kerberos debug with sun.security.util.Debug

2024-03-11 Thread Weijun Wang
Change `Krb5LoginModule` debugging to use `sun.security.util.Debug`. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/18199/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18199&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327818 Stats: 191

Re: RFR: 8327818: Implement Kerberos debug with sun.security.util.Debug [v2]

2024-03-11 Thread Weijun Wang
> Change `Krb5LoginModule` debugging to use `sun.security.util.Debug`. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: no longer configurable with java.security.debug - Changes: - all: https://git.openjdk.org/jdk/pull/1

Re: RFR: 8312444: Delete unused parameters and variables in SocketPermission [v3]

2024-03-11 Thread Korov
On Tue, 5 Mar 2024 13:37:22 GMT, Korov wrote: >>> Seems good. If nobody disagrees such mixed patch, I will help you change >>> the title and content of the issue. >> >> Have changed just now! And please wait for a formal reviewer to review this >> path. > >> > Seems good. If nobody disagrees s