Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v7]

2023-12-08 Thread Ben Perez
> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to use > same debug printing format for X.509 serial numbers. The changes are: > - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is > `Serial number: 08:3B:E0:56:90:42:46:B1:A1:75:6A:C9:59:91:C7:4A` >

RFR: 8187634: keystore.getCertificateAlias(cert) returns original alias, inconsistent with fix of JDK-6483657

2023-12-08 Thread Weijun Wang
The alias in the keystore is `mapEntry.getKey()`. `entry.getAlias()` is the original friendly name, which is still useful when overwriting or removing an entry. - Commit messages: - the fix Changes: https://git.openjdk.org/jdk/pull/17037/files Webrev: https://webrevs.openjdk.org/

Re: RFR: 8296787: Unify debug printing format of X.509 cert serial numbers [v7]

2023-12-08 Thread Sean Mullan
On Fri, 8 Dec 2023 19:07:27 GMT, Ben Perez wrote: >> Updated `X509CertSelector.java`, `SerialNumber.java`, and `SSLLogger` to >> use same debug printing format for X.509 serial numbers. The changes are: >> - `X509CertSelector` was `SN: 83be056904246b1a1756ac95991c74a` and now is >> `Serial nu

Re: RFR: 8318756 Create better internal buffer for AEADs

2023-12-08 Thread Eirik Bjorsnos
On Thu, 23 Nov 2023 01:04:15 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review for a new internal buffer class called AEADBufferStream. >> AEADBufferStream extends ByteArrayOutputStream, but eliminates some data >> checking and copying that are not necessary for what GaloisCounterMod

Re: RFR: 8318756 Create better internal buffer for AEADs [v6]

2023-12-08 Thread Anthony Scarpino
On Wed, 6 Dec 2023 16:48:57 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review for a new internal buffer class called AEADBufferStream. >> AEADBufferStream extends ByteArrayOutputStream, but eliminates some data >> checking and copying that are not necessary for what GaloisCounterMode.