Re: RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly

2023-12-07 Thread Sean Mullan
On Wed, 6 Dec 2023 19:27:22 GMT, Weijun Wang wrote: > Add a fallback if an RSA signature was generated without the NULL params in > its encoded hash. src/java.base/share/classes/sun/security/rsa/RSAUtil.java line 186: > 184: * This is only used by SunRsaSign. > 185: */ > 186: pub

Re: RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly [v2]

2023-12-07 Thread Weijun Wang
On Thu, 7 Dec 2023 14:22:00 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change method to package private > > src/java.base/share/classes/sun/security/rsa/RSAUtil.java line 186: > >> 184: *

Re: RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly [v2]

2023-12-07 Thread Weijun Wang
> Add a fallback if an RSA signature was generated without the NULL params in > its encoded hash. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: change method to package private - Changes: - all: https://git.openjdk.o

Re: RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly [v2]

2023-12-07 Thread Valerie Peng
On Thu, 7 Dec 2023 14:47:18 GMT, Weijun Wang wrote: >> Add a fallback if an RSA signature was generated without the NULL params in >> its encoded hash. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > change method to packag

Re: RFR: 8319332: Security properties files inclusion [v4]

2023-12-07 Thread Francisco Ferrari Bihurriet
> The implementation of this proposal is based on the requirements, > specification and design choices described in the [JDK-8319332] ticket and > its respective CSR [JDK-8319333]. What follows are implementation notes > organized per functional component, with the purpose of assisting to naviga

Re: RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly [v2]

2023-12-07 Thread Weijun Wang
On Thu, 7 Dec 2023 19:11:23 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change method to package private > > test/jdk/sun/security/rsa/WithoutNULL.java line 27: > >> 25: * @test >> 26: * @bu

Re: RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly [v2]

2023-12-07 Thread Weijun Wang
On Thu, 7 Dec 2023 20:55:22 GMT, Weijun Wang wrote: >> test/jdk/sun/security/rsa/WithoutNULL.java line 27: >> >>> 25: * @test >>> 26: * @bug 8320597 >>> 27: * @summary RSA signature verification fails on signed data that does >>> not encode params correctly >> >> The summary seems to contra

Re: RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly [v3]

2023-12-07 Thread Weijun Wang
> Add a fallback if an RSA signature was generated without the NULL params in > its encoded hash. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: rewrite test summary - Changes: - all: https://git.openjdk.org/jdk/pull/

Re: RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly [v3]

2023-12-07 Thread Sean Mullan
On Thu, 7 Dec 2023 21:08:00 GMT, Weijun Wang wrote: >> Add a fallback if an RSA signature was generated without the NULL params in >> its encoded hash. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > rewrite test summary M

Re: RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly [v3]

2023-12-07 Thread Valerie Peng
On Thu, 7 Dec 2023 21:08:00 GMT, Weijun Wang wrote: >> Add a fallback if an RSA signature was generated without the NULL params in >> its encoded hash. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > rewrite test summary C

Integrated: 8320597: RSA signature verification fails on signed data that does not encode params correctly

2023-12-07 Thread Weijun Wang
On Wed, 6 Dec 2023 19:27:22 GMT, Weijun Wang wrote: > Add a fallback if an RSA signature was generated without the NULL params in > its encoded hash. This pull request has now been integrated. Changeset: 11e4a925 Author:Weijun Wang URL: https://git.openjdk.org/jdk/commit/11e4a925be

[jdk22] RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly

2023-12-07 Thread Weijun Wang
8320597: RSA signature verification fails on signed data that does not encode params correctly - Commit messages: - Backport 11e4a925bec3c1f79e03045d48def53188b655e6 Changes: https://git.openjdk.org/jdk22/pull/1/files Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=1&range=00

Re: [jdk22] RFR: 8320597: RSA signature verification fails on signed data that does not encode params correctly

2023-12-07 Thread Valerie Peng
On Thu, 7 Dec 2023 23:29:17 GMT, Weijun Wang wrote: > 8320597: RSA signature verification fails on signed data that does not encode > params correctly Marked as reviewed by valeriep (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/1#pullrequestreview-1771330385

[jdk22] Integrated: 8320597: RSA signature verification fails on signed data that does not encode params correctly

2023-12-07 Thread Weijun Wang
On Thu, 7 Dec 2023 23:29:17 GMT, Weijun Wang wrote: > 8320597: RSA signature verification fails on signed data that does not encode > params correctly This pull request has now been integrated. Changeset: 7de0fb36 Author:Weijun Wang URL: https://git.openjdk.org/jdk22/commit/7de0fb3