On Thu, 7 Dec 2023 19:11:23 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change method to package private > > test/jdk/sun/security/rsa/WithoutNULL.java line 27: > >> 25: * @test >> 26: * @bug 8320597 >> 27: * @summary RSA signature verification fails on signed data that does >> not encode params correctly > > The summary seems to contradict the check on line 52? Maybe: Verify RSA > signature with omitted digest params (should be encoded as NULL) for backward > compatibility? > Rest looks good. Oh, this is the title of the bug which described what was wrong, and I often simply copy this as the summary of a bug. You mean here I should emphasis what is corrected and the updated behavior? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17002#discussion_r1419653540
