The test sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java
fails intermittent with timeouts , this info should be added to the test.
-
Commit messages:
- JDK-8235297
Changes: https://git.openjdk.org/jdk/pull/11766/files
Webrev: https://webrevs.openjdk.org/?repo=jd
On Wed, 21 Dec 2022 19:34:19 GMT, Xue-Lei Andrew Fan wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimized initialisation of currentKeyID and deletion of expired session
>> keys as proposed by @schlosna
>
>
On Wed, 21 Dec 2022 19:46:57 GMT, Xue-Lei Andrew Fan wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimized initialisation of currentKeyID and deletion of expired session
>> keys as proposed by @schlosna
>
>
On Wed, 21 Dec 2022 20:07:40 GMT, Xue-Lei Andrew Fan wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimized initialisation of currentKeyID and deletion of expired session
>> keys as proposed by @schlosna
>
>
On Wed, 21 Dec 2022 20:11:44 GMT, Xue-Lei Andrew Fan wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimized initialisation of currentKeyID and deletion of expired session
>> keys as proposed by @schlosna
>
>
On Wed, 21 Dec 2022 20:23:25 GMT, Xue-Lei Andrew Fan wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimized initialisation of currentKeyID and deletion of expired session
>> keys as proposed by @schlosna
>
>
On Wed, 21 Dec 2022 22:53:49 GMT, Anthony Scarpino
wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Optimized initialisation of currentKeyID and deletion of expired session
>> keys as proposed by @schlosna
>
> s
On Wed, 21 Dec 2022 22:53:44 GMT, Anthony Scarpino
wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java line 80:
>>
>>> 78:
>>> 79: protected SessionTicketExtension.StatelessKey getKey() {
>>> 80: SessionTicketExtension.StatelessKey ssk = serverCache.getKey();
> Currently, TLS session tickets introduced by
> [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018) in JDK 13 (i.e.
> `SessionTicketExtension$StatelessKey`) are generated in the class
> `SessionTicketExtension` and they use a single, global key ID
> (`currentKeyID`) for all `SSLContext`
On Sun, 11 Dec 2022 20:38:16 GMT, Xue-Lei Andrew Fan wrote:
>> Currently, TLS session tickets introduced by
>> [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018) in JDK 13 (i.e.
>> `SessionTicketExtension$StatelessKey`) are generated in the class
>> `SessionTicketExtension` and they us
On Wed, 21 Dec 2022 21:38:22 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8299230
This pull request has now been integrated.
Changeset: a80c91d0
Author:Mark Powers
Committer: Sean Mullan
URL:
https://git.openjdk.org/jdk20/commit/a80c91d0360864e34569b684cf159e2dcdeb
On Mon, 10 Oct 2022 21:39:05 GMT, Bill Huang wrote:
> This task converts 5 manual tests to automated tests.
>
> sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
> sun/security/provider/PolicyParser/ExtDirsChange.java
> sun/security/provider/PolicyParser/ExtDirs.java
> java/securit
On Thu, 22 Dec 2022 01:03:53 GMT, Xue-Lei Andrew Fan wrote:
> Looks good to me, although it would be nice to check more protocols.
I extended the tests to include TLS 1.2 and 1.1
-
PR: https://git.openjdk.org/jdk/pull/11760
> Updated to use specific ciphersuite and TLS protocol.
> Updated tests based on changes to SSLEngine implementation
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
added additional protocols
-
Changes:
- all: https
On Thu, 22 Dec 2022 15:00:18 GMT, Volker Simonis wrote:
>> Currently, TLS session tickets introduced by
>> [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018) in JDK 13 (i.e.
>> `SessionTicketExtension$StatelessKey`) are generated in the class
>> `SessionTicketExtension` and they use a
On Thu, 22 Dec 2022 14:56:16 GMT, Volker Simonis wrote:
> For simplicity I've therefor decided to use the `KeyGenerator.init()` method
> which
> doesn't require an extra secure random instance.
I understand the logic, but some users like to use a particular provider,
keygen should use the rand
On Thu, 22 Dec 2022 11:44:52 GMT, Matthias Baesken wrote:
> The test sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java
> fails intermittent with timeouts , this info should be added to the test.
Looks good to me. I guess the intermittent failure issue could be addressed
by u
On Thu, 22 Dec 2022 17:54:53 GMT, Matthew Donovan wrote:
> > Looks good to me, although it would be nice to check more protocols.
>
> I extended the tests to include TLS 1.2 and 1.1
Thank you!
-
PR: https://git.openjdk.org/jdk/pull/11760
On Thu, 22 Dec 2022 18:00:11 GMT, Matthew Donovan wrote:
>> Updated to use specific ciphersuite and TLS protocol.
>> Updated tests based on changes to SSLEngine implementation
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Thu, 22 Dec 2022 18:42:34 GMT, Xue-Lei Andrew Fan wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added additional protocols
>
> test/jdk/javax/net/ssl/SSLEngine/Basics.java line 63:
>
>> 61: private sta
On Thu, 22 Dec 2022 18:00:11 GMT, Matthew Donovan wrote:
>> Updated to use specific ciphersuite and TLS protocol.
>> Updated tests based on changes to SSLEngine implementation
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Thu, 22 Dec 2022 18:00:11 GMT, Matthew Donovan wrote:
>> Updated to use specific ciphersuite and TLS protocol.
>> Updated tests based on changes to SSLEngine implementation
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Thu, 22 Dec 2022 15:00:18 GMT, Volker Simonis wrote:
>> Currently, TLS session tickets introduced by
>> [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018) in JDK 13 (i.e.
>> `SessionTicketExtension$StatelessKey`) are generated in the class
>> `SessionTicketExtension` and they use a
> Updated to use specific ciphersuite and TLS protocol.
> Updated tests based on changes to SSLEngine implementation
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
removed unused variables, made fields final, changed to RuntimeExc
On Thu, 22 Dec 2022 19:29:18 GMT, Matthew Donovan wrote:
>> Updated to use specific ciphersuite and TLS protocol.
>> Updated tests based on changes to SSLEngine implementation
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Updated to use specific ciphersuite and TLS protocol.
> Updated tests based on changes to SSLEngine implementation
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
additional cleanup
-
Changes:
- all: https://git.o
On Thu, 22 Dec 2022 19:51:13 GMT, Matthew Donovan wrote:
>> Updated to use specific ciphersuite and TLS protocol.
>> Updated tests based on changes to SSLEngine implementation
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Thu, 22 Dec 2022 14:56:16 GMT, Volker Simonis wrote:
>>> The same example with the 1000 connections being opened alternatively on
>>> two different contexts will instead create 1000 `StatelessKey` instances:
>>
>> That's obviously not the expected behaviors. It is a good catch for the
>> `
28 matches
Mail list logo
