On Wed, 5 Oct 2022 11:24:57 GMT, Daniel Jeliński wrote:
> This PR removes the implementation of `dispose()` method for AEAD SSLCiphers.
>
> Invocations of
> [readCipher.dispose](https://github.com/openjdk/jdk/blob/4cec141a90bc5d3b8ec17c024291d9c74a112cd4/src/java.base/share/classes/sun/security
On Wed, 5 Oct 2022 11:24:57 GMT, Daniel Jeliński wrote:
> This PR removes the implementation of `dispose()` method for AEAD SSLCiphers.
>
> Invocations of
> [readCipher.dispose](https://github.com/openjdk/jdk/blob/4cec141a90bc5d3b8ec17c024291d9c74a112cd4/src/java.base/share/classes/sun/security
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Fri, 7 Oct 2022 16:31:13 GMT, Daniel Jeliński wrote:
> BigInteger exponentiation time also depends on also depends on the base;
> quick benchmark: `BigInteger.ONE.modPow(mod.subtract(BigInteger.TWO), mod)`
> vs `BigInteger.TWO.modPow(mod.subtract(BigInteger.TWO), mod)`:
>
> ```
> Benchmark
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Mon, 10 Oct 2022 08:06:45 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check for 0 security events
>
> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java
> line 35:
>
On Sun, 9 Oct 2022 11:52:18 GMT, Aleksei Efimov wrote:
>> ### Summary of the change
>> This change introduces new system and security properties for specifying
>> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
>> implementations.
>>
>> These new properties allow more granular
On Mon, 10 Oct 2022 08:04:28 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check for 0 security events
>
> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java
> line 33:
>
On Mon, 10 Oct 2022 11:16:40 GMT, Daniel Fuchs wrote:
> If I'm not mistaken there's no point in checking the specific filter if the
> global filter state is REJECTED. So instead of switching on the
> specificResult below, maybe you should change the logic to switch on the
> globalResult instea
On Sun, 9 Oct 2022 06:53:19 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed? With this update, the result will be always
> reduced in EC limbs addition and subtraction operations in the JDK
> implementation.
>
> In the current implementation, the EC limbs addition an
On Mon, 10 Oct 2022 12:07:38 GMT, Aleksei Efimov wrote:
>> src/java.naming/share/classes/com/sun/naming/internal/ObjectFactoriesFilter.java
>> line 99:
>>
>>> 97: return globalResult == Status.ALLOWED;
>>> 98: }
>>> 99:
>>
>> If I'm not mistaken there's no point in checki
On Mon, 10 Oct 2022 11:29:52 GMT, Erik Gahlin wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java
>> line 33:
>>
>>> 31: @Category({"Java Development Kit", "Security"})
>>> 32: @Label("Initial Security Property")
>>> 33: @Name("jdk.InitialSecurityProperty")
>>
On Mon, 10 Oct 2022 07:31:29 GMT, Alan Bateman wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check for 0 security events
>
> src/java.base/share/classes/java/security/ProtectionDomain.java line 76:
>
>> 74: s
> ### Summary of the change
> This change introduces new system and security properties for specifying
> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
> implementations.
>
> These new properties allow more granular control over the set of object
> factories allowed to reconst
On Mon, 10 Oct 2022 13:14:34 GMT, Daniel Fuchs wrote:
>>> If I'm not mistaken there's no point in checking the specific filter if the
>>> global filter state is REJECTED. So instead of switching on the
>>> specificResult below, maybe you should change the logic to switch on the
>>> globalResul
On Mon, 10 Oct 2022 14:28:07 GMT, Aleksei Efimov wrote:
>> ### Summary of the change
>> This change introduces new system and security properties for specifying
>> factory filters for the JNDI/LDAP and the JNDI/RMI JDK provider
>> implementations.
>>
>> These new properties allow more granula
On Sun, 9 Oct 2022 06:53:19 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed? With this update, the result will be always
> reduced in EC limbs addition and subtraction operations in the JDK
> implementation.
>
> In the current implementation, the EC limbs addition an
On Wed, 5 Oct 2022 05:43:32 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have the code clean up reviewed?
>
> There is a lot of computation in AESCrypt class load, which could be avoid by
> using the computation result directly. The computation takes 6.971875
> milliseconds in a MacOS M1 l
On Tue, 4 Oct 2022 23:45:24 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8291974
>
> Mark Powers has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Text Blocks
> - long line
test/jdk/javax/security/auth/PrivateCredentialP
On Wed, 5 Oct 2022 05:43:32 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have the code clean up reviewed?
>
> There is a lot of computation in AESCrypt class load, which could be avoid by
> using the computation result directly. The computation takes 6.971875
> milliseconds in a MacOS M1 l
On Mon, 10 Oct 2022 16:46:25 GMT, Mark Powers wrote:
>> Hi,
>>
>> May I have the code clean up reviewed?
>>
>> There is a lot of computation in AESCrypt class load, which could be avoid
>> by using the computation result directly. The computation takes 6.971875
>> milliseconds in a MacOS M1
> Hi,
>
> May I have the code clean up reviewed?
>
> There is a lot of computation in AESCrypt class load, which could be avoid by
> using the computation result directly. The computation takes 6.971875
> milliseconds in a MacOS M1 laptop. Although it is a one-time computation, but
> removing
On Sat, 8 Oct 2022 15:34:57 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have this patch reviewed?
>>
>> This is one of a few steps to improve the EC performance. The multiplicative
>> inverse implementation could be improved for better performance.
>>
>> For secp256r1 prime p, the curr
On Mon, 10 Oct 2022 17:43:52 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have the code clean up reviewed?
>>
>> There is a lot of computation in AESCrypt class load, which could be avoid
>> by using the computation result directly. The computation takes 6.971875
>> milliseconds in a Ma
On Mon, 10 Oct 2022 17:43:52 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have the code clean up reviewed?
>>
>> There is a lot of computation in AESCrypt class load, which could be avoid
>> by using the computation result directly. The computation takes 6.971875
>> milliseconds in a Ma
The jarsigner and keytool are localized into English, German, Japanese and
Simplified Chinese. This task is to modify the existing i18n tests to validate
i18n compliance in these tools.
In addition, this task also contains changes for manual test enhancement and
simplification which originated
On Mon, 10 Oct 2022 17:43:52 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> May I have the code clean up reviewed?
>>
>> There is a lot of computation in AESCrypt class load, which could be avoid
>> by using the computation result directly. The computation takes 6.971875
>> milliseconds in a Ma
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Address Oct 10 review com
On Mon, 10 Oct 2022 14:19:18 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/ProtectionDomain.java line 76:
>>
>>> 74: static class JavaSecurityAccessImpl implements JavaSecurityAccess {
>>> 75: /* cache a copy for recording purposes */
>>> 76: static Pro
On Mon, 10 Oct 2022 07:19:30 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check for 0 security events
>
> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java
> line 29:
>
On Mon, 10 Oct 2022 19:05:45 GMT, Xue-Lei Andrew Fan wrote:
> Anyone can help run Mach5 testing in case I missed something?
Sure, I can help with that.
-
PR: https://git.openjdk.org/jdk/pull/10568
On Mon, 10 Oct 2022 18:18:55 GMT, Bill Huang wrote:
> The jarsigner and keytool are localized into English, German, Japanese and
> Simplified Chinese. This task is to modify the existing i18n tests to
> validate i18n compliance in these tools.
>
> In addition, this task also contains changes
> https://bugs.openjdk.org/browse/JDK-8291974
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
Sean comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10206/files
- new: https://git.openjdk.org/jdk/pull/10206/
On Mon, 10 Oct 2022 19:19:44 GMT, Sean Coffey wrote:
>> Agree, and alternatively, it seems cleaner to add a new SharedSecrets class
>> for `java.security.Security` and remove the dependency on PD.
>
> modified code to have Security class hold the initial properties and provided
> an accessor me
On Mon, 10 Oct 2022 20:52:01 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8291974
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Sean comments
test/jdk/javax/security/auth/PrivateCredentialPermission/Seri
This task converts 5 manual tests to automated tests.
sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java
sun/security/provider/PolicyParser/ExtDirsChange.java
sun/security/provider/PolicyParser/ExtDirs.java
java/security/Policy/Root/Root.javajava/security/Policy/Root/Root.java
javax/
On Mon, 10 Oct 2022 16:48:07 GMT, Sean Mullan wrote:
>> Mark Powers has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Text Blocks
>> - long line
>
> test/jdk/javax/security/auth/PrivateCredentialPermission/Serial2.java line 29:
>
>> 27
On Mon, 10 Oct 2022 19:45:31 GMT, Naoto Sato wrote:
>> The jarsigner and keytool are localized into English, German, Japanese and
>> Simplified Chinese. This task is to modify the existing i18n tests to
>> validate i18n compliance in these tools.
>>
>> In addition, this task also contains cha
On Mon, 10 Oct 2022 19:47:37 GMT, Naoto Sato wrote:
>> The jarsigner and keytool are localized into English, German, Japanese and
>> Simplified Chinese. This task is to modify the existing i18n tests to
>> validate i18n compliance in these tools.
>>
>> In addition, this task also contains cha
On Sun, 9 Oct 2022 06:53:19 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed? With this update, the result will be always
> reduced in EC limbs addition and subtraction operations in the JDK
> implementation.
>
> In the current implementation, the EC limbs addition an
On Sun, 9 Oct 2022 06:53:19 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed? With this update, the result will be always
> reduced in EC limbs addition and subtraction operations in the JDK
> implementation.
>
> In the current implementation, the EC limbs addition an
> The jarsigner and keytool are localized into English, German, Japanese and
> Simplified Chinese. This task is to modify the existing i18n tests to
> validate i18n compliance in these tools.
>
> In addition, this task also contains changes for manual test enhancement and
> simplification whic
revision:
>
> add back final keyword and comments about where the tables are from
Mach5 result looks ok. There is one unexpected test failure but it seems
unrelated
(https://mach5.us.oracle.com:10060/api/v1/results/vpeng-jdkOh-20221010-1957-37280778-open_test_lib-test-linux-x64-122-1665432715-16/log)
. So, it should be fine.
-
PR: https://git.openjdk.org/jdk/pull/10568
46 matches
Mail list logo
