On Wed, 10 Aug 2022 16:10:02 GMT, Bernd wrote:
>> I think if you just said "If this properties file ..." it would be
>> sufficient, as the previous paragraph provided enough context as to what you
>> are referring to.
>
> Btw the current code does not handlmissing or unreadable overwrite files
On Thu, 4 Aug 2022 15:22:23 GMT, Sean Coffey wrote:
> In the broken case where the conf/security/java.security configuration file
> doesn't exist, the JDK should throw an Error.
>
> CSR in progress.
This pull request has now been integrated.
Changeset: 9d7c13eb
Author:Sean Coffey
URL:
On Sun, 14 Aug 2022 06:39:58 GMT, Julian Waters wrote:
>> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but
>> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which
>> is actually 1 on Windows, not -1. Can be safely commented out as it isn't
>>
On Sun, 14 Aug 2022 06:39:58 GMT, Julian Waters wrote:
>> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but
>> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which
>> is actually 1 on Windows, not -1. Can be safely commented out as it isn't
>>
On Sun, 14 Aug 2022 06:39:58 GMT, Julian Waters wrote:
>> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but
>> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which
>> is actually 1 on Windows, not -1. Can be safely commented out as it isn't
>>
On Mon, 8 Aug 2022 17:34:59 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but
> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which
> is actually 1 on Windows, not -1. Can be safely commented out as it isn't
> used anywhere, except for in a call to ExitProcess which has
On Mon, 15 Aug 2022 16:17:42 GMT, Julian Waters wrote:
>> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but
>> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which
>> is actually 1 on Windows, not -1. Can be safely commented out as it isn't
>>
On Thu, 28 Jul 2022 17:23:05 GMT, Julian Waters wrote:
> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but
> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which
> is actually 1 on Windows, not -1. Can be safely commented out as it isn't
> used
On Fri, 5 Aug 2022 05:23:15 GMT, Xue-Lei Andrew Fan wrote:
> In the SunJSSE implementation, there are a few unexpected extending of static
> class SupportedGroups. It may be nice to clean them up so that the code is
> easier to read. Please review this simple code clean up.
This pull request
10 matches
Mail list logo
