On Tue, 5 Jul 2022 20:19:10 GMT, Daniel Jeliński wrote:
> This patch removes many unused variables and one unused label reported by the
> compilers when relevant warnings are enabled.
>
> The unused code was found by compiling after removing `unused` from the list
> of disabled warnings for
On Tue, 12 Jul 2022 18:35:50 GMT, Weijun Wang wrote:
> I haven't seen this error before. Try again.
Oh okay :) Sure I will try again
-
PR: https://git.openjdk.org/jdk/pull/9306
On Tue, 12 Jul 2022 17:38:38 GMT, Weijun Wang wrote:
>> Why isn't it sufficient to just call logout once per each login module?
>
> I meant to make the test more real. When there are multiple login modules,
> the principals and credentials sets could be different. For example, the
> `privateCre
On Tue, 12 Jul 2022 18:35:50 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments to update copyright section.
>
> I haven't seen this error before. Try again.
@wangw
On Tue, 28 Jun 2022 08:33:58 GMT, Jayashree Huttanagoudar
wrote:
> Could you please review the changes?
> This is to address the issue:
> https://bugs.openjdk.org/browse/JDK-8283082?jql=labels%20%3D%20starter-bug
This pull request has now been integrated.
Changeset: 31f7fc04
Author:Jayash
On Mon, 11 Jul 2022 11:46:21 GMT, Сергей Цыпанов wrote:
>> We can skip bounds check and null check for Charset in case we use the array
>> entirely and the Charset is either default one or proven to be non-null.
>>
>> Benchmark results:
>>
>> before
>>
>> Benchmark
On Tue, 12 Jul 2022 14:34:32 GMT, Weijun Wang wrote:
>> 1. I tried to keep as much of the original parenthesis as possible. I can do
>> the minimum number if that is what you prefer.
>> 2. I'll change MD4, MD5, and SHA-1 to use `rotateLeft` in keeping with how
>> they are described in their res
