On Wed, 12 Mar 2025 15:29:36 GMT, Matthew Donovan wrote:
>> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
>> consolidate duplicate code across tests.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Thu, 13 Mar 2025 11:25:34 GMT, Matthew Donovan wrote:
>> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
>> consolidate duplicate code across tests.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
> consolidate duplicate code across tests.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
fixed imports and copyright year
-
Changes:
- all:
On Wed, 12 Mar 2025 20:28:31 GMT, Matthew Donovan wrote:
>> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
>> consolidate duplicate code across tests.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Wed, 12 Mar 2025 16:39:41 GMT, Weijun Wang wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed ArtifactResolver.fetchOne() to throw a skipped exception
>
> test/jdk/sun/security/pkcs11/PKCS11Test.java lin
> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
> consolidate duplicate code across tests.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
updated code to remove extraneous null checks
-
Chang
On Wed, 12 Mar 2025 16:05:12 GMT, Weijun Wang wrote:
>> Do you mean to just assume `artifact` is never null and let the NPE be
>> thrown if it is?
>
> Yes.
I updated the code to reflect that.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/23989#discussion_r1991893033
On Wed, 12 Mar 2025 13:27:49 GMT, Weijun Wang wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed exception message in Artifact resolver and fixed logic in keytool
>> test
>
> test/jdk/sun/security/pkcs11/P
On Wed, 12 Mar 2025 13:50:06 GMT, Matthew Donovan wrote:
>> test/lib/jdk/test/lib/artifacts/ArtifactResolver.java line 103:
>>
>>> 101: message = "Cannot find the artifact " +
>>> artifact.name();
>>> 102: } else {
>>> 103: message = "Class " + klass.
On Wed, 12 Mar 2025 13:29:08 GMT, Weijun Wang wrote:
>> It encapsulates all of the logic involved in getting the tests.
>> Specifically, what to do if the tests can't be fetched. It could be done in
>> `main()` but this is a little cleaner.
>
> I'd rather just let `ArtifactResolver.fetchOne` th
On Wed, 12 Mar 2025 13:31:56 GMT, Weijun Wang wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed exception message in Artifact resolver and fixed logic in keytool
>> test
>
> test/lib/jdk/test/lib/artifact
> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
> consolidate duplicate code across tests.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
Changed ArtifactResolver.fetchOne() to throw a skipped exception
-
On Tue, 11 Mar 2025 16:24:23 GMT, Matthew Donovan wrote:
>> test/jdk/sun/security/provider/acvp/Launcher.java line 181:
>>
>>> 179: }
>>> 180:
>>> 181: private static Path fetchACVPServerTests(Class clazz) {
>>
>> Is there a point in this method? It's used in 1 spot only it seems and y
On Tue, 11 Mar 2025 16:53:17 GMT, Matthew Donovan wrote:
>> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
>> consolidate duplicate code across tests.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Tue, 11 Mar 2025 16:48:03 GMT, Matthew Donovan wrote:
>> test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java line 90:
>>
>>> 88: generateInitialKeystores(opensslPath);
>>> 89: testWithJavaCommands();
>>> 90: testWithOpensslCommands(opens
On Tue, 11 Mar 2025 16:53:17 GMT, Matthew Donovan wrote:
>> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
>> consolidate duplicate code across tests.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
> consolidate duplicate code across tests.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
Changed exception message in Artifact resolver and fixed logic in k
On Tue, 11 Mar 2025 15:39:17 GMT, Mikhail Yankelevich
wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed exception message in Artifact resolver and fixed logic in keytool
>> test
>
> test/jdk/sun/security
On Tue, 11 Mar 2025 15:59:53 GMT, Fernando Guallini
wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed exception message in Artifact resolver and fixed logic in keytool
>> test
>
> test/jdk/sun/security/p
On Tue, 11 Mar 2025 15:21:09 GMT, Matthew Donovan wrote:
> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
> consolidate duplicate code across tests.
test/jdk/sun/security/provider/acvp/Launcher.java line 181:
> 179: }
> 180:
> 181: private static Path fetchACVPS
On Tue, 11 Mar 2025 15:21:09 GMT, Matthew Donovan wrote:
> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
> consolidate duplicate code across tests.
test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java line 90:
> 88: generateInitialKeystores(openss
21 matches
Mail list logo
