On Sat, 5 Apr 2025 01:30:49 GMT, Shaojin Wen wrote:
>> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10
>> anonymous classes, which slows down the startup. This PR is to improve
>> KnownOIDs and eliminate unnecessary embedded classes.
>>
>>
>> Here's how to reproduce this:
On Sat, 5 Apr 2025 01:30:49 GMT, Shaojin Wen wrote:
>> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10
>> anonymous classes, which slows down the startup. This PR is to improve
>> KnownOIDs and eliminate unnecessary embedded classes.
>>
>>
>> Here's how to reproduce this:
On Mon, 14 Apr 2025 14:40:02 GMT, Roger Riggs wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> from @valeriepeng
>
> Looks ok; but will need to be re-opened. It would seem odd to approve a
> closed PR.
Sorry it too
On Sat, 8 Feb 2025 09:26:29 GMT, Shaojin Wen wrote:
>>> The reproducer you provided doesn't try to load KnownOIDs on my machine.
>>> What am I missing?
>>>
>>> Other than that, the change looks reasonable to me.
>>
>> Me neither and I'm using linux. Are you sure the Startup.java is right?
>> J
On Sat, 5 Apr 2025 01:30:49 GMT, Shaojin Wen wrote:
>> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10
>> anonymous classes, which slows down the startup. This PR is to improve
>> KnownOIDs and eliminate unnecessary embedded classes.
>>
>>
>> Here's how to reproduce this:
On Sat, 5 Apr 2025 01:30:49 GMT, Shaojin Wen wrote:
>> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10
>> anonymous classes, which slows down the startup. This PR is to improve
>> KnownOIDs and eliminate unnecessary embedded classes.
>>
>>
>> Here's how to reproduce this:
> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 anonymous
> classes, which slows down the startup. This PR is to improve KnownOIDs and
> eliminate unnecessary embedded classes.
>
>
> Here's how to reproduce this:
>
>
> public class Startup {
> public static void main
On Sat, 8 Feb 2025 08:44:04 GMT, Shaojin Wen wrote:
>> You could define the static field on another class, like SecurityConstants,
>> and then use it in the enum constructor.
>
> Creating a new empty string array every time is the original behavior, which
> has nothing to do with the purpose of
On Fri, 7 Feb 2025 01:46:03 GMT, Valerie Peng wrote:
> > The reproducer you provided doesn't try to load KnownOIDs on my machine.
> > What am I missing?
> > Other than that, the change looks reasonable to me.
>
> Me neither and I'm using linux. Are you sure the Startup.java is right? Just
> cu
On Thu, 6 Feb 2025 23:45:57 GMT, Johannes Graham wrote:
>> you are right, but accessing static field from enum constructor is not
>> allowed
>
> You could define the static field on another class, like SecurityConstants,
> and then use it in the enum constructor.
Creating a new empty string ar
On Wed, 5 Feb 2025 16:41:10 GMT, Shaojin Wen wrote:
> The reproducer you provided doesn't try to load KnownOIDs on my machine. What
> am I missing?
>
> Other than that, the change looks reasonable to me.
Me neither and I'm using linux. Are you sure the Startup.java is right?
Just curious, do y
On Wed, 5 Feb 2025 16:29:24 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/sun/security/util/KnownOIDs.java line 494:
>>
>>> 492: this.stdName = stdName;
>>> 493: this.registerNames = registerNames;
>>> 494: this.aliases = new String[0];
>>
>> Unless this String[
On Sun, 2 Feb 2025 19:35:03 GMT, Shaojin Wen wrote:
> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 anonymous
> classes, which slows down the startup. This PR is to improve KnownOIDs and
> eliminate unnecessary embedded classes.
>
>
> Here's how to reproduce this:
>
>
On Sun, 2 Feb 2025 19:35:03 GMT, Shaojin Wen wrote:
> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 anonymous
> classes, which slows down the startup. This PR is to improve KnownOIDs and
> eliminate unnecessary embedded classes.
>
>
> Here's how to reproduce this:
>
>
On Wed, 5 Feb 2025 12:26:17 GMT, Daniel Jeliński wrote:
> The reproducer you provided doesn't try to load KnownOIDs on my machine. What
> am I missing?
>
> Other than that, the change looks reasonable to me.
Sorry, maybe I am wrong. My test above is using
build/macosx-aarch64-server-release/j
On Wed, 5 Feb 2025 15:21:59 GMT, Roger Riggs wrote:
>> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10
>> anonymous classes, which slows down the startup. This PR is to improve
>> KnownOIDs and eliminate unnecessary embedded classes.
>>
>>
>> Here's how to reproduce this:
On Sun, 2 Feb 2025 19:35:03 GMT, Shaojin Wen wrote:
> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 anonymous
> classes, which slows down the startup. This PR is to improve KnownOIDs and
> eliminate unnecessary embedded classes.
>
>
> Here's how to reproduce this:
>
>
On Sun, 2 Feb 2025 19:35:03 GMT, Shaojin Wen wrote:
> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 anonymous
> classes, which slows down the startup. This PR is to improve KnownOIDs and
> eliminate unnecessary embedded classes.
>
>
> Here's how to reproduce this:
>
>
On Sun, 2 Feb 2025 19:35:03 GMT, Shaojin Wen wrote:
> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 anonymous
> classes, which slows down the startup. This PR is to improve KnownOIDs and
> eliminate unnecessary embedded classes.
>
>
> Here's how to reproduce this:
>
>
19 matches
Mail list logo
