Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v8]

2025-04-10 Thread Francisco Ferrari Bihurriet
> Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New services map design > > Here is the high-level hierarchy of the new ser

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-05 Thread Martin Balao
On Tue, 4 Mar 2025 01:59:58 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-05 Thread Martin Balao
On Tue, 25 Feb 2025 19:40:24 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same ord

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-05 Thread Martin Balao
On Thu, 6 Mar 2025 07:06:08 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-05 Thread Martin Balao
On Thu, 6 Mar 2025 06:13:22 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-04 Thread Martin Balao
On Thu, 3 Apr 2025 00:27:50 GMT, Martin Balao wrote: >> src/java.base/share/classes/java/security/Provider.java line 1037: >> >>> 1035: } >>> 1036: >>> 1037: if (mi.isLegacy) { >> >> For legacy entry, there is no check on the `legacyApiCall` value, is this >> due to th

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-04 Thread Martin Balao
On Mon, 3 Mar 2025 18:31:19 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v7]

2025-04-03 Thread Francisco Ferrari Bihurriet
> Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New services map design > > Here is the high-level hierarchy of the new ser

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v6]

2025-04-02 Thread Francisco Ferrari Bihurriet
> Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New services map design > > Here is the high-level hierarchy of the new ser

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Thu, 6 Mar 2025 06:10:09 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Thu, 6 Mar 2025 06:15:17 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Wed, 5 Mar 2025 01:40:55 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Wed, 5 Mar 2025 07:06:45 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Wed, 5 Mar 2025 01:02:15 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Tue, 4 Mar 2025 01:55:06 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Mon, 3 Mar 2025 23:24:29 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Wed, 26 Feb 2025 01:56:58 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same ord

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Wed, 26 Feb 2025 01:44:26 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same ord

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Wed, 26 Feb 2025 01:09:55 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same ord

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Wed, 26 Feb 2025 00:50:39 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same ord

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Wed, 26 Feb 2025 00:45:13 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same ord

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Wed, 26 Feb 2025 00:26:43 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same ord

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Wed, 26 Feb 2025 00:21:48 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same ord

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Francisco Ferrari Bihurriet
On Tue, 25 Feb 2025 23:49:41 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same ord

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-02 Thread Martin Balao
On Tue, 25 Feb 2025 19:45:47 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same ord

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-03-11 Thread Valerie Peng
On Wed, 12 Feb 2025 20:46:31 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-03-05 Thread Valerie Peng
On Wed, 12 Feb 2025 20:46:31 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-03-05 Thread Valerie Peng
On Wed, 12 Feb 2025 20:46:31 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-03-04 Thread Valerie Peng
On Wed, 12 Feb 2025 20:46:31 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-03-04 Thread Valerie Peng
On Wed, 12 Feb 2025 20:46:31 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-03-04 Thread Valerie Peng
On Wed, 12 Feb 2025 20:46:31 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-03-04 Thread Valerie Peng
On Wed, 12 Feb 2025 20:46:31 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-02-12 Thread Francisco Ferrari Bihurriet
> Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New services map design > > Here is the high-level hierarchy of the new ser

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v4]

2025-02-12 Thread Francisco Ferrari Bihurriet
On Tue, 11 Feb 2025 23:33:49 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v2]

2025-02-11 Thread Martin Balao
On Wed, 22 Jan 2025 00:53:13 GMT, Anthony Scarpino wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Copyright update. >> >> Co-authored-by: Martin Balao Alonso >> Co-authored-by: Francisco Fe

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v4]

2025-02-11 Thread Martin Balao
On Tue, 11 Feb 2025 23:33:49 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v4]

2025-02-11 Thread Martin Balao
On Tue, 21 Jan 2025 23:54:02 GMT, Anthony Scarpino wrote: >> Just to add some more semantic value but we don't have a strong opinion, we >> can replace it with boolean if you want. > > Yes, please do that. Done. - PR Review Comment: https://git.openjdk.org/jdk/pull/22613#discussi

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v4]

2025-02-11 Thread Francisco Ferrari Bihurriet
> Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New services map design > > Here is the high-level hierarchy of the new ser

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v3]

2025-02-11 Thread Francisco Ferrari Bihurriet
> Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New services map design > > Here is the high-level hierarchy of the new ser

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v2]

2025-01-24 Thread Anthony Scarpino
On Wed, 8 Jan 2025 16:32:46 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >>

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v2]

2025-01-24 Thread Anthony Scarpino
On Thu, 12 Dec 2024 04:50:04 GMT, Martin Balao wrote: >> src/java.base/share/classes/java/security/Provider.java line 710: >> >>> 708: * Enum to inform the result of an operation on the services >>> map. >>> 709: */ >>> 710: enum SvcOpResult { >> >> Why use an enum he

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v2]

2025-01-08 Thread Francisco Ferrari Bihurriet
> Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New services map design > > Here is the high-level hierarchy of the new ser

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map

2024-12-11 Thread Martin Balao
On Wed, 11 Dec 2024 19:08:52 GMT, Anthony Scarpino wrote: >> Hi, this pull request implements the fixes for bugs and inconsistencies >> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix >> bugs and inconsistencies in the Provider services map"). >> >> New servic

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map

2024-12-11 Thread Anthony Scarpino
On Fri, 6 Dec 2024 19:36:09 GMT, Francisco Ferrari Bihurriet wrote: > Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New s

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map

2024-12-11 Thread Sean Mullan
On Fri, 6 Dec 2024 19:36:09 GMT, Francisco Ferrari Bihurriet wrote: > Hi, this pull request implements the fixes for bugs and inconsistencies > described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix > bugs and inconsistencies in the Provider services map"). > > New s