On Wed, 26 Feb 2025 00:26:43 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same order. > > src/java.base/share/classes/java/security/Provider.java line 2071: > >> 2069: // For services added to a ServicesMap, their algorithm >> service key. >> 2070: // This value derives from the algorithm field. For services >> (still) >> 2071: // not added to a ServicesMap, value is null. > > The current comment is a bit hard to read. > How about "The mapping key of this service when added to a `ServiceMap`; null > if not yet added to a `ServiceMap`"? > The value is derived from the type and algorithm and this is straightforward > enough that probably need not be commented. Comment re-written. > src/java.base/share/classes/java/security/Provider.java line 2110: > >> 2108: >> 2109: /* >> 2110: * Constructor used from the ServicesMap Legacy API. > > nit: "used **by**"? Same goes for other places. Good. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22613#discussion_r2025502125 PR Review Comment: https://git.openjdk.org/jdk/pull/22613#discussion_r2025503163
