Re: RFR: 8327182: Move serverAlias into the loop [v2]

2024-03-19 Thread Weijun Wang
On Mon, 4 Mar 2024 09:14:23 GMT, Guoxiong Li wrote: >> At the beginning of a iteration, `km.chooseServerAlias` or >> `km.chooseEngineServerAlias` tries to find an alias. Then, `serverAlias` >> should be `null` or an existing alias in the key manager. >> The `serverAlias` assigned by the last it

Re: RFR: 8327182: Move serverAlias into the loop [v2]

2024-03-18 Thread John Jiang
On Fri, 15 Mar 2024 13:34:23 GMT, Sean Mullan wrote: >> John Jiang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into JDK-8327182 >> - 8327182: Move serverAlias into the loop > > Look

Re: RFR: 8327182: Move serverAlias into the loop [v2]

2024-03-15 Thread Sean Mullan
On Thu, 14 Mar 2024 03:12:30 GMT, John Jiang wrote: >> In method `X509Authentication::createServerPossession`, it looks unnecessary >> to define variable `serverAlias` out of the for-loop. >> It may be better to move `serverAlias` into that loop to narrow down the >> scope. > > John Jiang has u

Re: RFR: 8327182: Move serverAlias into the loop [v2]

2024-03-13 Thread John Jiang
> In method `X509Authentication::createServerPossession`, it looks unnecessary > to define variable `serverAlias` out of the for-loop. > It may be better to move `serverAlias` into that loop to narrow down the > scope. John Jiang has updated the pull request with a new target base due to a merge

Re: RFR: 8327182: Move serverAlias into the loop

2024-03-04 Thread Guoxiong Li
On Mon, 4 Mar 2024 03:58:18 GMT, John Jiang wrote: > In method `X509Authentication::createServerPossession`, it looks unnecessary > to define variable `serverAlias` out of the for-loop. > It may be better to move `serverAlias` into that loop to narrow down the > scope. Marked as reviewed by gl

Re: RFR: 8327182: Move serverAlias into the loop

2024-03-04 Thread Guoxiong Li
On Mon, 4 Mar 2024 08:43:33 GMT, John Jiang wrote: >>> If an alias can be used by the subsequent iterations, that looks a bug. >> >> Looks like a bug. So your patch is a bug fix instead of simple cleanup. >> Should we change the title of this issue or/and provide a test case? > > At the beginni

Re: RFR: 8327182: Move serverAlias into the loop

2024-03-04 Thread John Jiang
On Mon, 4 Mar 2024 08:26:28 GMT, Guoxiong Li wrote: >> With my understanding, in each iteration, firstly choose an alias from key >> manager with a key type, and then try to get the keys and certificates >> associated with this alias. >> If an alias or its associated keys and certificates have

Re: RFR: 8327182: Move serverAlias into the loop

2024-03-04 Thread Guoxiong Li
On Mon, 4 Mar 2024 06:57:23 GMT, John Jiang wrote: > If an alias can be used by the subsequent iterations, that looks a bug. Looks like a bug. So your patch is a bug fix instead of simple cleanup. Should we change the title of this issue or/and provide a test case? - PR Review Com

Re: RFR: 8327182: Move serverAlias into the loop

2024-03-03 Thread John Jiang
On Mon, 4 Mar 2024 05:04:13 GMT, Guoxiong Li wrote: >> In method `X509Authentication::createServerPossession`, it looks unnecessary >> to define variable `serverAlias` out of the for-loop. >> It may be better to move `serverAlias` into that loop to narrow down the >> scope. > > src/java.base/sh

Re: RFR: 8327182: Move serverAlias into the loop

2024-03-03 Thread Guoxiong Li
On Mon, 4 Mar 2024 03:58:18 GMT, John Jiang wrote: > In method `X509Authentication::createServerPossession`, it looks unnecessary > to define variable `serverAlias` out of the for-loop. > It may be better to move `serverAlias` into that loop to narrow down the > scope. src/java.base/share/clas