On Tue, 16 Jan 2024 18:44:36 GMT, Sean Mullan wrote:
>> John Jiang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more check on generateSecret
>
> Marked as reviewed by mullan (Reviewer).
@seanjmullan
Thanks for your approval!
--
On Tue, 16 Jan 2024 16:42:37 GMT, John Jiang wrote:
>> ECDHKeyAgreement should validate the parameters before assigning them to the
>> fields.
>
> John Jiang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> more check on generateSecret
Mar
> ECDHKeyAgreement should validate the parameters before assigning them to the
> fields.
John Jiang has updated the pull request incrementally with one additional
commit since the last revision:
more check on generateSecret
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17
On Mon, 15 Jan 2024 03:37:45 GMT, John Jiang wrote:
>> ECDHKeyAgreement should validate the parameters before assigning them to the
>> fields.
>
> John Jiang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Not use JUnit
test/jdk/sun/secur
On Sun, 14 Jan 2024 19:09:57 GMT, Sean Mullan wrote:
>> I originally didn't depend on JUnit. But this tool can easily execute
>> multiple test cases independently.
>> A single failed case doesn't make the whole test fail fast, and all cases
>> always be executed.
>
> Fair point, although there
> ECDHKeyAgreement should validate the parameters before assigning them to the
> fields.
John Jiang has updated the pull request incrementally with one additional
commit since the last revision:
Not use JUnit
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17373/files
- n
On Sat, 13 Jan 2024 00:49:39 GMT, John Jiang wrote:
>> test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 28:
>>
>>> 26: * @bug 8320449
>>> 27: * @summary ECDHKeyAgreement should validate parameters before
>>> assigning them to fields.
>>> 28: * @run junit ECDHKeyAgreementPar
On Sat, 13 Jan 2024 01:07:20 GMT, Bernd wrote:
>> John Jiang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more assertThrows on doPhase
>
> test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 90:
>
>> 88: KeyAgr
> ECDHKeyAgreement should validate the parameters before assigning them to the
> fields.
John Jiang has updated the pull request incrementally with one additional
commit since the last revision:
more assertThrows on doPhase
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17
On Thu, 11 Jan 2024 13:33:54 GMT, John Jiang wrote:
> ECDHKeyAgreement should validate the parameters before assigning them to the
> fields.
test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 90:
> 88: KeyAgreement ka = KeyAgreement.getInstance("ECDH");
> 89: ka
On Fri, 12 Jan 2024 20:51:03 GMT, Sean Mullan wrote:
>> ECDHKeyAgreement should validate the parameters before assigning them to the
>> fields.
>
> test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 28:
>
>> 26: * @bug 8320449
>> 27: * @summary ECDHKeyAgreement should validate
On Thu, 11 Jan 2024 13:33:54 GMT, John Jiang wrote:
> ECDHKeyAgreement should validate the parameters before assigning them to the
> fields.
test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 28:
> 26: * @bug 8320449
> 27: * @summary ECDHKeyAgreement should validate parameter
On Fri, 12 Jan 2024 15:30:33 GMT, John Jiang wrote:
>> src/java.base/share/classes/sun/security/ec/ECDHKeyAgreement.java line 83:
>>
>>> 81: privateKey = null;
>>> 82: privateKeyOps = null;
>>> 83: publicKey = null;
>>
>> The fields should be initialized to null, so I do
On Fri, 12 Jan 2024 13:46:43 GMT, Sean Mullan wrote:
>> ECDHKeyAgreement should validate the parameters before assigning them to the
>> fields.
>
> src/java.base/share/classes/sun/security/ec/ECDHKeyAgreement.java line 83:
>
>> 81: privateKey = null;
>> 82: privateKeyOps = null;
On Thu, 11 Jan 2024 13:33:54 GMT, John Jiang wrote:
> ECDHKeyAgreement should validate the parameters before assigning them to the
> fields.
src/java.base/share/classes/sun/security/ec/ECDHKeyAgreement.java line 83:
> 81: privateKey = null;
> 82: privateKeyOps = null;
> 83:
15 matches
Mail list logo
