Re: RFR: 8316964: Security tools should not call System.exit [v6]

2023-10-24 Thread Valerie Peng
On Tue, 24 Oct 2023 16:37:12 GMT, Weijun Wang wrote: >> Remove most `System.exit()` calls in various security tools and only leave >> one in the `main` method. This paves the way to convert them to JSR 199 >> tools. >> >> Note: before this change, the behavior of a successful `main()` method

Re: RFR: 8316964: Security tools should not call System.exit [v6]

2023-10-24 Thread Weijun Wang
> Remove most `System.exit()` calls in various security tools and only leave > one in the `main` method. This paves the way to convert them to JSR 199 tools. > > Note: before this change, the behavior of a successful `main()` method > execution is not consistent. Sometimes the method returns sil

Re: RFR: 8316964: Security tools should not call System.exit [v5]

2023-10-24 Thread Valerie Peng
On Wed, 18 Oct 2023 17:22:31 GMT, Andrey Turbanov wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> inline some throw statements, remove duplicated whitespaces > > src/java.security.jgss/windows/classes/sun/security/k

Re: RFR: 8316964: Security tools should not call System.exit [v5]

2023-10-19 Thread Weijun Wang
On Fri, 20 Oct 2023 00:12:25 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> inline some throw statements, remove duplicated whitespaces > > src/java.base/share/classes/sun/security/tools/keytool/M

Re: RFR: 8316964: Security tools should not call System.exit [v5]

2023-10-19 Thread Valerie Peng
On Mon, 16 Oct 2023 16:23:13 GMT, Weijun Wang wrote: >> Remove most `System.exit()` calls in various security tools and only leave >> one in the `main` method. This paves the way to convert them to JSR 199 >> tools. >> >> Note: before this change, the behavior of a successful `main()` method

Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-18 Thread Valerie Peng
On Mon, 16 Oct 2023 14:32:33 GMT, Weijun Wang wrote: >> src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Ktab.java >> line 82: >> >>> 80: } >>> 81: >>> 82: private static class ExitException extends RuntimeException { >> >> If we want to use ExitException as int

Re: RFR: 8316964: Security tools should not call System.exit [v5]

2023-10-18 Thread Andrey Turbanov
On Mon, 16 Oct 2023 16:23:13 GMT, Weijun Wang wrote: >> Remove most `System.exit()` calls in various security tools and only leave >> one in the `main` method. This paves the way to convert them to JSR 199 >> tools. >> >> Note: before this change, the behavior of a successful `main()` method

Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-18 Thread Valerie Peng
On Mon, 16 Oct 2023 14:37:03 GMT, Weijun Wang wrote: >> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line >> 155: >> >>> 153: private static void exit(int exitCode) { >>> 154: throw new ExitException(exitCode); >>> 155: } >> >> I don't see much benefit o

Re: RFR: 8316964: Security tools should not call System.exit [v4]

2023-10-16 Thread Weijun Wang
On Mon, 16 Oct 2023 07:02:19 GMT, Andrey Turbanov wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> displayError > > src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Klist.java > line 151: > >

Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-16 Thread Weijun Wang
On Sat, 14 Oct 2023 00:00:52 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> typo > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line 155: > >> 153: private static vo

Re: RFR: 8316964: Security tools should not call System.exit [v5]

2023-10-16 Thread Weijun Wang
> Remove most `System.exit()` calls in various security tools and only leave > one in the `main` method. This paves the way to convert them to JSR 199 tools. > > Note: before this change, the behavior of a successful `main()` method > execution is not consistent. Sometimes the method returns sil

Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-16 Thread Weijun Wang
On Fri, 13 Oct 2023 23:58:58 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> typo > > src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Ktab.java > line 82: > >> 80: } >

Re: RFR: 8316964: Security tools should not call System.exit [v4]

2023-10-16 Thread Andrey Turbanov
On Fri, 13 Oct 2023 21:57:21 GMT, Weijun Wang wrote: >> Remove most `System.exit()` calls in various security tools and only leave >> one in the `main` method. This paves the way to convert them to JSR 199 >> tools. >> >> Note: before this change, the behavior of a successful `main()` method

Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-13 Thread Valerie Peng
On Tue, 10 Oct 2023 21:11:21 GMT, Weijun Wang wrote: >> Remove most `System.exit()` calls in various security tools and only leave >> one in the `main` method. This paves the way to convert them to JSR 199 >> tools. >> >> Note: before this change, the behavior of a successful `main()` method

Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-13 Thread Weijun Wang
On Fri, 13 Oct 2023 19:31:21 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> typo > > src/java.security.jgss/windows/classes/sun/security/krb5/internal/tools/Klist.java > line 155: > >> 153:

Re: RFR: 8316964: Security tools should not call System.exit [v4]

2023-10-13 Thread Weijun Wang
> Remove most `System.exit()` calls in various security tools and only leave > one in the `main` method. This paves the way to convert them to JSR 199 tools. > > Note: before this change, the behavior of a successful `main()` method > execution is not consistent. Sometimes the method returns sil

Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-13 Thread Valerie Peng
On Tue, 10 Oct 2023 21:11:21 GMT, Weijun Wang wrote: >> Remove most `System.exit()` calls in various security tools and only leave >> one in the `main` method. This paves the way to convert them to JSR 199 >> tools. >> >> Note: before this change, the behavior of a successful `main()` method

Re: RFR: 8316964: Security tools should not call System.exit [v3]

2023-10-10 Thread Weijun Wang
> Remove most `System.exit()` calls in various security tools and only leave > one in the `main` method. This paves the way to convert them to JSR 199 tools. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: typo - Changes

Re: RFR: 8316964: Security tools should not call System.exit [v2]

2023-10-10 Thread Weijun Wang
> Remove most `System.exit()` calls in various security tools and only leave > one in the `main` method. This paves the way to convert them to JSR 199 tools. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: let run return int

Re: RFR: 8316964: Security tools should not call System.exit

2023-10-03 Thread Weijun Wang
On Tue, 3 Oct 2023 21:06:44 GMT, ExE Boss wrote: >> Remove most `System.exit()` calls in various security tools and only leave >> one in the `main` method. This paves the way to convert them to JSR 199 >> tools. > > src/java.base/share/classes/sun/security/tools/keytool/Main.java line 433: > >

Re: RFR: 8316964: Security tools should not call System.exit

2023-10-03 Thread ExE Boss
On Wed, 27 Sep 2023 20:33:49 GMT, Weijun Wang wrote: > Remove most `System.exit()` calls in various security tools and only leave > one in the `main` method. This paves the way to convert them to JSR 199 tools. src/java.base/share/classes/sun/security/tools/keytool/Main.java line 433: > 431: