Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]

2024-09-12 Thread Nibedita Jena
On Thu, 12 Sep 2024 16:09:16 GMT, Weijun Wang wrote: >> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java >> line 167: >> >>> 165: {"history.with.ts", "- Signed by \"%1$s\"\nDigest >>> algorithm: %2$s\nSignature algorithm: %3$s, %4$s\n Timestamped by >

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]

2024-09-12 Thread Weijun Wang
On Thu, 12 Sep 2024 21:41:32 GMT, Hai-May Chao wrote: > Suggest to add testcases to remove more than one entry or file ending with > "*" in RemovedFiles. This can be a test to the `JarUtils` method itself. I can add one. > Do you think it may be useful to have a testcase that falsely reports t

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]

2024-09-12 Thread Hai-May Chao
On Thu, 12 Sep 2024 15:32:44 GMT, Weijun Wang wrote: >> There ~are two~ is one change~s~: >> >> 1. In `jarsigner -verify`, check a .SF file contains un-existing entries and >> print them out as >> >> Warning: nonexistent signed entries detected: [a] >> >> ~2. In `JarSigner::sign0`, when creat

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]

2024-09-12 Thread Hai-May Chao
On Thu, 12 Sep 2024 15:32:44 GMT, Weijun Wang wrote: >> There ~are two~ is one change~s~: >> >> 1. In `jarsigner -verify`, check a .SF file contains un-existing entries and >> print them out as >> >> Warning: nonexistent signed entries detected: [a] >> >> ~2. In `JarSigner::sign0`, when creat

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]

2024-09-12 Thread Weijun Wang
On Thu, 12 Sep 2024 16:01:13 GMT, Nibedita Jena wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> test enhancements > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java > line 167: > >> 165:

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]

2024-09-12 Thread Nibedita Jena
On Thu, 12 Sep 2024 15:32:44 GMT, Weijun Wang wrote: >> There ~are two~ is one change~s~: >> >> 1. In `jarsigner -verify`, check a .SF file contains un-existing entries and >> print them out as >> >> Warning: nonexistent signed entries detected: [a] >> >> ~2. In `JarSigner::sign0`, when creat

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]

2024-09-12 Thread Hai-May Chao
On Thu, 12 Sep 2024 15:32:44 GMT, Weijun Wang wrote: >> There ~are two~ is one change~s~: >> >> 1. In `jarsigner -verify`, check a .SF file contains un-existing entries and >> print them out as >> >> Warning: nonexistent signed entries detected: [a] >> >> ~2. In `JarSigner::sign0`, when creat

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]

2024-09-12 Thread Kevin Driver
On Thu, 12 Sep 2024 15:32:44 GMT, Weijun Wang wrote: >> There ~are two~ is one change~s~: >> >> 1. In `jarsigner -verify`, check a .SF file contains un-existing entries and >> print them out as >> >> Warning: nonexistent signed entries detected: [a] >> >> ~2. In `JarSigner::sign0`, when creat

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]

2024-09-12 Thread Weijun Wang
On Thu, 12 Sep 2024 15:01:59 GMT, Kevin Driver wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> test enhancements > > test/jdk/sun/security/tools/jarsigner/RemovedFiles.java line 52: > >> 50: >> 51: // Remo

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v2]

2024-09-12 Thread Weijun Wang
> There ~are two~ is one change~s~: > > 1. In `jarsigner -verify`, check a .SF file contains un-existing entries and > print them out as > > Warning: nonexistent signed entries detected: [a] > > ~2. In `JarSigner::sign0`, when creating a new .SF file, only include signed > file entries.~ > >