Re: RFR: 8298867: Basics.java fails with SSL handshake exception [v2]

2022-12-22 Thread Rajan Halade
On Thu, 22 Dec 2022 18:00:11 GMT, Matthew Donovan wrote: >> Updated to use specific ciphersuite and TLS protocol. >> Updated tests based on changes to SSLEngine implementation > > Matthew Donovan has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8298867: Basics.java fails with SSL handshake exception [v2]

2022-12-22 Thread Rajan Halade
On Thu, 22 Dec 2022 18:00:11 GMT, Matthew Donovan wrote: >> Updated to use specific ciphersuite and TLS protocol. >> Updated tests based on changes to SSLEngine implementation > > Matthew Donovan has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8298867: Basics.java fails with SSL handshake exception [v2]

2022-12-22 Thread Rajan Halade
On Thu, 22 Dec 2022 18:42:34 GMT, Xue-Lei Andrew Fan wrote: >> Matthew Donovan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added additional protocols > > test/jdk/javax/net/ssl/SSLEngine/Basics.java line 63: > >> 61: private sta

Re: RFR: 8298867: Basics.java fails with SSL handshake exception [v2]

2022-12-22 Thread Xue-Lei Andrew Fan
On Thu, 22 Dec 2022 18:00:11 GMT, Matthew Donovan wrote: >> Updated to use specific ciphersuite and TLS protocol. >> Updated tests based on changes to SSLEngine implementation > > Matthew Donovan has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8298867: Basics.java fails with SSL handshake exception [v2]

2022-12-22 Thread Xue-Lei Andrew Fan
On Thu, 22 Dec 2022 17:54:53 GMT, Matthew Donovan wrote: > > Looks good to me, although it would be nice to check more protocols. > > I extended the tests to include TLS 1.2 and 1.1 Thank you! - PR: https://git.openjdk.org/jdk/pull/11760

Re: RFR: 8298867: Basics.java fails with SSL handshake exception [v2]

2022-12-22 Thread Matthew Donovan
> Updated to use specific ciphersuite and TLS protocol. > Updated tests based on changes to SSLEngine implementation Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: added additional protocols - Changes: - all: https

Re: RFR: 8298867: Basics.java fails with SSL handshake exception [v2]

2022-12-22 Thread Matthew Donovan
On Thu, 22 Dec 2022 01:03:53 GMT, Xue-Lei Andrew Fan wrote: > Looks good to me, although it would be nice to check more protocols. I extended the tests to include TLS 1.2 and 1.1 - PR: https://git.openjdk.org/jdk/pull/11760