Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v5]

2022-08-15 Thread Weijun Wang
On Mon, 15 Aug 2022 16:17:42 GMT, Julian Waters wrote: >> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but >> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which >> is actually 1 on Windows, not -1. Can be safely commented out as it isn't >>

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v5]

2022-08-15 Thread Julian Waters
> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but > also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which > is actually 1 on Windows, not -1. Can be safely commented out as it isn't > used anywhere, except for in a call to ExitProcess which has

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v4]

2022-08-15 Thread Weijun Wang
On Sun, 14 Aug 2022 06:39:58 GMT, Julian Waters wrote: >> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but >> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which >> is actually 1 on Windows, not -1. Can be safely commented out as it isn't >>

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v4]

2022-08-15 Thread Julian Waters
On Sun, 14 Aug 2022 06:39:58 GMT, Julian Waters wrote: >> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but >> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which >> is actually 1 on Windows, not -1. Can be safely commented out as it isn't >>

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v4]

2022-08-15 Thread Weijun Wang
On Sun, 14 Aug 2022 06:39:58 GMT, Julian Waters wrote: >> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but >> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which >> is actually 1 on Windows, not -1. Can be safely commented out as it isn't >>

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v3]

2022-08-13 Thread Julian Waters
On Mon, 8 Aug 2022 05:45:03 GMT, Julian Waters wrote: >> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but >> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which >> is actually 1 on Windows, not -1. Can be safely commented out as it isn't >> u

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v4]

2022-08-13 Thread Julian Waters
> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but > also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which > is actually 1 on Windows, not -1. Can be safely commented out as it isn't > used anywhere, except for in a call to ExitProcess which has

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v2]

2022-08-07 Thread Julian Waters
On Sun, 7 Aug 2022 08:51:50 GMT, Julian Waters wrote: >> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but >> also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which >> is actually 1 on Windows, not -1. Can be safely commented out as it isn't >> u

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v3]

2022-08-07 Thread Julian Waters
> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but > also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which > is actually 1 on Windows, not -1. Can be safely commented out as it isn't > used anywhere, except for in a call to ExitProcess which has

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth [v2]

2022-08-07 Thread Julian Waters
> EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but > also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which > is actually 1 on Windows, not -1. Can be safely commented out as it isn't > used anywhere, except for in a call to ExitProcess which has

Re: RFR: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth

2022-08-03 Thread Julian Waters
On Thu, 28 Jul 2022 17:23:05 GMT, Julian Waters wrote: > EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but > also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which > is actually 1 on Windows, not -1. Can be safely commented out as it isn't > used