Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v5]

2022-10-11 Thread jquanC
On Sat, 23 Jul 2022 05:29:07 GMT, jquanC wrote: >> There are some doc errors in sun.security.util.DerOutputStream, like the >> followings, >> >> >> /** >> * Private helper routine for writing DER encoded string values. >> * @param s the string to write >> * @param stringTag one of the DER s

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v5]

2022-08-16 Thread jquanC
On Sat, 23 Jul 2022 05:37:16 GMT, jquanC wrote: >> Looks good to me. Thanks! > >> Looks good to me. Thanks! > > Cheers and appreciation! And I have learned more from your guidance. > @jquanC Please type`/integrate` if you want to get the fix included in > OpenJDK. Thanks for your reminder! I

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v5]

2022-08-16 Thread Weijun Wang
On Sat, 23 Jul 2022 05:37:16 GMT, jquanC wrote: >> Looks good to me. Thanks! > >> Looks good to me. Thanks! > > Cheers and appreciation! And I have learned more from your guidance. @jquanC Please type`/integrate` if you want to get the fix included in OpenJDK. - PR: https://git.o

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v5]

2022-07-22 Thread jquanC
On Sat, 23 Jul 2022 05:31:29 GMT, Xue-Lei Andrew Fan wrote: > Looks good to me. Thanks! Cheers and appreciation! And I have learned more from your guidance. - PR: https://git.openjdk.org/jdk/pull/9585

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v5]

2022-07-22 Thread Xue-Lei Andrew Fan
On Sat, 23 Jul 2022 05:29:07 GMT, jquanC wrote: >> There are some doc errors in sun.security.util.DerOutputStream, like the >> followings, >> >> >> /** >> * Private helper routine for writing DER encoded string values. >> * @param s the string to write >> * @param stringTag one of the DER s

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v5]

2022-07-22 Thread jquanC
> There are some doc errors in sun.security.util.DerOutputStream, like the > followings, > > > /** > * Private helper routine for writing DER encoded string values. > * @param s the string to write > * @param stringTag one of the DER string tags that indicate which > * encoding should be use