On Sat, 23 Jul 2022 05:29:07 GMT, jquanC <d...@openjdk.org> wrote:
>> There are some doc errors in sun.security.util.DerOutputStream, like the
>> followings,
>>
>>
>> /**
>> * Private helper routine for writing DER encoded string values.
>> * @param s the string to write
>> * @param stringTag one of the DER string tags that indicate which
>> * encoding should be used to write the string out.
>> * @param enc the name of the encoder that should be used corresponding
>> * to the above tag.
>> */
>> private void writeString(String s, byte stringTag, Charset charset) throws
>> IOException
>>
>> The parameter is charset, but not enc.
>>
>>
>> /**
>> * Marshals a DER integer on the output stream.
>> *
>> * @param i the integer in bytes, equivalent to BigInteger::toByteArray.
>> */
>> public void putInteger(byte[] buf) throws IOException {
>>
>> The parameter is buf, but not i.
>
> jquanC has updated the pull request incrementally with one additional commit
> since the last revision:
>
> 8290775: Some doc errors in DerOutputStream.java Update: add a
> modification and improve an expression according to the specification
Looks good to me. Thanks!
-------------
Marked as reviewed by xuelei (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9585
