On Thu, 7 Jul 2022 17:35:08 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 additional
>> commits sin
On Thu, 7 Jul 2022 02:45:42 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull r
On Thu, 30 Jun 2022 16:19:17 GMT, Mark Powers wrote:
>> src/java.base/share/classes/javax/crypto/SealedObject.java line 195:
>>
>>> 193: /**
>>> 194: * Constructs a SealedObject object from the passed-in
>>> 195: * SealedObject.
>>
>> Add `{@code }` to SealedObject?
>
> using `{@c
On Thu, 7 Jul 2022 18:48:59 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> final comments from Valerie
Ok with the changes under javax.crypto package.
On Thu, 7 Jul 2022 02:45:42 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull r
> https://bugs.openjdk.org/browse/JDK-8284851
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
final comments from Valerie
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9282/files
- new: https://git.openjdk.org/jd
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
I don't have more comments on the `java.security` pa
On Wed, 6 Jul 2022 20:50:19 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> aw shucks - another one
>
> src/java.base/share/classes/javax/crypto/Cipher.java line 1071:
>
>> 1069: * Returns th
On Wed, 6 Jul 2022 20:06:02 GMT, Weijun Wang wrote:
>> @see `{@link PermissionCollection#isReadOnly}`
>
> I think `@see PermissionCollection#isReadOnly` is enough.
Fixed.
-
PR: https://git.openjdk.org/jdk/pull/9282
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
src/java.base/share/classes/javax/crypto/CipherSpi.j
On Wed, 6 Jul 2022 20:46:44 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> aw shucks - another one
>
> src/java.base/share/classes/javax/crypto/Cipher.java line 144:
>
>> 142: *
>> 143: * Ever
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
src/java.base/share/classes/javax/crypto/Cipher.java
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
src/java.base/share/classes/javax/crypto/CryptoPermi
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
src/java.base/share/classes/javax/crypto/CipherOutpu
> https://bugs.openjdk.org/browse/JDK-8284851
Mark Powers has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 13 additional commits since the
last revision
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
src/java.base/share/classes/javax/crypto/CipherSpi.j
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
src/java.base/share/classes/javax/crypto/CryptoAllPe
On Wed, 6 Jul 2022 23:11:15 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> aw shucks - another one
>
> src/java.base/share/classes/javax/crypto/CryptoPermission.java line 359:
>
>> 357:
>> 358:
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
src/java.base/share/classes/javax/crypto/Cipher.java
On Wed, 6 Jul 2022 19:55:04 GMT, Mark Powers wrote:
>> src/java.base/share/classes/javax/crypto/CryptoPermissions.java line 135:
>>
>>> 133: * object is marked as readonly.
>>> 134: *
>>> 135: * @see isReadOnly
>>
>> Should be `PermissionCollection#isReadOnly`.
>
> @see `{@link P
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
src/java.base/share/classes/javax/crypto/Cipher.java
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
src/java.base/share/classes/javax/crypto/CipherSpi.j
On Wed, 6 Jul 2022 14:04:10 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> aw shucks - another one
>
> src/java.base/share/classes/java/security/AllPermission.java line 183:
>
>> 181: *
>> 18
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
src/java.base/share/classes/javax/crypto/CipherSpi.j
On Wed, 6 Jul 2022 19:54:57 GMT, Mark Powers wrote:
>> src/java.base/share/classes/java/security/CodeSource.java line 307:
>>
>>> 305: * and {@code null} certificates all imply
>>> 306: * the codesource with the location
>>> "http://www.example.com/classes/foo.jar";
>>> 307: * an
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
Last comments.
src/java.base/share/classes/java/sec
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
src/java.base/share/classes/javax/crypto/Cipher.java
> https://bugs.openjdk.org/browse/JDK-8284851
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
aw shucks - another one
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9282/files
- new: https://git.openjdk.org/jdk/pu
On Fri, 1 Jul 2022 23:59:02 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Max comments continued
Found and fixed a `{@code }` missing the `}`.
--
On Tue, 5 Jul 2022 15:37:55 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> aw shucks - another one
The pre-submit that fails doesn't appear to have any
On Tue, 28 Jun 2022 20:44:04 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/java/security/KeyStoreException.java line 44:
>
>> 42: /**
>> 43: *
On Fri, 1 Jul 2022 23:59:02 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Max comments continued
Marked as reviewed by kristyle...@github.com (no know
On Fri, 1 Jul 2022 23:59:02 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Max comments continued
Marked as reviewed by kristyle...@github.com (no know
On Fri, 1 Jul 2022 19:48:59 GMT, Mark Powers wrote:
>> src/java.base/share/classes/java/security/AllPermission.java line 201:
>>
>>> 199: /**
>>> 200: * Check and see if this set of permissions implies the permissions
>>> 201: * expressed in "permission".
>>
>> "this set of permis
> https://bugs.openjdk.org/browse/JDK-8284851
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
Max comments continued
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9282/files
- new: https://git.openjdk.org/jdk/pul
On Tue, 28 Jun 2022 20:58:17 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/java/security/Policy.java line 505:
>
>> 503: * A new {@code Policy} o
On Tue, 28 Jun 2022 20:19:29 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/java/security/AlgorithmParameterGenerator.java
> line 249:
>
>> 247: *
> https://bugs.openjdk.org/browse/JDK-8284851
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
Max comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9282/files
- new: https://git.openjdk.org/jdk/pull/9282/fil
On Tue, 28 Jun 2022 19:59:24 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/java/security/AccessController.java line 983:
>
>> 981:
>> 982: /**
>>
> https://bugs.openjdk.org/browse/JDK-8284851
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
Valerie fix continued
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9282/files
- new: https://git.openjdk.org/jdk/pull
On Wed, 29 Jun 2022 01:01:44 GMT, Bradford Wetmore wrote:
>> src/java.base/share/classes/javax/crypto/ProviderVerifier.java line 170:
>>
>>> 168: * NOTE: if this ProviderVerifier instance is
>>> constructed
>>> 169: * with "savePerms" equal to false, then this method would always
>>>
On Tue, 28 Jun 2022 22:06:00 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/javax/crypto/KeyGenerator.java line 297:
>>
>>> 295: *
>>> 296: * A new {@code KeyGenerator} object encapsulating the
>>> 297: * {@code KeyGeneratorSpi} implementation from the specified
>>> Pro
On Wed, 29 Jun 2022 21:29:41 GMT, Valerie Peng wrote:
>> In this case the sentence was about initializing a cipher object, so I
>> changed it to `{@code Cipher}`. If a sentence says "cipher block size" then
>> I tried to leave it alone because it's referring to an algorithm rather than
>> a cl
On Wed, 29 Jun 2022 21:31:31 GMT, Valerie Peng wrote:
>> Are you suggesting that whenever file is modified, **all** occurrences of
>> `` should be changed to `{@code }`?
>
> At least for new changes, I prefer to use new notations.. If its easier to
> replace all, that's fine with me too.
Chang
On Tue, 28 Jun 2022 20:17:23 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/AEADBadTagException.java line 48:
>
>> 46:
>> 47: /**
>>
On Tue, 28 Jun 2022 20:47:56 GMT, Mark Powers wrote:
>> src/java.base/share/classes/javax/crypto/AEADBadTagException.java line 41:
>>
>>> 39:
>>> 40: /**
>>> 41: * Constructs an AEADBadTagException with no detail
>>> message.
>>
>> Why not using the {@code } as in other files?
>
> I
On Tue, 28 Jun 2022 21:50:17 GMT, Mark Powers wrote:
>> src/java.base/share/classes/javax/crypto/CryptoPolicyParser.java line 47:
>>
>>> 45: * that JCE has new permission classes called
>>> 46: * javax.crypto.CryptoPermission and
>>> 47: * javax.crypto.CryptoAllPermission.
>>
>> Use` {@code
On Tue, 28 Jun 2022 21:09:56 GMT, Mark Powers wrote:
>> Personally, I'd against making this change, i.e. changing all "cipher"
>> occurrences to "{@code Cipher}". Can we just stick to fixing what's broken?
>
> In this case the sentence was about initializing a cipher object, so I
> changed it t
On Tue, 28 Jun 2022 22:13:25 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/ProviderVerifier.java line 170:
>
>> 168: * NOTE: if this
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/SecretKeyFactory.java
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/KeyGenerator.java line
On Tue, 28 Jun 2022 22:02:31 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/KeyGenerator.java line 297:
>
>> 295: *
>> 296: * A
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/KeyGenerator.java line
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/ExemptionMechanism.jav
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInf
On Tue, 28 Jun 2022 21:32:47 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/CryptoPolicyParser.java line 47:
>
>> 45: * that JCE has new
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CryptoPolicyParser.jav
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CryptoPermission.java
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CipherOutputStream.jav
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
This is the `java.security` part.
src/java.base/share/classes/
On Tue, 28 Jun 2022 20:33:17 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/javax/crypto/Cipher.java line 184:
>>
>>> 182:
>>> 183: /**
>>> 184: * Constant used to initialize {@code Cipher} to encryption mode.
>>
>> If it's lower case, we normally just leave it? Not sure what
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CipherOutputStream.jav
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CipherOutputStream.jav
On Tue, 28 Jun 2022 20:16:37 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/AEADBadTagException.java line 41:
>
>> 39:
>> 40: /**
>>
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/CipherInputStream.java
On Tue, 28 Jun 2022 20:21:34 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/javax/crypto/Cipher.java line 184:
>
>> 182:
>> 183: /**
>> 184:
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/javax/crypto/AEADBadTagException.ja
On Tue, 28 Jun 2022 19:31:54 GMT, Valerie Peng wrote:
>> Mark Powers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Valerie fix
>
> src/java.base/share/classes/java/security/AccessControlContext.java line 58:
>
>> 56: * of the current
> https://bugs.openjdk.org/browse/JDK-8284851
Mark Powers has updated the pull request incrementally with one additional
commit since the last revision:
Valerie fix
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9282/files
- new: https://git.openjdk.org/jdk/pull/9282/file
On Tue, 28 Jun 2022 19:32:07 GMT, Mark Powers wrote:
>> https://bugs.openjdk.org/browse/JDK-8284851
>
> Mark Powers has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Valerie fix
src/java.base/share/classes/java/security/AccessControlContext.
On Fri, 24 Jun 2022 16:48:46 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8284851
Missing '-': changed "JDK 8284851" to JDK-8284851.
From: TheShermanTanker ***@***.***>
Sent: Tuesday, June 28, 2022 4:12 AM
To: openjdk/jdk ***@***.***>
Cc: Mark Po
On Fri, 24 Jun 2022 16:48:46 GMT, Mark Powers wrote:
> https://bugs.openjdk.org/browse/JDK-8284851
@mcpowers Seems like Skara didn't correctly detect and link the JBS entry. Try
renaming your title to just "8284851" and see if that works (It may take a
while)
-
PR: https://git.op
https://bugs.openjdk.org/browse/JDK-8284851
-
Commit messages:
- mo polish
- polish
- Merge
- second round
- Merge
- first round
Changes: https://git.openjdk.org/jdk/pull/9282/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9282&range=00
Issue: https://bugs.openjdk.or
73 matches
Mail list logo
