Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-15 Thread Chen Liang
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request with a new target base due to a > merge or a rebase. The incremen

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-15 Thread duke
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request with a new target base due to a > merge or a rebase. The incremen

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-15 Thread Volkan Yazici
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request with a new target base due to a > merge or a rebase. The incremen

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-15 Thread Per Minborg
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request with a new target base due to a > merge or a rebase. The incremen

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-13 Thread Volkan Yazici
On Tue, 13 May 2025 15:51:12 GMT, Alan Bateman wrote: >> Volkan Yazici has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains nine additional >> commit

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-13 Thread John R Rose
On Wed, 7 May 2025 11:17:19 GMT, Volkan Yazici wrote: >> src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 302: >> >>> 300: * WARNING: This method does not perform any bound checks. >>> 301: */ >>> 302: int countPositives(byte[] ba, int off, int len); >> >>

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-13 Thread Alan Bateman
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request with a new target base due to a > merge or a rebase. The incremen

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-12 Thread Chen Liang
On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request with a new target base due to a > merge or a rebase. The incremen

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v7]

2025-05-12 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the mer

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v5]

2025-05-12 Thread Volkan Yazici
On Mon, 12 May 2025 17:07:57 GMT, Roger Riggs wrote: >> Volkan Yazici has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Prefixed `JavaLangAccess::stringConcat1` with `unchecked` >> - Fix `HexDigits` copyright year > > src/java.base/shar

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v6]

2025-05-12 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Apply suggestions from code review Co-authored-by: Ro

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v5]

2025-05-12 Thread Roger Riggs
On Mon, 12 May 2025 10:17:46 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with two additional > commits since the last revisi

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v4]

2025-05-12 Thread Volkan Yazici
On Mon, 12 May 2025 08:52:00 GMT, Jaikiran Pai wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix copyright years > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 461: > >> 459:

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v5]

2025-05-12 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with two additional commits since the last revision: - Prefixed `JavaLangAccess::stringConcat1` with `unchecked

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v4]

2025-05-12 Thread Jaikiran Pai
On Fri, 9 May 2025 08:31:35 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v4]

2025-05-12 Thread Jaikiran Pai
On Fri, 9 May 2025 08:31:35 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v4]

2025-05-12 Thread Per Minborg
On Fri, 9 May 2025 08:31:35 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v4]

2025-05-09 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Fix copyright years - Changes: - all: http

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v3]

2025-05-09 Thread Volkan Yazici
On Thu, 8 May 2025 14:51:48 GMT, Chen Liang wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Prefix touched methods with `unchecked` > > Let's re-approve after copyright fix. @liach, @minborg, I've fixed the copyr

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v3]

2025-05-09 Thread Volkan Yazici
On Thu, 8 May 2025 14:46:29 GMT, Chen Liang wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Prefix touched methods with `unchecked` > > src/java.base/share/classes/java/io/DataInputStream.java line 1: > >> 1: /*

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v3]

2025-05-08 Thread Chen Liang
On Wed, 7 May 2025 18:33:11 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v3]

2025-05-08 Thread Per Minborg
On Wed, 7 May 2025 18:33:11 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 07:52:37 GMT, Alan Bateman wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 332: > >

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 13:22:11 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 355: >> >>> 353: * UTF-16 representation. >>> 354: * >>> 355: * WARNING: This method does not perform any bound checks. >> >> Maybe not this P

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v3]

2025-05-07 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Prefix touched methods with `unchecked` - Ch

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 07:37:48 GMT, Alan Bateman wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 302: > >

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Raffaello Giulietti
On Wed, 7 May 2025 08:02:28 GMT, Alan Bateman wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 355: > >

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Alan Bateman
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Jaikiran Pai
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Alan Bateman
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Alan Bateman
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Fri, 2 May 2025 14:39:55 GMT, Roger Riggs wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 314: > >>

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Thu, 1 May 2025 13:00:37 GMT, Chen Liang wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 315: > >>

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 07:26:56 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Fix typo in pre-existing JavaDoc - Changes:

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods

2025-05-02 Thread Roger Riggs
On Thu, 1 May 2025 05:33:29 GMT, Volkan Yazici wrote: > Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 314: > 312: * > 313: * WARNING

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods

2025-05-01 Thread Chen Liang
On Thu, 1 May 2025 05:33:29 GMT, Volkan Yazici wrote: > Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 315: > 313: * WARNING: The caller of

RFR: 8353197: Document preconditions for JavaLangAccess methods

2025-04-30 Thread Volkan Yazici
Document preconditions on certain `JavaLangAccess` methods that use operations either unsafe and/or without range checks. - Commit messages: - Improve `JavaLangAccess` documentation Changes: https://git.openjdk.org/jdk/pull/24982/files Webrev: https://webrevs.openjdk.org/?repo=jd