Re: RFR: 8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures [v3]

2025-04-10 Thread Sean Mullan
On Fri, 4 Apr 2025 20:44:28 GMT, Artur Barashev wrote: >> Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (but not in certificate >> signatures). >> https://www.rfc-editor.org/rfc/rfc9155.html >> >> Also fixing a little TLSv1.3 spec violation bug: ECDSA_SHA1 should not be >> allowed for han

Re: RFR: 8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures [v3]

2025-04-07 Thread duke
On Fri, 4 Apr 2025 20:44:28 GMT, Artur Barashev wrote: >> Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (but not in certificate >> signatures). >> https://www.rfc-editor.org/rfc/rfc9155.html >> >> Also fixing a little TLSv1.3 spec violation bug: ECDSA_SHA1 should not be >> allowed for han

Re: RFR: 8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures [v3]

2025-04-04 Thread Artur Barashev
> Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (but not in certificate > signatures). > https://www.rfc-editor.org/rfc/rfc9155.html Artur Barashev has updated the pull request incrementally with one additional commit since the last revision: Disable ECDSA_SHA1 to be used for TLSv1.3 han

Re: RFR: 8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures [v2]

2025-04-04 Thread Artur Barashev
On Fri, 4 Apr 2025 17:50:58 GMT, Artur Barashev wrote: >> test/jdk/sun/security/ssl/SignatureScheme/DisableSHA1inHandshakeSignatureTLS12.java >> line 28: >> >>> 26: * @bug 8340321 >>> 27: * @summary Disable SHA-1 in TLS/DTLS 1.2 signatures. >>> 28: * This test only covers TLS 1.2. >

Re: RFR: 8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures [v2]

2025-04-04 Thread Artur Barashev
On Wed, 2 Apr 2025 15:58:00 GMT, Artur Barashev wrote: >> test/jdk/sun/security/ssl/SignatureScheme/DisableSHA1inHandshakeSignatureDTLS12.java >> line 34: >> >>> 32: */ >>> 33: >>> 34: import java.lang.Override; >> >> You shouldn't have to import java.lang.Override > > Indeed, thanks! For so

Re: RFR: 8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures [v2]

2025-04-04 Thread Artur Barashev
> Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (but not in certificate > signatures). > https://www.rfc-editor.org/rfc/rfc9155.html Artur Barashev has updated the pull request incrementally with one additional commit since the last revision: Add TLSv1.3 unit test - Changes

Re: RFR: 8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures

2025-04-04 Thread Artur Barashev
On Fri, 4 Apr 2025 17:18:44 GMT, Sean Mullan wrote: >> Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (but not in certificate >> signatures). >> https://www.rfc-editor.org/rfc/rfc9155.html > > test/jdk/sun/security/ssl/SignatureScheme/DisableSHA1inHandshakeSignatureTLS12.java > line 28: >

Re: RFR: 8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures

2025-04-04 Thread Sean Mullan
On Tue, 1 Apr 2025 20:53:01 GMT, Artur Barashev wrote: > Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (but not in certificate > signatures). > https://www.rfc-editor.org/rfc/rfc9155.html test/jdk/sun/security/ssl/SignatureScheme/DisableSHA1inHandshakeSignatureTLS12.java line 28: > 26:

Re: RFR: 8340321: Disable SHA-1 in TLS/DTLS 1.2 handshake signatures

2025-04-02 Thread Artur Barashev
On Wed, 2 Apr 2025 12:51:42 GMT, Matthew Donovan wrote: >> Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (but not in certificate >> signatures). >> https://www.rfc-editor.org/rfc/rfc9155.html > > test/jdk/sun/security/ssl/SignatureScheme/DisableSHA1inHandshakeSignatureDTLS12.java > line 34