Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v5]

2024-08-20 Thread Daniel Jeliński
On Tue, 20 Aug 2024 23:40:32 GMT, Anthony Scarpino wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v5]

2024-08-20 Thread Anthony Scarpino
> Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to establish > another session by avoiding the long TLS full han

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v4]

2024-08-20 Thread Anthony Scarpino
On Mon, 19 Aug 2024 19:26:19 GMT, Daniel Jeliński wrote: >> Anthony Scarpino has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - revert to synchronized >> - code review changes > > src/java.base/share/classes/sun/security/util/Cache.java

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v4]

2024-08-19 Thread Daniel Jeliński
On Sat, 3 Aug 2024 00:46:05 GMT, Anthony Scarpino wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session t

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v4]

2024-08-02 Thread Anthony Scarpino
> Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to establish > another session by avoiding the long TLS full han

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v3]

2024-08-02 Thread Daniel Jeliński
On Thu, 1 Aug 2024 20:40:12 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/sun/security/util/Cache.java line 280: >> >>> 278: // Locking is to protect QueueCacheEntry's from being removed from >>> the >>> 279: // cacheMap while another thread is adding new queue entries. >>

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v3]

2024-08-01 Thread Anthony Scarpino
On Mon, 29 Jul 2024 17:52:52 GMT, Daniel Jeliński wrote: >> Anthony Scarpino has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 21 commits: >> >> - Rework TLSBase for better testing >> - Tests working >> - Merge branch 'master' in

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v3]

2024-08-01 Thread Anthony Scarpino
On Mon, 29 Jul 2024 17:56:44 GMT, Daniel Jeliński wrote: >> Anthony Scarpino has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 21 commits: >> >> - Rework TLSBase for better testing >> - Tests working >> - Merge branch 'master' in

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v3]

2024-08-01 Thread Anthony Scarpino
On Mon, 29 Jul 2024 17:18:59 GMT, Daniel Jeliński wrote: >> Anthony Scarpino has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 21 commits: >> >> - Rework TLSBase for better testing >> - Tests working >> - Merge branch 'master' in

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v3]

2024-08-01 Thread Anthony Scarpino
On Mon, 29 Jul 2024 16:40:21 GMT, Daniel Jeliński wrote: >> Anthony Scarpino has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 21 commits: >> >> - Rework TLSBase for better testing >> - Tests working >> - Merge branch 'master' in

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v3]

2024-07-29 Thread Daniel Jeliński
On Wed, 17 Jul 2024 02:47:33 GMT, Anthony Scarpino wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-07-29 Thread Anthony Scarpino
On Thu, 27 Jun 2024 18:10:37 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/sun/security/util/Cache.java line 716: >> >>> 714: } >>> 715: if (entry.isValid(time)) { >>> 716: // SoftReference get() returns the same as >>> entry.ge

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v3]

2024-07-16 Thread Anthony Scarpino
> Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to establish > another session by avoiding the long TLS full han

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-07-16 Thread Anthony Scarpino
On Tue, 25 Jun 2024 09:57:46 GMT, Daniel Jeliński wrote: > Please add a test that starts multiple resumptions in parallel using the > tickets received in the first connection. The test should verify that: > > * each resumption uses a different ticket > > * all resumptions succeed > >

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-07-16 Thread Anthony Scarpino
On Mon, 24 Jun 2024 16:03:43 GMT, Anthony Scarpino wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-06-27 Thread Anthony Scarpino
On Tue, 25 Jun 2024 09:14:12 GMT, Daniel Jeliński wrote: >> Anthony Scarpino has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - remove frag issue >> - Comments, remove thread, set NST default to 1, allow 0 >> - comment cleanup > > src

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-06-27 Thread Anthony Scarpino
On Tue, 25 Jun 2024 09:38:04 GMT, Daniel Jeliński wrote: >> Anthony Scarpino has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - remove frag issue >> - Comments, remove thread, set NST default to 1, allow 0 >> - comment cleanup > > src

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-06-25 Thread Daniel Jeliński
On Mon, 24 Jun 2024 16:03:43 GMT, Anthony Scarpino wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v2]

2024-06-24 Thread Anthony Scarpino
> Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to establish > another session by avoiding the long TLS full han

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread John Jiang
On Fri, 21 Jun 2024 15:35:46 GMT, Anthony Scarpino wrote: > Let me start from the beginning and hopefully it will clear things up. > > Today, each Finished connection gets one resumption ticket. That session's > SSLContext contains the cache. When someone wants to resume, they use the > same

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread Anthony Scarpino
On Fri, 21 Jun 2024 17:17:57 GMT, Sibabrata Sahoo wrote: > > > Just for knowledge: If the client has multiple PSK Identity previously > > > shared by server and client initiate a PSK resumption of type(psk_dhe_ke) > > > and it receive a HelloRetryRequest from Server, then should client send >

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread Sibabrata Sahoo
On Fri, 21 Jun 2024 16:09:49 GMT, Anthony Scarpino wrote: > > Just for knowledge: If the client has multiple PSK Identity previously > > shared by server and client initiate a PSK resumption of type(psk_dhe_ke) > > and it receive a HelloRetryRequest from Server, then should client send the >

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread Anthony Scarpino
On Fri, 21 Jun 2024 09:54:34 GMT, Sibabrata Sahoo wrote: > Just for knowledge: If the client has multiple PSK Identity previously shared > by server and client initiate a PSK resumption of type(psk_dhe_ke) and it > receive a HelloRetryRequest from Server, then should client send the same PSK >

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread Anthony Scarpino
On Fri, 21 Jun 2024 08:15:42 GMT, John Jiang wrote: > > The application calls `getSession()` from the same SSLContext of the > > original connection. > > ... > > The remaining tickets sit on the client if they need them. Some > > applications may choose to resume multiple times to download data

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread Sibabrata Sahoo
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-21 Thread John Jiang
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-20 Thread Anthony Scarpino
On Thu, 20 Jun 2024 05:15:10 GMT, John Jiang wrote: > This enhancement allows the server side to send multiple tickets and the > client side to store multiple ones. However, how does the client side use the > tickets in the cache? Yes > > This PR just takes the client side to find the first

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-19 Thread John Jiang
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-19 Thread John Jiang
On Wed, 5 Jun 2024 17:33:02 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/sun/security/util/Cache.java line 683: >> >>> 681: >>> 682: // Limit the number of queue entries. >>> 683: private static final int MAXQUEUESIZE = 10; >> >> What do you think about making th

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-19 Thread John Jiang
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-19 Thread Anthony Scarpino
On Wed, 19 Jun 2024 02:43:56 GMT, John Jiang wrote: >> All the T13 log messages use the same format. I agree it is different from >> the T12 log messages, but it helps distinguish the failures for different >> protocols. >> Though saying "session timed out" is probably better > > Here the sess

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-18 Thread Anthony Scarpino
On Fri, 14 Jun 2024 09:14:50 GMT, Daniel Jeliński wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session t

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-18 Thread John Jiang
On Wed, 19 Jun 2024 00:04:54 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java line 369: >> >>> 367: if (SSLLogger.isOn && SSLLogger.isOn("ssl,handshake")) >>> { >>> 368: SSLLogger.fine("No session ticket prod

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-18 Thread Anthony Scarpino
On Tue, 18 Jun 2024 06:53:25 GMT, Andrey Turbanov wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session t

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-18 Thread Anthony Scarpino
On Tue, 18 Jun 2024 07:41:06 GMT, John Jiang wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session to >>

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-18 Thread John Jiang
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-17 Thread Andrey Turbanov
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-17 Thread Anthony Scarpino
On Mon, 17 Jun 2024 16:28:16 GMT, Daniel Jeliński wrote: >> Maybe the comment could use some rewording, but I tried to not write whole >> bug report in a code comment. >> >> When this was first prototyped as non-threaded, the SocketException occurred >> because multiple NSTs were sent after th

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-17 Thread Daniel Jeliński
On Fri, 14 Jun 2024 22:48:59 GMT, Anthony Scarpino wrote: >> On the contrary, you are in control of this error. The client OS resets the >> connection whenever the client closes the socket without reading all >> available data from the buffers. When the reset is delivered to the server, >> an

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 18:51:02 GMT, Daniel Jeliński wrote: >> This is a low level networking error beyond my control. All this code can >> do is accept that the operating system has sent it a fatal error that has >> blocked the servers ability to read data from the socket on data that was by >>

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Daniel Jeliński
On Fri, 14 Jun 2024 16:44:42 GMT, Anthony Scarpino wrote: >> And your suggestion would be? > > This is a low level networking error beyond my control. All this code can do > is accept that the operating system has sent it a fatal error that has > blocked the servers ability to read data from

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 07:46:19 GMT, Daniel Jeliński wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session t

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 01:14:55 GMT, Jamil Nimeh wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session to >

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 09:09:58 GMT, Daniel Jeliński wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session t

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 16:18:07 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java line 388: >> >>> 386: /* >>> 387: * This thread addresses a Windows only networking issue >>> found with >>> 388: * SSLSocketBru

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Anthony Scarpino
On Fri, 14 Jun 2024 08:42:23 GMT, Daniel Jeliński wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session t

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Daniel Jeliński
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-14 Thread Daniel Jeliński
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-13 Thread Jamil Nimeh
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-13 Thread Anthony Scarpino
Hi This change is to improve TLS 1.3 session resumption by allowing a TLS server to send more than one resumption ticket per connection and clients to store more. Resumption is a quick way to use an existing TLS session to establish another session by avoiding the long TLS full handshake proce

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-13 Thread Jamil Nimeh
On Wed, 29 May 2024 18:53:55 GMT, Anthony Scarpino wrote: > Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to e

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS

2024-06-13 Thread Anthony Scarpino
On Tue, 4 Jun 2024 15:04:56 GMT, Jamil Nimeh wrote: >> Hi >> >> This change is to improve TLS 1.3 session resumption by allowing a TLS >> server to send more than one resumption ticket per connection and clients to >> store more. Resumption is a quick way to use an existing TLS session to >>