Re: RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run

2023-11-10 Thread Daniel Jeliński
On Mon, 23 Oct 2023 16:23:55 GMT, Daniel Jeliński wrote: > Remove the hardcoded maximum heap size. > > Verified that the benchmark now passes with 100 threads given sufficient heap: > > make test TEST=micro:CacheBench MICRO="OPTIONS=-t 100;JAVA_OPTIONS=-Xmx16g" I introduced the limit originall

Re: RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run

2023-11-09 Thread Claes Redestad
On Mon, 23 Oct 2023 16:23:55 GMT, Daniel Jeliński wrote: > Remove the hardcoded maximum heap size. > > Verified that the benchmark now passes with 100 threads given sufficient heap: > > make test TEST=micro:CacheBench MICRO="OPTIONS=-t 100;JAVA_OPTIONS=-Xmx16g" Marked as reviewed by redestad (

Re: RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run

2023-11-09 Thread Sean Mullan
On Mon, 23 Oct 2023 16:23:55 GMT, Daniel Jeliński wrote: > Remove the hardcoded maximum heap size. > > Verified that the benchmark now passes with 100 threads given sufficient heap: > > make test TEST=micro:CacheBench MICRO="OPTIONS=-t 100;JAVA_OPTIONS=-Xmx16g" Looks ok to me but I would reque

RFR: 8318479: [jmh] the test security.CacheBench failed for multiple threads run

2023-10-23 Thread Daniel Jeliński
Remove the hardcoded maximum heap size. Verified that the benchmark now passes with 100 threads given sufficient heap: make test TEST=micro:CacheBench MICRO="OPTIONS=-t 100;JAVA_OPTIONS=-Xmx16g" - Commit messages: - Remove hardcoded Xmx Changes: https://git.openjdk.org/jdk/pull/16